Attachment 171783 Details for Bug 316676 – Propsed Fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Propsed Fix

clipboard.txt (text/plain), 1.70 KB, created by Rüdiger Herrmann

on 2010-06-12 09:10:28 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rüdiger Herrmann

Created: 2010-06-12 09:10:28 EDT

Size: 1.70 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt
>Index: src/org/eclipse/rwt/internal/service/ServiceStateInfo.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt/src/org/eclipse/rwt/internal/service/ServiceStateInfo.java,v
>retrieving revision 1.7
>diff -u -r1.7 ServiceStateInfo.java
>--- src/org/eclipse/rwt/internal/service/ServiceStateInfo.java	11 Jun 2010 21:55:02 -0000	1.7
>+++ src/org/eclipse/rwt/internal/service/ServiceStateInfo.java	12 Jun 2010 13:09:03 -0000
>@@ -25,27 +25,37 @@
> 
>   private HtmlResponseWriter responseWriter;
>   private final Map attributes;
>+  private final Object lock;
>   
>   public ServiceStateInfo() {
>     attributes = new HashMap();
>+    lock = new Object();
>   }
>   
>   /** <p>Sets the given <code>responseWriter</code> for the current request.
>    * </p> */
>   public void setResponseWriter( final HtmlResponseWriter responseWriter ) {
>-    this.responseWriter = responseWriter;
>+    synchronized( lock ) {
>+      this.responseWriter = responseWriter;
>+    }
>   }
> 
>   /** <p>Returns the currently set responseWriter.</p> */
>   public HtmlResponseWriter getResponseWriter() {
>-    return responseWriter;
>+    synchronized( lock ) {
>+      return responseWriter;
>+    }
>   }
>   
>   public Object getAttribute( final String key ) {
>-    return attributes.get( key );
>+    synchronized( lock ) {
>+      return attributes.get( key );
>+    }
>   }
> 
>   public void setAttribute( final String key, final Object value ) {
>-    attributes.put( key, value );
>+    synchronized( lock ) {
>+      attributes.put( key, value );
>+    }
>   }
> }
>\ No newline at end of file

Actions: View | Diff

Attachments on bug 316676: 171783 | 171976