Attachment 170720 Details for Bug 312098 – Took Teodor patch and cleaned it up a little.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Took Teodor patch and cleaned it up a little.

bugzilla_312098_randy.patch (text/plain), 3.00 KB, created by Randy Rohrbach

on 2010-06-01 18:30:05 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Randy Rohrbach

Created: 2010-06-01 18:30:05 EDT

Size: 3.00 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.cdt.debug.ui.memory.memorybrowser
>Index: src/org/eclipse/cdt/debug/ui/memory/memorybrowser/GoToAddressBarWidget.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.memorybrowser/src/org/eclipse/cdt/debug/ui/memory/memorybrowser/GoToAddressBarWidget.java,v
>retrieving revision 1.4
>diff -u -r1.4 GoToAddressBarWidget.java
>--- src/org/eclipse/cdt/debug/ui/memory/memorybrowser/GoToAddressBarWidget.java	1 Jun 2010 19:56:39 -0000	1.4
>+++ src/org/eclipse/cdt/debug/ui/memory/memorybrowser/GoToAddressBarWidget.java	1 Jun 2010 22:29:10 -0000
>@@ -77,15 +77,13 @@
> 			}
> 		});
> 		fEmptyExpression = new ControlDecoration(expression, SWT.LEFT | SWT.CENTER);
>-		fEmptyExpression.setDescriptionText("Enter an expression to position rendering");
>-		FieldDecoration fieldDecoration = FieldDecorationRegistry.getDefault()
>-		.getFieldDecoration(FieldDecorationRegistry.DEC_REQUIRED);
>-		fEmptyExpression.setImage(fieldDecoration.getImage());
>+		fEmptyExpression.setDescriptionText(Messages.getString("GoToAddressBarWidget.EnterExpressionMessage")); //$NON-NLS-1$
>+		FieldDecoration fieldDec = FieldDecorationRegistry.getDefault().getFieldDecoration(FieldDecorationRegistry.DEC_REQUIRED);
>+		fEmptyExpression.setImage(fieldDec.getImage());
> 
> 		fWrongExpression = new ControlDecoration(expression, SWT.LEFT | SWT.TOP);
>-		fieldDecoration = FieldDecorationRegistry.getDefault()
>-		.getFieldDecoration(FieldDecorationRegistry.DEC_ERROR);
>-		fWrongExpression.setImage(fieldDecoration.getImage());
>+		fieldDec = FieldDecorationRegistry.getDefault().getFieldDecoration(FieldDecorationRegistry.DEC_ERROR);
>+		fWrongExpression.setImage(fieldDec.getImage());
> 		fWrongExpression.hide();
> 		
> 		// leave enough room for decorators
>@@ -96,7 +94,7 @@
> 	}
> 		
> 	protected void updateButtons() {
>-		boolean empty = fExpression.getText().trim().length() == 0;
>+		boolean empty = getExpressionText().length() == 0;
> 		
> 		fOKNewTabButton.setEnabled(!empty);
> 		fOKButton.setEnabled(!empty);
>Index: src/org/eclipse/cdt/debug/ui/memory/memorybrowser/messages.properties
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.memorybrowser/src/org/eclipse/cdt/debug/ui/memory/memorybrowser/messages.properties,v
>retrieving revision 1.4
>diff -u -r1.4 messages.properties
>--- src/org/eclipse/cdt/debug/ui/memory/memorybrowser/messages.properties	30 Oct 2009 19:07:41 -0000	1.4
>+++ src/org/eclipse/cdt/debug/ui/memory/memorybrowser/messages.properties	1 Jun 2010 22:29:10 -0000
>@@ -9,6 +9,7 @@
> #     Ted R Williams (Wind River Systems, Inc.) - initial implementation
> ###############################################################################
> 
>+GoToAddressBarWidget.EnterExpressionMessage=Enter an expression
> GoToAddressBarWidget.Go=Go
> GoToAddressBarWidget.Go=Go
> GoToAddressBarWidget.NewTab=New Tab

Actions: View | Diff

Attachments on bug 312098: 167679 | 167680 | 167681 | 168643 | 168813 | 168975 | 170720