Attachment 169842 Details for Bug 313741 – Plugin.savePluginPreferences patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Plugin.savePluginPreferences patch

313741.txt (text/plain), 1.75 KB, created by Thomas Watson

on 2010-05-25 11:11:41 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Watson

Created: 2010-05-25 11:11:41 EDT

Size: 1.75 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.core.runtime
>Index: src/org/eclipse/core/runtime/Plugin.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.runtime/src/org/eclipse/core/runtime/Plugin.java,v
>retrieving revision 1.111
>diff -u -r1.111 Plugin.java
>--- src/org/eclipse/core/runtime/Plugin.java	4 Dec 2009 16:47:35 -0000	1.111
>+++ src/org/eclipse/core/runtime/Plugin.java	25 May 2010 15:08:45 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2009 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -17,6 +17,7 @@
> import java.util.Map;
> import org.eclipse.core.internal.runtime.*;
> import org.eclipse.core.runtime.preferences.*;
>+import org.eclipse.osgi.service.datalocation.Location;
> import org.eclipse.osgi.service.debug.DebugOptions;
> import org.eclipse.osgi.util.NLS;
> import org.osgi.framework.*;
>@@ -387,6 +388,12 @@
> 	 * @deprecated Replaced by InstanceScope.getNode(&lt;bundleId&gt;).flush()
> 	 */
> 	public final void savePluginPreferences() {
>+		
>+		Location instance = InternalPlatform.getDefault().getInstanceLocation();
>+		if (instance == null || !instance.isSet())
>+			// If the instance area is not set there is no point in getting or setting the preferences.
>+			// There is nothing to save in this case.
>+			return;
> 		// populate the "preferences" instance variable. We still might
> 		// need to save them because someone else might have
> 		// made changes via the OSGi APIs.

Actions: View | Diff

Attachments on bug 313741: 169810 | 169842