Attachment 168988 Details for Bug 278172 – updated patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] updated patch

patchFor278172 (text/plain), 1.44 KB, created by Chris Jaun

on 2010-05-18 14:07:43 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Jaun

Created: 2010-05-18 14:07:43 EDT

Size: 1.44 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.wst.jsdt.core
>Index: src/org/eclipse/wst/jsdt/core/infer/InferEngine.java
>===================================================================
>RCS file: /cvsroot/webtools/org.eclipse.jsdt/plugins/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/core/infer/InferEngine.java,v
>retrieving revision 1.57
>diff -u -r1.57 InferEngine.java
>--- src/org/eclipse/wst/jsdt/core/infer/InferEngine.java	29 Apr 2010 04:39:03 -0000	1.57
>+++ src/org/eclipse/wst/jsdt/core/infer/InferEngine.java	18 May 2010 18:06:31 -0000
>@@ -1340,7 +1340,9 @@
> 				{
> 					char []name={};
> 					for (int j = 0; j < param.types.length; j++) {
>-						char []typeName=param.types[j].getSimpleTypeName();
>+						//char []typeName=param.types[j].getSimpleTypeName();
>+						//make sure we are using the type version of Boolean, even if the user entered boolean as the JSdoc type.
>+						char []typeName=changePrimitiveToObject(param.types[j].getSimpleTypeName());
> 						if (j==0)
> 							name=typeName;
> 						else
>@@ -1855,5 +1857,12 @@
> 	{
> 		return compUnit.findInferredType(className);
> 	}
>+	
>+	public char[] changePrimitiveToObject(char[] name) {
>+		//Changes the first character of the name of the primitive types to uppercase. This will allow future reference to the object wrapper instead of the primitive type.
>+		if(CharOperation.equals(name, "boolean".toCharArray(), false)) //$NON-NLS-1$
>+			return BooleanType.getName();
>+		return name;
>+	}
> 
> }

Actions: View | Diff

Attachments on bug 278172: 137449 | 137450 | 166271 | 168988 | 169117 | 169259 | 169260