Attachment 168975 Details for Bug 312098 – Externalize String fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Externalize String fix

ExternalizeGoTo.txt (text/plain), 2.93 KB, created by Teodor Madan

on 2010-05-18 13:30:22 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Teodor Madan

Created: 2010-05-18 13:30:22 EDT

Size: 2.93 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.cdt.debug.ui.memory.memorybrowser
>Index: src/org/eclipse/cdt/debug/ui/memory/memorybrowser/GoToAddressBarWidget.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.memorybrowser/src/org/eclipse/cdt/debug/ui/memory/memorybrowser/GoToAddressBarWidget.java,v
>retrieving revision 1.3
>diff -u -r1.3 GoToAddressBarWidget.java
>--- src/org/eclipse/cdt/debug/ui/memory/memorybrowser/GoToAddressBarWidget.java	16 May 2010 03:20:21 -0000	1.3
>+++ src/org/eclipse/cdt/debug/ui/memory/memorybrowser/GoToAddressBarWidget.java	18 May 2010 17:28:24 -0000
>@@ -77,15 +77,15 @@
> 			}
> 		});
> 		fEmptyExpression = new ControlDecoration(expression, SWT.LEFT | SWT.CENTER);
>-		fEmptyExpression.setDescriptionText("Enter an expression to position rendering");
>+		fEmptyExpression.setDescriptionText(Messages.getString("GoToAddressBarWidget.EnterExpressionMessage")); //$NON-NLS-1$
> 		FieldDecoration fieldDecoration = FieldDecorationRegistry.getDefault()
>-		.getFieldDecoration(FieldDecorationRegistry.DEC_REQUIRED);
>+				.getFieldDecoration(FieldDecorationRegistry.DEC_REQUIRED);
> 		fEmptyExpression.setImage(fieldDecoration.getImage());
> 
> 		fWrongExpression = new ControlDecoration(expression, SWT.LEFT | SWT.TOP);
>-		fieldDecoration = FieldDecorationRegistry.getDefault()
>-		.getFieldDecoration(FieldDecorationRegistry.DEC_ERROR);
>-		fWrongExpression.setImage(fieldDecoration.getImage());
>+		FieldDecoration errFieldDecoration = FieldDecorationRegistry.getDefault()
>+				.getFieldDecoration(FieldDecorationRegistry.DEC_ERROR);
>+		fWrongExpression.setImage(errFieldDecoration.getImage());
> 		fWrongExpression.hide();
> 		
> 		// leave enough room for decorators
>@@ -96,7 +96,7 @@
> 	}
> 		
> 	protected void updateButtons() {
>-		boolean empty = fExpression.getText().trim().length() == 0;
>+		boolean empty = getExpressionText().length() == 0;
> 		
> 		fOKNewTabButton.setEnabled(!empty);
> 		fOKButton.setEnabled(!empty);
>Index: src/org/eclipse/cdt/debug/ui/memory/memorybrowser/messages.properties
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.memorybrowser/src/org/eclipse/cdt/debug/ui/memory/memorybrowser/messages.properties,v
>retrieving revision 1.4
>diff -u -r1.4 messages.properties
>--- src/org/eclipse/cdt/debug/ui/memory/memorybrowser/messages.properties	30 Oct 2009 19:07:41 -0000	1.4
>+++ src/org/eclipse/cdt/debug/ui/memory/memorybrowser/messages.properties	18 May 2010 17:28:24 -0000
>@@ -9,6 +9,7 @@
> #     Ted R Williams (Wind River Systems, Inc.) - initial implementation
> ###############################################################################
> 
>+GoToAddressBarWidget.EnterExpressionMessage=Enter an expression
> GoToAddressBarWidget.Go=Go
> GoToAddressBarWidget.Go=Go
> GoToAddressBarWidget.NewTab=New Tab

Flags:

john.cortell: iplog-

Actions: View | Diff

Attachments on bug 312098: 167679 | 167680 | 167681 | 168643 | 168813 | 168975 | 170720