Attachment 168827 Details for Bug 305694 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

patchFor305694 (text/plain), 15.54 KB, created by Chris Jaun

on 2010-05-17 17:04:31 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Jaun

Created: 2010-05-17 17:04:31 EDT

Size: 15.54 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.wst.jsdt.core
>Index: src/org/eclipse/wst/jsdt/internal/codeassist/CompletionEngine.java
>===================================================================
>RCS file: /cvsroot/webtools/org.eclipse.jsdt/plugins/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/codeassist/CompletionEngine.java,v
>retrieving revision 1.67
>diff -u -r1.67 CompletionEngine.java
>--- src/org/eclipse/wst/jsdt/internal/codeassist/CompletionEngine.java	16 Apr 2010 18:32:11 -0000	1.67
>+++ src/org/eclipse/wst/jsdt/internal/codeassist/CompletionEngine.java	17 May 2010 21:03:53 -0000
>@@ -83,6 +83,7 @@
> import org.eclipse.wst.jsdt.internal.compiler.ast.ConstructorDeclaration;
> import org.eclipse.wst.jsdt.internal.compiler.ast.Expression;
> import org.eclipse.wst.jsdt.internal.compiler.ast.FieldDeclaration;
>+import org.eclipse.wst.jsdt.internal.compiler.ast.FieldReference;
> import org.eclipse.wst.jsdt.internal.compiler.ast.ImportReference;
> import org.eclipse.wst.jsdt.internal.compiler.ast.Initializer;
> import org.eclipse.wst.jsdt.internal.compiler.ast.InstanceOfExpression;
>@@ -623,7 +624,11 @@
> 				flatEnclosingTypeNames = CharOperation.concatWith(acceptedType.enclosingTypeNames, '.');
> 				typeName = CharOperation.concat(flatEnclosingTypeNames, simpleTypeName, '.');
> 			}
>-			char[] fullyQualifiedName = CharOperation.concat(packageName, typeName, '.');
>+			
>+			char[] fullyQualifiedName = typeName;
>+			if(CharOperation.indexOf('.', typeName) < 0) {
>+				fullyQualifiedName = CharOperation.concat(packageName, typeName, '.');
>+			}
> 
> 			if (this.knownTypes.containsKey(fullyQualifiedName)) continue next;
> 
>@@ -1150,7 +1155,12 @@
> 		relevance += computeRelevanceForQualification(isQualified);
> 		relevance += computeRelevanceForClass();
> 		relevance += computeRelevanceForException(simpleTypeName);
>-
>+		
>+		// put proposals that have '_' at the start of their final segment down the list
>+		char[] lastSegment = CharOperation.lastSegment(completionName, '.');
>+		if(CharOperation.indexOf('_', lastSegment) == 0) {
>+			relevance--;
>+		}
> 		this.noProposal = false;
> 		if(!this.requestor.isIgnored(CompletionProposal.TYPE_REF)) {
> 			createTypeProposal(packageName, typeName, modifiers, accessibility, completionName, relevance);
>@@ -1641,67 +1651,81 @@
> 			long completionPosition = access.nameSourcePosition;
> 			setSourceRange((int) (completionPosition >>> 32), (int) completionPosition);
> 
>-			this.completionToken = access.token;
> 
>-			if (qualifiedBinding.problemId() == ProblemReasons.NotFound) {
>-				// complete method members with missing return type
>-				// class X {
>-				//   Missing f() {return null;}
>-				//   void foo() {
>-				//     f().|
>-				//   }
>-				// }
>-				if (this.assistNodeInJavadoc == 0 &&
>-						(this.requestor.isAllowingRequiredProposals(CompletionProposal.FIELD_REF, CompletionProposal.TYPE_REF) ||
>-								this.requestor.isAllowingRequiredProposals(CompletionProposal.METHOD_REF, CompletionProposal.TYPE_REF))) {
>-					ProblemMethodBinding problemMethodBinding = (ProblemMethodBinding) qualifiedBinding;
>-					findFieldsAndMethodsFromMissingReturnType(
>-							problemMethodBinding.selector,
>-							problemMethodBinding.parameters,
>-							scope,
>-							access,
>-							insideTypeAnnotation);
>-				}
>+
>+//			this.assistNodeIsClass = true;
>+//			this.assistNodeIsConstructor = true;
>+
>+			// can be the start of a qualified type name
>+			if (qualifiedBinding == null) {
>+			
>+					this.completionToken = computeToken(access);
>+					setSourceRange((int) (completionPosition >>> 32) - (this.completionToken.length - access.token.length), (int) completionPosition);
>+				
>+					ObjectVector typesFound = new ObjectVector();
>+					findTypesAndPackages(this.completionToken, scope, typesFound);
> 			} else {
>-				if (!access.isInsideAnnotation) {
>-					if (!this.requestor.isIgnored(CompletionProposal.KEYWORD)) {
>-						findKeywords(this.completionToken, new char[][]{Keywords.NEW}, false, false);
>+				this.completionToken = access.token;
>+				if (qualifiedBinding.problemId() == ProblemReasons.NotFound) {
>+					// complete method members with missing return type
>+					// class X {
>+					//   Missing f() {return null;}
>+					//   void foo() {
>+					//     f().|
>+					//   }
>+					// }
>+					if (this.assistNodeInJavadoc == 0 &&
>+							(this.requestor.isAllowingRequiredProposals(CompletionProposal.FIELD_REF, CompletionProposal.TYPE_REF) ||
>+									this.requestor.isAllowingRequiredProposals(CompletionProposal.METHOD_REF, CompletionProposal.TYPE_REF))) {
>+						ProblemMethodBinding problemMethodBinding = (ProblemMethodBinding) qualifiedBinding;
>+						findFieldsAndMethodsFromMissingReturnType(
>+								problemMethodBinding.selector,
>+								problemMethodBinding.parameters,
>+								scope,
>+								access,
>+								insideTypeAnnotation);
> 					}
>-
>-					findFieldsAndMethods(
>-						this.completionToken,
>-						((TypeBinding) qualifiedBinding),
>-						scope,
>-						access,
>-						scope,
>-						access.isStatic,
>-						false,
>-						access.receiver instanceof SuperReference,
>-						null,
>-						null,
>-						null,
>-						false);
>-					if (qualifiedBinding instanceof FunctionTypeBinding) {
>-						FunctionTypeBinding functionTypeBinding = (FunctionTypeBinding) qualifiedBinding;
>-						if (functionTypeBinding.functionBinding!=null && functionTypeBinding.functionBinding.isConstructor())
>-						{
>-							ReferenceBinding declaringClass = (ReferenceBinding)functionTypeBinding.functionBinding.returnType;
>-							findFieldsAndMethods(
>-									this.completionToken,
>-									declaringClass,
>-									scope,
>-									access,
>-									scope,
>-									true,
>-									false,
>-									access.receiver instanceof SuperReference,
>-									null,
>-									null,
>-									null,
>-									false);
>+				} else {
>+					if (!access.isInsideAnnotation) {
>+						if (!this.requestor.isIgnored(CompletionProposal.KEYWORD)) {
>+							findKeywords(this.completionToken, new char[][]{Keywords.NEW}, false, false);
>+						}
>+	
>+						findFieldsAndMethods(
>+							this.completionToken,
>+							((TypeBinding) qualifiedBinding),
>+							scope,
>+							access,
>+							scope,
>+							access.isStatic,
>+							false,
>+							access.receiver instanceof SuperReference,
>+							null,
>+							null,
>+							null,
>+							false);
>+						if (qualifiedBinding instanceof FunctionTypeBinding) {
>+							FunctionTypeBinding functionTypeBinding = (FunctionTypeBinding) qualifiedBinding;
>+							if (functionTypeBinding.functionBinding!=null && functionTypeBinding.functionBinding.isConstructor())
>+							{
>+								ReferenceBinding declaringClass = (ReferenceBinding)functionTypeBinding.functionBinding.returnType;
>+								findFieldsAndMethods(
>+										this.completionToken,
>+										declaringClass,
>+										scope,
>+										access,
>+										scope,
>+										true,
>+										false,
>+										access.receiver instanceof SuperReference,
>+										null,
>+										null,
>+										null,
>+										false);
>+								
>+							}
> 							
> 						}
>-						
> 					}
> 				}
> 			}
>@@ -7720,5 +7744,22 @@
> 		
> 		return result;
> 	}
>+	
>+	private char[] computeToken(FieldReference field) {
>+		char[] currentToken = field.token;
>+		boolean addDot = false;
>+		if(currentToken != null && currentToken.length == 0)
>+			addDot = true;
>+		if(field.receiver != null) {
>+			if(field.receiver instanceof SingleNameReference) {
>+				currentToken = CharOperation.concat(((SingleNameReference)field.receiver).token, currentToken, '.');
>+			} else if(field.receiver instanceof FieldReference) {
>+				currentToken = CharOperation.concat(computeToken((FieldReference) field.receiver), currentToken, '.');
>+			}
>+		}
>+		if(addDot)
>+			currentToken = CharOperation.append(currentToken, '.');
>+		return currentToken;
>+	}
> 
> }
>Index: src/org/eclipse/wst/jsdt/internal/codeassist/complete/CompletionOnMemberAccess.java
>===================================================================
>RCS file: /cvsroot/webtools/org.eclipse.jsdt/plugins/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/codeassist/complete/CompletionOnMemberAccess.java,v
>retrieving revision 1.6
>diff -u -r1.6 CompletionOnMemberAccess.java
>--- src/org/eclipse/wst/jsdt/internal/codeassist/complete/CompletionOnMemberAccess.java	25 Aug 2009 17:58:20 -0000	1.6
>+++ src/org/eclipse/wst/jsdt/internal/codeassist/complete/CompletionOnMemberAccess.java	17 May 2010 21:03:53 -0000
>@@ -32,6 +32,7 @@
>  * which should be replaced by the completion.
>  */
> 
>+import org.eclipse.wst.jsdt.internal.compiler.ast.ASTNode;
> import org.eclipse.wst.jsdt.internal.compiler.ast.Expression;
> import org.eclipse.wst.jsdt.internal.compiler.ast.FieldReference;
> import org.eclipse.wst.jsdt.internal.compiler.ast.MessageSend;
>@@ -100,4 +101,8 @@
> 			throw new CompletionNodeFound(this, this.receiverType, scope);
> 		// array types are passed along to find the length field
> 	}
>+	
>+	public TypeBinding resolveForAllocation(BlockScope scope, ASTNode location) {
>+		throw new CompletionNodeFound(this, scope);
>+	}
> }
>Index: src/org/eclipse/wst/jsdt/internal/core/SearchableEnvironment.java
>===================================================================
>RCS file: /cvsroot/webtools/org.eclipse.jsdt/plugins/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/core/SearchableEnvironment.java,v
>retrieving revision 1.22
>diff -u -r1.22 SearchableEnvironment.java
>--- src/org/eclipse/wst/jsdt/internal/core/SearchableEnvironment.java	23 Nov 2009 20:38:09 -0000	1.22
>+++ src/org/eclipse/wst/jsdt/internal/core/SearchableEnvironment.java	17 May 2010 21:03:53 -0000
>@@ -434,7 +434,7 @@
> 			}
> 			int lastDotIndex = CharOperation.lastIndexOf('.', prefix);
> 			char[] qualification, simpleName;
>-			if (lastDotIndex < 0) {
>+			if (lastDotIndex < 0 || true) {
> 				qualification = null;
> 				if (camelCaseMatch) {
> 					simpleName = prefix;
>Index: src/org/eclipse/wst/jsdt/internal/core/index/DiskIndex.java
>===================================================================
>RCS file: /cvsroot/webtools/org.eclipse.jsdt/plugins/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/core/index/DiskIndex.java,v
>retrieving revision 1.4
>diff -u -r1.4 DiskIndex.java
>--- src/org/eclipse/wst/jsdt/internal/core/index/DiskIndex.java	29 Oct 2007 16:50:38 -0000	1.4
>+++ src/org/eclipse/wst/jsdt/internal/core/index/DiskIndex.java	17 May 2010 21:03:53 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2007 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -52,7 +52,7 @@
> private int bufferIndex, bufferEnd; // used when reading from the file into the streamBuffer
> private int streamEnd; // used when writing data from the streamBuffer to the file
> 
>-public static final String SIGNATURE= "INDEX VERSION 1.121"; //$NON-NLS-1$
>+public static final String SIGNATURE= "INDEX VERSION 1.122"; //$NON-NLS-1$
> private static final char[] SIGNATURE_CHARS = SIGNATURE.toCharArray();
> public static boolean DEBUG = false;
> 
>Index: src/org/eclipse/wst/jsdt/internal/core/search/indexing/AbstractIndexer.java
>===================================================================
>RCS file: /cvsroot/webtools/org.eclipse.jsdt/plugins/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/core/search/indexing/AbstractIndexer.java,v
>retrieving revision 1.12
>diff -u -r1.12 AbstractIndexer.java
>--- src/org/eclipse/wst/jsdt/internal/core/search/indexing/AbstractIndexer.java	23 Nov 2009 20:38:09 -0000	1.12
>+++ src/org/eclipse/wst/jsdt/internal/core/search/indexing/AbstractIndexer.java	17 May 2010 21:03:53 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2009 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -100,6 +100,9 @@
> 				packageName == null ? CharOperation.NO_CHAR : packageName);
> 
> 		addIndexEntry(TYPE_DECL, indexKey);
>+		
>+		indexKey = TypeDeclarationPattern.createIndexKey(modifiers, CharOperation.concat(packageName, name, '.'), packageName, enclosingTypeNames, secondary);
>+		addIndexEntry(TYPE_DECL, indexKey);
> 	}
> 	public void addTypeReference(char[] typeName) {
> 		if (typeName!=null)
>Index: src/org/eclipse/wst/jsdt/internal/core/search/matching/TypeDeclarationPattern.java
>===================================================================
>RCS file: /cvsroot/webtools/org.eclipse.jsdt/plugins/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/core/search/matching/TypeDeclarationPattern.java,v
>retrieving revision 1.15
>diff -u -r1.15 TypeDeclarationPattern.java
>--- src/org/eclipse/wst/jsdt/internal/core/search/matching/TypeDeclarationPattern.java	23 Nov 2009 20:38:09 -0000	1.15
>+++ src/org/eclipse/wst/jsdt/internal/core/search/matching/TypeDeclarationPattern.java	17 May 2010 21:03:53 -0000
>@@ -142,11 +142,11 @@
> 	this(matchRule);
> 	
> 		int index;
>-		if (simpleName!=null &&  (index=CharOperation.lastIndexOf('.',simpleName)) >0)
>-		{
>-			pkg=CharOperation.subarray(simpleName, 0, index);
>-			simpleName=CharOperation.subarray(simpleName, index+1, simpleName.length);
>-		}
>+//		if (simpleName!=null &&  (index=CharOperation.lastIndexOf('.',simpleName)) >0)
>+//		{
>+//			pkg=CharOperation.subarray(simpleName, 0, index);
>+//			simpleName=CharOperation.subarray(simpleName, index+1, simpleName.length);
>+//		}
> 
> 	this.pkg = isCaseSensitive() ? pkg : CharOperation.toLowerCase(pkg);
> 	if (isCaseSensitive() || enclosingTypeNames == null) {
>#P org.eclipse.wst.jsdt.ui
>Index: src/org/eclipse/wst/jsdt/internal/ui/text/java/LazyJavaTypeCompletionProposal.java
>===================================================================
>RCS file: /cvsroot/webtools/org.eclipse.jsdt/plugins/org.eclipse.wst.jsdt.ui/src/org/eclipse/wst/jsdt/internal/ui/text/java/LazyJavaTypeCompletionProposal.java,v
>retrieving revision 1.13
>diff -u -r1.13 LazyJavaTypeCompletionProposal.java
>--- src/org/eclipse/wst/jsdt/internal/ui/text/java/LazyJavaTypeCompletionProposal.java	24 Mar 2010 19:08:24 -0000	1.13
>+++ src/org/eclipse/wst/jsdt/internal/ui/text/java/LazyJavaTypeCompletionProposal.java	17 May 2010 21:03:54 -0000
>@@ -39,7 +39,7 @@
>   */
> public class LazyJavaTypeCompletionProposal extends LazyJavaCompletionProposal {
> 	/** Triggers for types. Do not modify. */
>-	protected static final char[] TYPE_TRIGGERS= new char[] { '.', '\t', '[', '(', ' ' };
>+	protected static final char[] TYPE_TRIGGERS= new char[] { '\t', '[', '(', ' ' };
> 	/** Triggers for types in javadoc. Do not modify. */
> 	protected static final char[] JDOC_TYPE_TRIGGERS= new char[] { '#', '}', ' ', '.' };
> 
>@@ -84,10 +84,10 @@
> 		 if (fProposal.getKind() == CompletionProposal.TYPE_REF &&  fInvocationContext.getCoreContext().isInJsdocText())
> 			 return getSimpleTypeName();
> 		
>-		String qualifiedTypeName= getQualifiedTypeName();
>- 		if (qualifiedTypeName.indexOf('.') == -1)
>- 			// default package - no imports needed 
>- 			return qualifiedTypeName;
>+		String qualifiedTypeName= replacement;
>+// 		if (qualifiedTypeName.indexOf('.') == -1)
>+// 			// default package - no imports needed 
>+// 			return qualifiedTypeName;
> 
>  		/*
> 		 * If the user types in the qualification, don't force import rewriting on him - insert the
>@@ -339,7 +339,7 @@
> 	 */
> 	protected String computeSortString() {
> 		// try fast sort string to avoid display string creation
>-		return getSimpleTypeName() + Character.MIN_VALUE + getQualifiedTypeName();
>+		return getQualifiedTypeName();
> 	}
> 	
> 	/*

Actions: View | Diff

Attachments on bug 305694: 161887 | 161888 | 168827 | 168831 | 169730 | 169843