Attachment 168135 Details for Bug 311564 – Bulletproof handleSuccess() from DsfMemoryBlockRetrieval.resolveMemoryAddress()

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Bulletproof handleSuccess() from DsfMemoryBlockRetrieval.resolveMemoryAddress()

memoryRetrievalDeadLock.txt (text/plain), 1.37 KB, created by Teodor Madan

on 2010-05-12 09:20:43 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Teodor Madan

Created: 2010-05-12 09:20:43 EDT

Size: 1.37 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.cdt.dsf
>Index: src/org/eclipse/cdt/dsf/debug/model/DsfMemoryBlockRetrieval.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/model/DsfMemoryBlockRetrieval.java,v
>retrieving revision 1.2
>diff -u -r1.2 DsfMemoryBlockRetrieval.java
>--- src/org/eclipse/cdt/dsf/debug/model/DsfMemoryBlockRetrieval.java	27 Feb 2009 23:27:44 -0000	1.2
>+++ src/org/eclipse/cdt/dsf/debug/model/DsfMemoryBlockRetrieval.java	12 May 2010 08:44:29 -0000
>@@ -474,6 +474,18 @@
> 	                	valueDmc, 
> 	                    new DataRequestMonitor<FormattedValueDMData>(getExecutor(), drm) {
> 	            			@Override
>+							protected void handleCompleted() {
>+	            				try {
>+	            					super.handleCompleted();
>+	            				} catch (RuntimeException ex) {
>+	            					setStatus(new Status(IStatus.ERROR,
>+	            							DsfPlugin.PLUGIN_ID, DebugException.INTERNAL_ERROR,
>+	            							"Error evaluating memory address (ExecutionException).", ex)); //$NON-NLS-1$
>+	            					handleError();
>+	            				}
>+							}
>+
>+							@Override
> 	            			protected void handleSuccess() {
> 	            				// Store the result
> 	            				FormattedValueDMData data = getData();

Flags:

cdtdoug: iplog-

Actions: View | Diff

Attachments on bug 311564: 168135