Attachment 168003 Details for Bug 311940 – patch that sets dialog font before doing button layout calculations

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch that sets dialog font before doing button layout calculations

patch311940.txt (text/plain), 1.98 KB, created by Susan McCourt

on 2010-05-11 15:02:42 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Susan McCourt

Created: 2010-05-11 15:02:42 EDT

Size: 1.98 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/activities/ActivityCategoryPreferencePage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/activities/ActivityCategoryPreferencePage.java,v
>retrieving revision 1.26
>diff -u -r1.26 ActivityCategoryPreferencePage.java
>--- Eclipse UI/org/eclipse/ui/activities/ActivityCategoryPreferencePage.java	25 May 2009 20:52:16 -0000	1.26
>+++ Eclipse UI/org/eclipse/ui/activities/ActivityCategoryPreferencePage.java	11 May 2010 19:01:38 -0000
>@@ -16,7 +16,6 @@
> import java.util.Iterator;
> import java.util.Properties;
> import java.util.Set;
>-
> import org.eclipse.core.runtime.IConfigurationElement;
> import org.eclipse.core.runtime.IExecutableExtension;
> import org.eclipse.jface.dialogs.Dialog;
>@@ -435,7 +434,7 @@
>             }
>         });
>         enableAll.setText(ActivityMessages.ActivityEnabler_selectAll); 
>-        setButtonLayoutData(enableAll);
>+		setFontAndButtonLayoutData(enableAll);
> 
>         Button disableAll = new Button(composite, SWT.PUSH);
>         disableAll.addSelectionListener(new SelectionAdapter() {
>@@ -449,7 +448,7 @@
>             }
>         });
>         disableAll.setText(ActivityMessages.ActivityEnabler_deselectAll); 
>-        setButtonLayoutData(disableAll);
>+		setFontAndButtonLayoutData(disableAll);
>         
>         if (allowAdvanced) {
>         		Label spacer = new Label(composite, SWT.NONE);
>@@ -469,10 +468,15 @@
>                 }
>             });
>             advancedButton.setText(ActivityMessages.ActivitiesPreferencePage_advancedButton);
>-            setButtonLayoutData(advancedButton);
>+			setFontAndButtonLayoutData(advancedButton);
>         }
>     }
> 
>+	private void setFontAndButtonLayoutData(Button button) {
>+		button.setFont(JFaceResources.getDialogFont());
>+		setButtonLayoutData(button);
>+	}
>+
>     /**
>      * @param parent
>      */

Actions: View | Diff

Attachments on bug 311940: 167350 | 168003 | 168004 | 168140 | 168311 | 168373 | 168544