Attachment 16729 Details for Bug 81289 – patch to jface for better margins etc...

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

patch to jface for better margins etc...

o.e.jface.txt (text/plain), 7.53 KB, created by Michael Van Meekeren

on 2004-12-17 10:08:17 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Van Meekeren

Created: 2004-12-17 10:08:17 EST

Size: 7.53 KB

patch

obsolete

>Index: src/org/eclipse/jface/dialogs/TitleAreaDialog.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/dialogs/TitleAreaDialog.java,v
>retrieving revision 1.19
>diff -u -r1.19 TitleAreaDialog.java
>--- src/org/eclipse/jface/dialogs/TitleAreaDialog.java	16 Nov 2004 20:24:03 -0000	1.19
>+++ src/org/eclipse/jface/dialogs/TitleAreaDialog.java	17 Dec 2004 15:05:09 -0000
>@@ -224,7 +224,7 @@
>         titleImage.setBackground(background);
>         titleImage.setImage(JFaceResources.getImage(DLG_IMG_TITLE_BANNER));
>         FormData imageData = new FormData();
>-        imageData.top = new FormAttachment(0, verticalSpacing);
>+        imageData.top = new FormAttachment(0, 0);
>         // Note: do not use horizontalSpacing on the right as that would be a
>         // regression from
>         // the R2.x style where there was no margin on the right and images are
>Index: src/org/eclipse/jface/preference/PreferenceDialog.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceDialog.java,v
>retrieving revision 1.58
>diff -u -r1.58 PreferenceDialog.java
>--- src/org/eclipse/jface/preference/PreferenceDialog.java	15 Dec 2004 18:32:23 -0000	1.58
>+++ src/org/eclipse/jface/preference/PreferenceDialog.java	17 Dec 2004 15:05:09 -0000
>@@ -353,7 +353,7 @@
> 		pageAreaComposite.setLayoutData(new GridData(GridData.FILL_BOTH));
> 		GridLayout layout = new GridLayout(1, true);
> 		layout.marginHeight = 0;
>-		layout.marginWidth = 10;
>+		layout.marginWidth = IDialogConstants.HORIZONTAL_MARGIN;
> 		pageAreaComposite.setLayout(layout);
> 		// Build the title area and separator line
> 		Composite titleComposite = new Composite(pageAreaComposite, SWT.NONE);
>@@ -466,7 +466,7 @@
> 	 * the pages.
> 	 * @return PageLayout
> 	 */
>-	protected PageLayout getPageLayout() {
>+	protected Layout getPageLayout() {
> 		return new PageLayout();
> 	}
> 
>Index: src/org/eclipse/jface/resource/jfacefonts.properties
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/resource/jfacefonts.properties,v
>retrieving revision 1.5
>diff -u -r1.5 jfacefonts.properties
>--- src/org/eclipse/jface/resource/jfacefonts.properties	10 Mar 2003 21:56:31 -0000	1.5
>+++ src/org/eclipse/jface/resource/jfacefonts.properties	17 Dec 2004 15:05:09 -0000
>@@ -12,8 +12,8 @@
> # *.0 is Windows font
> # *.1 is Unix font
> #############################################################
>-org.eclipse.jface.bannerfont.0=MS Sans Serif-bold-8
>-org.eclipse.jface.bannerfont.1=b&h-lucidabright-regular-8
>+org.eclipse.jface.bannerfont.0=MS Sans Serif-bold-10
>+org.eclipse.jface.bannerfont.1=b&h-lucidabright-regular-10
> 
> org.eclipse.jface.headerfont.0=MS Sans Serif-bold-12
> org.eclipse.jface.headerfont.1=b&h-lucidabright-regular-12
>Index: src/org/eclipse/jface/resource/jfacefonts_hp-ux.properties
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/resource/jfacefonts_hp-ux.properties,v
>retrieving revision 1.4
>diff -u -r1.4 jfacefonts_hp-ux.properties
>--- src/org/eclipse/jface/resource/jfacefonts_hp-ux.properties	10 Mar 2003 21:56:31 -0000	1.4
>+++ src/org/eclipse/jface/resource/jfacefonts_hp-ux.properties	17 Dec 2004 15:05:09 -0000
>@@ -10,7 +10,6 @@
> ###############################################################################
> # HP UX font file for JFace
> #############################################################
>-
> org.eclipse.jface.bannerfont.0=adobe-courier-bold-14
> org.eclipse.jface.headerfont.0=adobe-courier-regular-14
> org.eclipse.jface.textfont.0=adobe-courier-regular-14
>Index: src/org/eclipse/jface/resource/jfacefonts_windows2000.properties
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/resource/jfacefonts_windows2000.properties,v
>retrieving revision 1.5
>diff -u -r1.5 jfacefonts_windows2000.properties
>--- src/org/eclipse/jface/resource/jfacefonts_windows2000.properties	10 Mar 2003 21:56:31 -0000	1.5
>+++ src/org/eclipse/jface/resource/jfacefonts_windows2000.properties	17 Dec 2004 15:05:09 -0000
>@@ -8,10 +8,9 @@
> # Contributors:
> #     IBM Corporation - initial API and implementation
> ###############################################################################
>-# NLS font file for JFace when running under Windows NT
>+# NLS font file for JFace when running under Windows 2000
> #############################################################
>-
>-org.eclipse.jface.bannerfont.0=Tahoma-bold-8
>+org.eclipse.jface.bannerfont.0=Tahoma-bold-10
> 
> org.eclipse.jface.headerfont.0=Tahoma-bold-12
> 
>Index: src/org/eclipse/jface/resource/jfacefonts_windows98.properties
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/resource/jfacefonts_windows98.properties,v
>retrieving revision 1.5
>diff -u -r1.5 jfacefonts_windows98.properties
>--- src/org/eclipse/jface/resource/jfacefonts_windows98.properties	10 Mar 2003 21:56:31 -0000	1.5
>+++ src/org/eclipse/jface/resource/jfacefonts_windows98.properties	17 Dec 2004 15:05:09 -0000
>@@ -10,8 +10,7 @@
> ###############################################################################
> # NLS font file for JFace when running under Windows 98
> #############################################################
>-
>-org.eclipse.jface.bannerfont.0=MS Sans Serif-bold-8
>+org.eclipse.jface.bannerfont.0=MS Sans Serif-bold-10
> 
> org.eclipse.jface.headerfont.0=MS Sans Serif-bold-12
> 
>Index: src/org/eclipse/jface/resource/jfacefonts_windowsnt.properties
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/resource/jfacefonts_windowsnt.properties,v
>retrieving revision 1.5
>diff -u -r1.5 jfacefonts_windowsnt.properties
>--- src/org/eclipse/jface/resource/jfacefonts_windowsnt.properties	10 Mar 2003 21:56:31 -0000	1.5
>+++ src/org/eclipse/jface/resource/jfacefonts_windowsnt.properties	17 Dec 2004 15:05:10 -0000
>@@ -10,7 +10,7 @@
> ###############################################################################
> # NLS font file for JFace when running under Windows NT
> #############################################################
>-org.eclipse.jface.bannerfont.0=MS Sans Serif-bold-8
>+org.eclipse.jface.bannerfont.0=MS Sans Serif-bold-10
> 
> org.eclipse.jface.headerfont.0=MS Sans Serif-bold-12
> 
>Index: src/org/eclipse/jface/resource/jfacefonts_windowsxp.properties
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/resource/jfacefonts_windowsxp.properties,v
>retrieving revision 1.5
>diff -u -r1.5 jfacefonts_windowsxp.properties
>--- src/org/eclipse/jface/resource/jfacefonts_windowsxp.properties	10 Mar 2003 21:56:31 -0000	1.5
>+++ src/org/eclipse/jface/resource/jfacefonts_windowsxp.properties	17 Dec 2004 15:05:10 -0000
>@@ -8,9 +8,9 @@
> # Contributors:
> #     IBM Corporation - initial API and implementation
> ###############################################################################
>-# NLS font file for JFace when running under Windows NT
>+# NLS font file for JFace when running under Windows XP
> #############################################################
>-org.eclipse.jface.bannerfont.0=Tahoma-bold-8
>+org.eclipse.jface.bannerfont.0=Tahoma-bold-10
> 
> org.eclipse.jface.headerfont.0=Tahoma-bold-12
>

Actions: View

Attachments on bug 81289: 16661 | 16723 | 16727 | 16729