Attachment 165940 Details for Bug 310277 – Additional fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Additional fix

patch310277.txt (text/plain), 2.01 KB, created by Serge Beauchamp

on 2010-04-23 13:37:39 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Serge Beauchamp

Created: 2010-04-23 13:37:39 EDT

Size: 2.01 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.ide
>Index: src/org/eclipse/ui/views/navigator/NavigatorDropAdapter.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.ide/src/org/eclipse/ui/views/navigator/NavigatorDropAdapter.java,v
>retrieving revision 1.20
>diff -u -r1.20 NavigatorDropAdapter.java
>--- src/org/eclipse/ui/views/navigator/NavigatorDropAdapter.java	23 Apr 2010 13:24:48 -0000	1.20
>+++ src/org/eclipse/ui/views/navigator/NavigatorDropAdapter.java	23 Apr 2010 17:36:21 -0000
>@@ -254,7 +254,7 @@
>             result = NavigatorDropAdapter.super.performDrop(data);
>         }
>         if (resources != null && resources.length > 0) {
>-            if ((getCurrentOperation() == DND.DROP_COPY) || (getCurrentOperation() == DND.DROP_LINK)) {
>+            if (getCurrentOperation() == DND.DROP_COPY) {
> 				status = performResourceCopy(getShell(), resources);
> 			} else {
> 				status = performResourceMove(resources);
>@@ -432,9 +432,7 @@
>             lastValidOperation = dragOperation;
>         }
>         if (FileTransfer.getInstance().isSupportedType(transferType)
>-                && (lastValidOperation != DND.DROP_COPY)
>-                && (lastValidOperation != DND.DROP_MOVE)
>-                && (lastValidOperation != DND.DROP_LINK)) {
>+                && (lastValidOperation != DND.DROP_COPY)) {
>             return false;
>         }
>         if (super.validateDrop(target, dragOperation, transferType)) {
>@@ -467,7 +465,7 @@
> 				message = ResourceNavigatorMessages.DropAdapter_dropOperationErrorOther;
> 			} else {
>                 CopyFilesAndFoldersOperation operation;
>-                if ((lastValidOperation == DND.DROP_COPY) || (lastValidOperation == DND.DROP_LINK)) {
>+                if (lastValidOperation == DND.DROP_COPY) {
>                     operation = new CopyFilesAndFoldersOperation(getShell());
> 					if (operation.validateDestination(destination, selectedResources) != null) {
> 						operation.setVirtualFolders(true);

Flags:

daniel_megert: review+

Actions: View | Diff

Attachments on bug 310277: 165909 | 165940