Attachment 165918 Details for Bug 280631 – Adds the new checkbox to dsf jtag launch config tab

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Adds the new checkbox to dsf jtag launch config tab

patch_280631_jtag (text/plain), 3.83 KB, created by John Cortell

on 2010-04-23 10:17:38 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: John Cortell

Created: 2010-04-23 10:17:38 EDT

Size: 3.83 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.cdt.debug.gdbjtag.ui
>Index: src/org/eclipse/cdt/debug/gdbjtag/ui/GDBJtagDSFDebuggerTab.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/jtag/org.eclipse.cdt.debug.gdbjtag.ui/src/org/eclipse/cdt/debug/gdbjtag/ui/GDBJtagDSFDebuggerTab.java,v
>retrieving revision 1.2
>diff -u -r1.2 GDBJtagDSFDebuggerTab.java
>--- src/org/eclipse/cdt/debug/gdbjtag/ui/GDBJtagDSFDebuggerTab.java	22 Apr 2010 17:51:57 -0000	1.2
>+++ src/org/eclipse/cdt/debug/gdbjtag/ui/GDBJtagDSFDebuggerTab.java	23 Apr 2010 14:16:40 -0000
>@@ -45,6 +45,7 @@
> import org.eclipse.swt.widgets.Group;
> import org.eclipse.swt.widgets.Label;
> import org.eclipse.swt.widgets.Text;
>+import org.eclipse.ui.PlatformUI;
> 
> /**
>  * @since 6.0
>@@ -60,6 +61,7 @@
> 	private Text portNumber;
> 	private Combo jtagDevice;
> 	private String savedJtagDevice;
>+	protected Button fUpdateThreadlistOnSuspend;
> 
> 	public String getName() {
> 		return TAB_NAME;
>@@ -89,6 +91,17 @@
> 
> 		createCommandControl(group);
> 		createRemoteControl(comp);
>+		
>+		fUpdateThreadlistOnSuspend = new Button(comp, SWT.CHECK);
>+		fUpdateThreadlistOnSuspend.setText(Messages.getString("GDBJtagDebuggerTab.update_thread_list_on_suspend"));
>+		fUpdateThreadlistOnSuspend .addSelectionListener(new SelectionAdapter() {
>+			@Override
>+			public void widgetSelected(SelectionEvent e) {
>+				updateLaunchConfigurationDialog();
>+			}
>+		});
>+		// This checkbox needs an explanation. Attach context help to it.
>+		PlatformUI.getWorkbench().getHelpSystem().setHelp(fUpdateThreadlistOnSuspend, "org.eclipse.cdt.dsf.gdb.ui.update_threadlist_button_context"); //$NON-NLS-1$
> 	}
> 
> 	private void browseButtonSelected(String title, Text text) {
>@@ -276,6 +289,9 @@
> 					jtagDevice.select(i);
> 				}
> 			}
>+			boolean updateThreadsOnSuspend = configuration.getAttribute(IGDBLaunchConfigurationConstants.ATTR_DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND,
>+					IGDBLaunchConfigurationConstants.DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND_DEFAULT);
>+			fUpdateThreadlistOnSuspend.setSelection(updateThreadsOnSuspend);			
> 		} catch (CoreException e) {
> 			Activator.getDefault().getLog().log(e.getStatus());
> 		}
>@@ -303,6 +319,8 @@
> 		} catch (NumberFormatException e) {
> 			configuration.setAttribute(IGDBJtagConstants.ATTR_PORT_NUMBER, 0);
> 		}
>+		configuration.setAttribute(IGDBLaunchConfigurationConstants.ATTR_DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND,
>+                fUpdateThreadlistOnSuspend.getSelection());
> 	}
> 
> 	public void setDefaults(ILaunchConfigurationWorkingCopy configuration) {
>@@ -318,6 +336,8 @@
> 				IGDBJtagConstants.DEFAULT_USE_REMOTE_TARGET);
> 		configuration.setAttribute(IGDBJtagConstants.ATTR_IP_ADDRESS, IGDBJtagConstants.DEFAULT_IP_ADDRESS);
> 		configuration.setAttribute(IGDBJtagConstants.ATTR_PORT_NUMBER, IGDBJtagConstants.DEFAULT_PORT_NUMBER);
>+		configuration.setAttribute(IGDBLaunchConfigurationConstants.ATTR_DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND,
>+				   IGDBLaunchConfigurationConstants.DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND_DEFAULT);
> 	}
> 
> }
>Index: src/org/eclipse/cdt/debug/gdbjtag/ui/JtagUi.properties
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/jtag/org.eclipse.cdt.debug.gdbjtag.ui/src/org/eclipse/cdt/debug/gdbjtag/ui/JtagUi.properties,v
>retrieving revision 1.3
>diff -u -r1.3 JtagUi.properties
>--- src/org/eclipse/cdt/debug/gdbjtag/ui/JtagUi.properties	26 May 2009 23:11:59 -0000	1.3
>+++ src/org/eclipse/cdt/debug/gdbjtag/ui/JtagUi.properties	23 Apr 2010 14:16:40 -0000
>@@ -58,3 +58,4 @@
> GDBJtagDebuggerTab.jtagDeviceLabel=JTAG Device:
> GDBJtagDebuggerTab.ipAddressLabel=Host name or IP address:
> GDBJtagDebuggerTab.portNumberLabel=Port number:
>+GDBJtagDebuggerTab.update_thread_list_on_suspend=Force thread list update on suspend

Flags:

john.cortell: iplog-

Actions: View | Diff

Attachments on bug 280631: 158286 | 165669 | 165681 | 165683 | 165785 | 165918