Attachment #165918 for bug #280631

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.




import org.eclipse.swt.widgets.Group;
import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Text;
import org.eclipse.ui.PlatformUI;

/**
 * @since 6.0

	private Text portNumber;
	private Combo jtagDevice;
	private String savedJtagDevice;
	protected Button fUpdateThreadlistOnSuspend;

	public String getName() {
		return TAB_NAME;


		createCommandControl(group);
		createRemoteControl(comp);
		
		fUpdateThreadlistOnSuspend = new Button(comp, SWT.CHECK);
		fUpdateThreadlistOnSuspend.setText(Messages.getString("GDBJtagDebuggerTab.update_thread_list_on_suspend"));
		fUpdateThreadlistOnSuspend .addSelectionListener(new SelectionAdapter() {
			@Override
			public void widgetSelected(SelectionEvent e) {
				updateLaunchConfigurationDialog();
			}
		});
		// This checkbox needs an explanation. Attach context help to it.
		PlatformUI.getWorkbench().getHelpSystem().setHelp(fUpdateThreadlistOnSuspend, "org.eclipse.cdt.dsf.gdb.ui.update_threadlist_button_context"); //$NON-NLS-1$
	}

	private void browseButtonSelected(String title, Text text) {

					jtagDevice.select(i);
				}
			}
			boolean updateThreadsOnSuspend = configuration.getAttribute(IGDBLaunchConfigurationConstants.ATTR_DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND,
					IGDBLaunchConfigurationConstants.DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND_DEFAULT);
			fUpdateThreadlistOnSuspend.setSelection(updateThreadsOnSuspend);			
		} catch (CoreException e) {
			Activator.getDefault().getLog().log(e.getStatus());
		}

		} catch (NumberFormatException e) {
			configuration.setAttribute(IGDBJtagConstants.ATTR_PORT_NUMBER, 0);
		}
		configuration.setAttribute(IGDBLaunchConfigurationConstants.ATTR_DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND,
                fUpdateThreadlistOnSuspend.getSelection());
	}

	public void setDefaults(ILaunchConfigurationWorkingCopy configuration) {

				IGDBJtagConstants.DEFAULT_USE_REMOTE_TARGET);
		configuration.setAttribute(IGDBJtagConstants.ATTR_IP_ADDRESS, IGDBJtagConstants.DEFAULT_IP_ADDRESS);
		configuration.setAttribute(IGDBJtagConstants.ATTR_PORT_NUMBER, IGDBJtagConstants.DEFAULT_PORT_NUMBER);
		configuration.setAttribute(IGDBLaunchConfigurationConstants.ATTR_DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND,
				   IGDBLaunchConfigurationConstants.DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND_DEFAULT);
	}

}

Lines 58-60 Link Here

(-)src/org/eclipse/cdt/debug/gdbjtag/ui/JtagUi.properties (+1 lines)
58	GDBJtagDebuggerTab.jtagDeviceLabel=JTAG Device:	58	GDBJtagDebuggerTab.jtagDeviceLabel=JTAG Device:
59	GDBJtagDebuggerTab.ipAddressLabel=Host name or IP address:	59	GDBJtagDebuggerTab.ipAddressLabel=Host name or IP address:
60	GDBJtagDebuggerTab.portNumberLabel=Port number:	60	GDBJtagDebuggerTab.portNumberLabel=Port number:
		61	GDBJtagDebuggerTab.update_thread_list_on_suspend=Force thread list update on suspend

Return to bug 280631

Lines 45-50 Link Here

(-)src/org/eclipse/cdt/debug/gdbjtag/ui/GDBJtagDSFDebuggerTab.java (+20 lines)
45	import org.eclipse.swt.widgets.Group;	45	import org.eclipse.swt.widgets.Group;
46	import org.eclipse.swt.widgets.Label;	46	import org.eclipse.swt.widgets.Label;
47	import org.eclipse.swt.widgets.Text;	47	import org.eclipse.swt.widgets.Text;
		48	import org.eclipse.ui.PlatformUI;
48		49
49	/**	50	/**
50	* @since 6.0	51	* @since 6.0
Lines 60-65 Link Here
60	private Text portNumber;	61	private Text portNumber;
61	private Combo jtagDevice;	62	private Combo jtagDevice;
62	private String savedJtagDevice;	63	private String savedJtagDevice;
		64	protected Button fUpdateThreadlistOnSuspend;
63		65
64	public String getName() {	66	public String getName() {
65	return TAB_NAME;	67	return TAB_NAME;
Lines 89-94 Link Here
89		91
90	createCommandControl(group);	92	createCommandControl(group);
91	createRemoteControl(comp);	93	createRemoteControl(comp);
		94
		95	fUpdateThreadlistOnSuspend = new Button(comp, SWT.CHECK);
		96	fUpdateThreadlistOnSuspend.setText(Messages.getString("GDBJtagDebuggerTab.update_thread_list_on_suspend"));
		97	fUpdateThreadlistOnSuspend .addSelectionListener(new SelectionAdapter() {
		98	@Override
		99	public void widgetSelected(SelectionEvent e) {
		100	updateLaunchConfigurationDialog();
		101	}
		102	});
		103	// This checkbox needs an explanation. Attach context help to it.
		104	PlatformUI.getWorkbench().getHelpSystem().setHelp(fUpdateThreadlistOnSuspend, "org.eclipse.cdt.dsf.gdb.ui.update_threadlist_button_context"); //$NON-NLS-1$
92	}	105	}
93		106
94	private void browseButtonSelected(String title, Text text) {	107	private void browseButtonSelected(String title, Text text) {
Lines 276-281 Link Here
276	jtagDevice.select(i);	289	jtagDevice.select(i);
277	}	290	}
278	}	291	}
		292	boolean updateThreadsOnSuspend = configuration.getAttribute(IGDBLaunchConfigurationConstants.ATTR_DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND,
		293	IGDBLaunchConfigurationConstants.DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND_DEFAULT);
		294	fUpdateThreadlistOnSuspend.setSelection(updateThreadsOnSuspend);
279	} catch (CoreException e) {	295	} catch (CoreException e) {
280	Activator.getDefault().getLog().log(e.getStatus());	296	Activator.getDefault().getLog().log(e.getStatus());
281	}	297	}
Lines 303-308 Link Here
303	} catch (NumberFormatException e) {	319	} catch (NumberFormatException e) {
304	configuration.setAttribute(IGDBJtagConstants.ATTR_PORT_NUMBER, 0);	320	configuration.setAttribute(IGDBJtagConstants.ATTR_PORT_NUMBER, 0);
305	}	321	}
		322	configuration.setAttribute(IGDBLaunchConfigurationConstants.ATTR_DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND,
		323	fUpdateThreadlistOnSuspend.getSelection());
306	}	324	}
307		325
308	public void setDefaults(ILaunchConfigurationWorkingCopy configuration) {	326	public void setDefaults(ILaunchConfigurationWorkingCopy configuration) {
Lines 318-323 Link Here
318	IGDBJtagConstants.DEFAULT_USE_REMOTE_TARGET);	336	IGDBJtagConstants.DEFAULT_USE_REMOTE_TARGET);
319	configuration.setAttribute(IGDBJtagConstants.ATTR_IP_ADDRESS, IGDBJtagConstants.DEFAULT_IP_ADDRESS);	337	configuration.setAttribute(IGDBJtagConstants.ATTR_IP_ADDRESS, IGDBJtagConstants.DEFAULT_IP_ADDRESS);
320	configuration.setAttribute(IGDBJtagConstants.ATTR_PORT_NUMBER, IGDBJtagConstants.DEFAULT_PORT_NUMBER);	338	configuration.setAttribute(IGDBJtagConstants.ATTR_PORT_NUMBER, IGDBJtagConstants.DEFAULT_PORT_NUMBER);
		339	configuration.setAttribute(IGDBLaunchConfigurationConstants.ATTR_DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND,
		340	IGDBLaunchConfigurationConstants.DEBUGGER_UPDATE_THREADLIST_ON_SUSPEND_DEFAULT);
321	}	341	}
322		342
323	}	343	}