Attachment #165391 for bug #114563

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Lines 59-64 Link Here

(-)Ant Tools Support/org/eclipse/ant/internal/ui/launchConfigurations/AntBuilderTargetsTab.java (+52 lines)
59		59
60	private static final String NOT_ENABLED= AntLaunchConfigurationMessages.AntBuilderTargetsTab_0;	60	private static final String NOT_ENABLED= AntLaunchConfigurationMessages.AntBuilderTargetsTab_0;
61	private static final String DEFAULT_TARGET_SELECTED= AntLaunchConfigurationMessages.AntBuilderTargetsTab_10;	61	private static final String DEFAULT_TARGET_SELECTED= AntLaunchConfigurationMessages.AntBuilderTargetsTab_10;
		62	private static final String NO_BUILD_KIND_ERROR= AntLaunchConfigurationMessages.AntBuilderTargetsTab_buildKindError_1;
		63	private static final String BUILD_KIND_ERROR= AntLaunchConfigurationMessages.AntBuilderTargetsTab_buildKindError_2;
62		64
63	private SelectionListener fSelectionListener= new SelectionAdapter() {	65	private SelectionListener fSelectionListener= new SelectionAdapter() {
64	/* (non-Javadoc)	66	/* (non-Javadoc)
Lines 333-336 Link Here
333	public Image getImage() {	335	public Image getImage() {
334	return AntUIImages.getImage(IAntUIConstants.IMG_TAB_ANT_TARGETS);	336	return AntUIImages.getImage(IAntUIConstants.IMG_TAB_ANT_TARGETS);
335	}	337	}
		338
		339	/*
		340	* (non-Javadoc)
		341	*
		342	* @see
		343	* org.eclipse.debug.ui.ILaunchConfigurationTab#isValid(org.eclipse.debug
		344	* .core.ILaunchConfiguration)
		345	*/
		346	public boolean isValid(ILaunchConfiguration launchConfig) {
		347	setErrorMessage(null);
		348	setMessage(null);
		349
		350	// configuration is invalid if we set targets for incremental build kind
		351	// without setting any target for full build
		352	if ((!fManualBuildTargetText.getText().equals(NOT_ENABLED))
		353	\|\| (!fAutoBuildTargetText.getText().equals(NOT_ENABLED))) {
		354	if (fAfterCleanTargetText.getText().equals(NOT_ENABLED)) {
		355	setErrorMessage(BUILD_KIND_ERROR);
		356	return false;
		357	}
		358	}
		359
		360	// configuration is invalid if we do not set any target for any build
		361	// kind
		362	if (fAfterCleanTargetText.getText().equals(NOT_ENABLED)
		363	&& fManualBuildTargetText.getText().equals(NOT_ENABLED)
		364	&& fAutoBuildTargetText.getText().equals(NOT_ENABLED)
		365	&& fDuringCleanTargetText.getText().equals(NOT_ENABLED)) {
		366	setErrorMessage(NO_BUILD_KIND_ERROR);
		367	return false;
		368	}
		369
		370	return true;
		371	}
		372
		373	/*
		374	* (non-Javadoc)
		375	*
		376	* @see org.eclipse.debug.ui.ILaunchConfigurationTab#canSave()
		377	*/
		378	public boolean canSave() {
		379	return isValid(null);
		380	}
		381
		382	/* (non-Javadoc)
		383	* @see org.eclipse.debug.ui.ILaunchConfigurationTab#activated(org.eclipse.debug.core.ILaunchConfigurationWorkingCopy)
		384	*/
		385	public void activated(ILaunchConfigurationWorkingCopy workingCopy) {
		386	// do nothing on activation
		387	}
336	}	388	}

Lines 48-53 Link Here

(-)Ant Tools Support/org/eclipse/ant/internal/ui/launchConfigurations/AntLaunchConfigurationMessages.java (+2 lines)
48	public static String AntBuilderTargetsTab_7;	48	public static String AntBuilderTargetsTab_7;
49	public static String AntBuilderTargetsTab_8;	49	public static String AntBuilderTargetsTab_8;
50	public static String AntBuilderTargetsTab_10;	50	public static String AntBuilderTargetsTab_10;
		51	public static String AntBuilderTargetsTab_buildKindError_1;
		52	public static String AntBuilderTargetsTab_buildKindError_2;
51		53
52	public static String AntMainTab__Select_a_build_file__1;	54	public static String AntMainTab__Select_a_build_file__1;
53	public static String AntMainTab_3;	55	public static String AntMainTab_3;

Lines 43-48 Link Here

(-)Ant Tools Support/org/eclipse/ant/internal/ui/launchConfigurations/AntLaunchConfigurationMessages.properties (+2 lines)
43	AntBuilderTargetsTab_7=During a "Clean":	43	AntBuilderTargetsTab_7=During a "Clean":
44	AntBuilderTargetsTab_8=Set Tar&gets...	44	AntBuilderTargetsTab_8=Set Tar&gets...
45	AntBuilderTargetsTab_10=<default target selected>	45	AntBuilderTargetsTab_10=<default target selected>
		46	AntBuilderTargetsTab_buildKindError_1=At least one target for one build kind must be selected
		47	AntBuilderTargetsTab_buildKindError_2=At least one target for After a "Clean" must be selected if you want to select targets for Manual Build or Auto Build
46		48
47	AntMainTab__Select_a_build_file__1=&Select a buildfile:	49	AntMainTab__Select_a_build_file__1=&Select a buildfile:
48	AntMainTab_3=Base Direct&ory:	50	AntMainTab_3=Base Direct&ory:

Lines 470-475 Link Here

(-)External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsBuilderTab.java (+8 lines)
470	setErrorMessage(ExternalToolsLaunchConfigurationMessages.ExternalToolsBuilderTab_buildKindError);	470	setErrorMessage(ExternalToolsLaunchConfigurationMessages.ExternalToolsBuilderTab_buildKindError);
471	return false;	471	return false;
472	}	472	}
		473	// configuration is invalid if we set incremental builds without
		474	// setting full build
		475	if (manualBuild.getSelection() \|\| autoBuildButton.getSelection()) {
		476	if (!afterClean.getSelection()) {
		477	setErrorMessage(ExternalToolsLaunchConfigurationMessages.ExternalToolsBuilderTab_buildKindError_2);
		478	return false;
		479	}
		480	}
473	}	481	}
474	if (workingSetButton.getSelection() && (workingSet == null \|\| workingSet.getElements().length == 0)) {	482	if (workingSetButton.getSelection() && (workingSet == null \|\| workingSet.getElements().length == 0)) {
475	setErrorMessage(ExternalToolsLaunchConfigurationMessages.ExternalToolsBuilderTab_16);	483	setErrorMessage(ExternalToolsLaunchConfigurationMessages.ExternalToolsBuilderTab_16);

Lines 65-70 Link Here

(-)External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsLaunchConfigurationMessages.java (+1 lines)
65	public static String ExternalToolsBuilderTab_workingSet_label;	65	public static String ExternalToolsBuilderTab_workingSet_label;
66	public static String ExternalToolsBuilderTab_workingSet_tooltip;	66	public static String ExternalToolsBuilderTab_workingSet_tooltip;
67	public static String ExternalToolsBuilderTab_buildKindError;	67	public static String ExternalToolsBuilderTab_buildKindError;
		68	public static String ExternalToolsBuilderTab_buildKindError_2;
68	public static String ExternalToolsBuilderTab_14;	69	public static String ExternalToolsBuilderTab_14;
69	public static String ExternalToolsBuilderTab_13;	70	public static String ExternalToolsBuilderTab_13;
70	public static String ExternalToolsBuilderTab_16;	71	public static String ExternalToolsBuilderTab_16;

Lines 60-65 Link Here

(-)External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsLaunchConfigurationMessages.properties (+1 lines)
60	ExternalToolsBuilderTab_workingSet_label=Specify working set of &relevant resources	60	ExternalToolsBuilderTab_workingSet_label=Specify working set of &relevant resources
61	ExternalToolsBuilderTab_workingSet_tooltip=The working set of resources that if changed from a manual or auto build will trigger the external tool builder	61	ExternalToolsBuilderTab_workingSet_tooltip=The working set of resources that if changed from a manual or auto build will trigger the external tool builder
62	ExternalToolsBuilderTab_buildKindError=At least one type of build kind must be selected	62	ExternalToolsBuilderTab_buildKindError=At least one type of build kind must be selected
		63	ExternalToolsBuilderTab_buildKindError_2=Manual builds and Auto builds require setting the builder for After a "Clean"
63	ExternalToolsBuilderTab_14=Launch in bac&kground	64	ExternalToolsBuilderTab_14=Launch in bac&kground
64	ExternalToolsBuilderTab_13=&Specify Resources...	65	ExternalToolsBuilderTab_13=&Specify Resources...
65	ExternalToolsBuilderTab_16=Must select resources in working set.	66	ExternalToolsBuilderTab_16=Must select resources in working set.

Return to bug 114563