Attachment 164464 Details for Bug 305568 – commited patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] commited patch

305568.txt (text/plain), 8.07 KB, created by Frank Becker

on 2010-04-10 06:36:12 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frank Becker

Created: 2010-04-10 06:36:12 EDT

Size: 8.07 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.bugzilla.ui
>Index: src/org/eclipse/mylyn/internal/bugzilla/ui/search/BugzillaSearchPage.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/search/BugzillaSearchPage.java,v
>retrieving revision 1.140
>diff -u -r1.140 BugzillaSearchPage.java
>--- src/org/eclipse/mylyn/internal/bugzilla/ui/search/BugzillaSearchPage.java	10 Apr 2010 06:37:49 -0000	1.140
>+++ src/org/eclipse/mylyn/internal/bugzilla/ui/search/BugzillaSearchPage.java	10 Apr 2010 10:32:50 -0000
>@@ -40,6 +40,7 @@
> import org.eclipse.jface.fieldassist.ContentProposalAdapter;
> import org.eclipse.jface.fieldassist.IContentProposalProvider;
> import org.eclipse.jface.operation.IRunnableWithProgress;
>+import org.eclipse.jface.resource.JFaceResources;
> import org.eclipse.jface.viewers.ILabelProvider;
> import org.eclipse.jface.window.Window;
> import org.eclipse.mylyn.commons.core.CoreUtil;
>@@ -97,6 +98,7 @@
>  * @author Mik Kersten (hardening of prototype)
>  * @author Frank Becker
>  */
>+@SuppressWarnings("restriction")
> public class BugzillaSearchPage extends AbstractRepositoryQueryPage implements Listener {
> 
> 	private static final int HEIGHT_ATTRIBUTE_COMBO = 70;
>@@ -431,7 +433,7 @@
> 
> 		moreOptionsExpandComposite = toolkit.createExpandableComposite(control, ExpandableComposite.COMPACT
> 				| ExpandableComposite.TWISTIE | ExpandableComposite.TITLE_BAR);
>-		moreOptionsExpandComposite.setFont(control.getFont());
>+		moreOptionsExpandComposite.setFont(JFaceResources.getFontRegistry().getBold(JFaceResources.DIALOG_FONT));
> 		moreOptionsExpandComposite.setBackground(null);
> 		moreOptionsExpandComposite.setText(Messages.BugzillaSearchPage_More_Options);
> 		moreOptionsExpandComposite.setLayout(new GridLayout(3, false));
>@@ -512,7 +514,7 @@
> 
> 		new Label(basicComposite, SWT.NONE);
> 		Composite emailComposite = new Composite(basicComposite, SWT.NONE);
>-		emailComposite.setLayoutData(new GridData(SWT.CENTER, SWT.CENTER, false, false, 2, 1));
>+		emailComposite.setLayoutData(new GridData(SWT.LEFT, SWT.CENTER, false, false, 2, 1));
> 		GridLayout emailLayout = new GridLayout();
> 		emailLayout.marginWidth = 0;
> 		emailLayout.marginHeight = 0;
>@@ -699,7 +701,7 @@
> 
> 		new Label(advancedComposite, SWT.NONE);
> 		Composite emailComposite2 = new Composite(advancedComposite, SWT.NONE);
>-		emailComposite2.setLayoutData(new GridData(SWT.CENTER, SWT.CENTER, false, false, 2, 1));
>+		emailComposite2.setLayoutData(new GridData(SWT.LEFT, SWT.CENTER, false, false, 2, 1));
> 		GridLayout emailLayout2 = new GridLayout();
> 		emailLayout2.marginWidth = 0;
> 		emailLayout2.marginHeight = 0;
>@@ -1123,10 +1125,16 @@
> 				moreOptionsExpandComposite.setExpanded(true);
> 			}
> 			setPageComplete(isPageComplete());
>+		}
>+		if (visible) {
>+			getControl().getShell().layout(false, true);
> 			Point oldSize = getControl().getSize();
> 			Point newSize = getControl().computeSize(SWT.DEFAULT, SWT.DEFAULT, true);
>+			if (!moreOptionsExpandComposite.isExpanded()) {
>+				// for some reason in not expanded state the width is a little to small
>+				newSize.x += 36;
>+			}
> 			resizeDialogIfNeeded(oldSize, newSize);
>-
> 			if (getWizard() == null) {
> 				// TODO: wierd check
> 				summaryPattern.setFocus();
>Index: src/org/eclipse/mylyn/internal/bugzilla/ui/search/messages.properties
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/search/messages.properties,v
>retrieving revision 1.10
>diff -u -r1.10 messages.properties
>--- src/org/eclipse/mylyn/internal/bugzilla/ui/search/messages.properties	26 Feb 2010 20:12:59 -0000	1.10
>+++ src/org/eclipse/mylyn/internal/bugzilla/ui/search/messages.properties	10 Apr 2010 10:32:50 -0000
>@@ -13,10 +13,10 @@
> BugzillaSearchPage_any=any
> BugzillaSearchPage_any_word=any word
> BugzillaSearchPage_Bugzilla_Query=Bugzilla Query
>-BugzillaSearchPage_cc=cc
>+BugzillaSearchPage_cc=CC
> BugzillaSearchPage_Changed_in=Ch&anged in:
> BugzillaSearchPage_Comment=&Comment:
>-BugzillaSearchPage_commenter=commenter
>+BugzillaSearchPage_commenter=Commenter
> BugzillaSearchPage_Component=Compo&nent:
> BugzillaSearchPage_days=\ days.
> BugzillaSearchPage_Email=&Email:
>@@ -33,22 +33,22 @@
> BugzillaSearchPage_notregexp=notregexp
> BugzillaSearchPage_Number_of_days_must_be_a_positive_integer=Number of days must be a positive integer. {0} is invalid.
> BugzillaSearchPage_Operating_System=&Operating System:
>-BugzillaSearchPage_owner=owner
>+BugzillaSearchPage_owner=Owner
> BugzillaSearchPage_Product=&Product:
> BugzillaSearchPage_PROORITY=Priori&ty:
>-BugzillaSearchPage_qacontact=qa
>+BugzillaSearchPage_qacontact=QA Contact
> BugzillaSearchPage_Query_Title=&Query Title:
> BugzillaSearchPage_regexp=regexp
>-BugzillaSearchPage_reporter=reporter
>+BugzillaSearchPage_reporter=Reporter
> BugzillaSearchPage_Resolution=&Resolution:
> BugzillaSearchPage_Select_=Select...
> BugzillaSearchPage_Select_the_Bugzilla_query_parameters=Select the Bugzilla query parameters.  Use the Update Attributes button to retrieve updated values from the repository.
> BugzillaSearchPage_Severity=Se&verity:
> BugzillaSearchPage_Status=Stat&us:
>-BugzillaSearchPage_substring=substring
>+BugzillaSearchPage_substring=contains
> BugzillaSearchPage_Summary=Summar&y:
> BugzillaSearchPage_Update_Attributes_from_Repository=Up&date Attributes from Repository
> BugzillaSearchPage_Updating_search_options_=Updating search options...
> BugzillaSearchPage_Version=Vers&ion:
> BugzillaSearchPage_ClearFields=Clear Fields
>-BugzillaSearchPage_More_Options=more Options
>+BugzillaSearchPage_More_Options=More Options
>#P org.eclipse.mylyn.tasks.search
>Index: src/org/eclipse/mylyn/internal/tasks/ui/TaskSearchPage.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.search/src/org/eclipse/mylyn/internal/tasks/ui/TaskSearchPage.java,v
>retrieving revision 1.2
>diff -u -r1.2 TaskSearchPage.java
>--- src/org/eclipse/mylyn/internal/tasks/ui/TaskSearchPage.java	3 Apr 2010 01:33:11 -0000	1.2
>+++ src/org/eclipse/mylyn/internal/tasks/ui/TaskSearchPage.java	10 Apr 2010 10:32:53 -0000
>@@ -166,7 +166,7 @@
> 		group.setLayoutData(gd);
> 
> 		Label label = new Label(group, SWT.NONE);
>-		label.setText(Messages.TaskSearchPage_Select_Repository_);
>+		label.setText(Messages.TaskSearchPage_Repository);
> 
> 		repositoryCombo = new Combo(group, SWT.SINGLE | SWT.BORDER | SWT.READ_ONLY);
> 		repositoryCombo.addSelectionListener(new SelectionAdapter() {
>#P org.eclipse.mylyn.tasks.ui
>Index: src/org/eclipse/mylyn/internal/tasks/ui/Messages.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/Messages.java,v
>retrieving revision 1.11
>diff -u -r1.11 Messages.java
>--- src/org/eclipse/mylyn/internal/tasks/ui/Messages.java	12 Oct 2009 23:14:09 -0000	1.11
>+++ src/org/eclipse/mylyn/internal/tasks/ui/Messages.java	10 Apr 2010 10:32:54 -0000
>@@ -91,7 +91,7 @@
> 
> 	public static String TaskSearchPage_Repository_Search;
> 
>-	public static String TaskSearchPage_Select_Repository_;
>+	public static String TaskSearchPage_Repository;
> 
> 	public static String TaskSearchPage_Task_Key_ID;
> 
>Index: src/org/eclipse/mylyn/internal/tasks/ui/messages.properties
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/messages.properties,v
>retrieving revision 1.16
>diff -u -r1.16 messages.properties
>--- src/org/eclipse/mylyn/internal/tasks/ui/messages.properties	12 Oct 2009 23:14:09 -0000	1.16
>+++ src/org/eclipse/mylyn/internal/tasks/ui/messages.properties	10 Apr 2010 10:32:54 -0000
>@@ -58,7 +58,7 @@
> 
> TaskSearchPage_No_task_found_matching_key_=No task found matching key: 
> TaskSearchPage_Repository_Search=Repository Search
>-TaskSearchPage_Select_Repository_=Se&lect Repository: 
>+TaskSearchPage_Repository=Repository: 
> TaskSearchPage_Task_Key_ID=Task Key/ID: 
> TaskSearchPage_Task_Search=Task Search
>

Actions: View | Diff

Attachments on bug 305568: 164464 | 164465