Attachment 162109 Details for Bug 293474 – one part fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] one part fix

busted_offsets.patch (text/plain), 1.71 KB, created by Michael Rennie

on 2010-03-15 17:04:44 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Rennie

Created: 2010-03-15 17:04:44 EDT

Size: 1.71 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.pde.ui
>Index: src/org/eclipse/pde/internal/ui/editor/context/XMLInputContext.java
>===================================================================
>RCS file: /cvsroot/eclipse/pde/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/context/XMLInputContext.java,v
>retrieving revision 1.30
>diff -u -r1.30 XMLInputContext.java
>--- src/org/eclipse/pde/internal/ui/editor/context/XMLInputContext.java	15 Apr 2008 14:57:22 -0000	1.30
>+++ src/org/eclipse/pde/internal/ui/editor/context/XMLInputContext.java	15 Mar 2010 20:57:55 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2003, 2008 IBM Corporation and others.
>+ * Copyright (c) 2003, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -212,6 +212,7 @@
> 	}
> 
> 	private void addAttributeOperation(IDocumentAttributeNode attr, ArrayList ops, IModelChangedEvent event) {
>+
> 		int offset = attr.getValueOffset();
> 		Object newValue = event.getNewValue();
> 		Object changedObject = attr;
>@@ -221,7 +222,7 @@
> 				int length = attr.getValueOffset() + attr.getValueLength() + 1 - attr.getNameOffset();
> 				op = getAttributeDeleteEditOperation(attr.getNameOffset(), length);
> 			} else {
>-				op = new ReplaceEdit(offset, attr.getValueLength(), getWritableAttributeNodeValue(event.getNewValue().toString()));
>+				op = new ReplaceEdit(offset, event.getOldValue().toString().length()/* attr.getValueLength()*/, getWritableAttributeNodeValue(event.getNewValue().toString()));
> 			}
> 		}
>

Actions: View | Diff

Attachments on bug 293474: 150655 | 150656 | 153946 | 154363 | 162109 | 162184