Attachment 161013 Details for Bug 263689 – Another fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Another fix

zpatch.txt (text/plain), 1.49 KB, created by Marc Khouzam

on 2010-03-04 14:34:11 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Khouzam

Created: 2010-03-04 14:34:11 EST

Size: 1.49 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.cdt.dsf.gdb
>Index: src/org/eclipse/cdt/dsf/mi/service/command/commands/macos/MacOSMIEnvironmentCD.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/macos/MacOSMIEnvironmentCD.java,v
>retrieving revision 1.1
>diff -u -r1.1 MacOSMIEnvironmentCD.java
>--- src/org/eclipse/cdt/dsf/mi/service/command/commands/macos/MacOSMIEnvironmentCD.java	3 Mar 2010 14:35:50 -0000	1.1
>+++ src/org/eclipse/cdt/dsf/mi/service/command/commands/macos/MacOSMIEnvironmentCD.java	4 Mar 2010 19:27:46 -0000
>@@ -16,7 +16,21 @@
> 
> public class MacOSMIEnvironmentCD extends MIEnvironmentCD {
> 
>+	// We need to send the following format:
>+	//	-environment-cd "\"/path/without/any/spaces\"" or -environment-cd /path/without/any/spaces
>+	//	-environment-cd "\"/path/with spaces\""
> 	public MacOSMIEnvironmentCD(ICommandControlDMContext ctx, String path) {
>-		super(ctx, '\"' + path + '\"');
>+		super(ctx, (path == null) ? null : "\"\\\"" + path + "\\\"\""); //$NON-NLS-1$ //$NON-NLS-2$
>+	}
>+	
>+	@Override
>+	protected String parametersToString() {
>+		// Apple's GDB is very picky.  We override the parameter formatting
>+		// so that we can control exactly what will be sent to GDB.
>+		StringBuffer buffer = new StringBuffer();
>+		for (String parameter : getParameters()) {
>+			buffer.append(' ').append(parameter);
>+		}
>+		return buffer.toString().trim();	
> 	}
> }

Flags:

marc.khouzam: iplog-

Actions: View | Diff

Attachments on bug 263689: 124726 | 139339 | 139457 | 155688 | 160124 | 160879 | 161013