Attachment 160124 Details for Bug 263689 – Using 'cd' instead of "-environment-cd"

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Using 'cd' instead of "-environment-cd"

zpatch.txt (text/plain), 3.29 KB, created by Marc Khouzam

on 2010-02-24 16:22:35 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Khouzam

Created: 2010-02-24 16:22:35 EST

Size: 3.29 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.cdt.dsf.gdb
>Index: src/org/eclipse/cdt/dsf/gdb/launching/FinalLaunchSequence.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/FinalLaunchSequence.java,v
>retrieving revision 1.8
>diff -u -r1.8 FinalLaunchSequence.java
>--- src/org/eclipse/cdt/dsf/gdb/launching/FinalLaunchSequence.java	16 Feb 2010 01:44:33 -0000	1.8
>+++ src/org/eclipse/cdt/dsf/gdb/launching/FinalLaunchSequence.java	24 Feb 2010 21:18:21 -0000
>@@ -34,8 +34,8 @@
> import org.eclipse.cdt.dsf.mi.service.CSourceLookup;
> import org.eclipse.cdt.dsf.mi.service.IMIProcesses;
> import org.eclipse.cdt.dsf.mi.service.MIBreakpointsManager;
>+import org.eclipse.cdt.dsf.mi.service.command.commands.CLIEnvironmentCD;
> import org.eclipse.cdt.dsf.mi.service.command.commands.CLISource;
>-import org.eclipse.cdt.dsf.mi.service.command.commands.MIEnvironmentCD;
> import org.eclipse.cdt.dsf.mi.service.command.commands.MIFileExecAndSymbols;
> import org.eclipse.cdt.dsf.mi.service.command.commands.MIGDBSetArgs;
> import org.eclipse.cdt.dsf.mi.service.command.commands.MIGDBSetAutoSolib;
>@@ -199,8 +199,11 @@
>       		}
> 
>         	if (dir != null) {
>+        		// "-environment-cd" does not work the same way on MacOS because it requires
>+        		// more quoting.  Using the CLI version "cd" works for every platform.
>+        		// See http://bugs.eclipse.org/263689
>         		fCommandControl.queueCommand(
>-        				new MIEnvironmentCD(fCommandControl.getContext(), dir.toPortableString()), 
>+        				new CLIEnvironmentCD(fCommandControl.getContext(), dir.toPortableString()), 
>         				new DataRequestMonitor<MIInfo>(getExecutor(), requestMonitor));
>         	} else {
>         		requestMonitor.done();
>Index: src/org/eclipse/cdt/dsf/mi/service/command/commands/CLIEnvironmentCD.java
>===================================================================
>RCS file: src/org/eclipse/cdt/dsf/mi/service/command/commands/CLIEnvironmentCD.java
>diff -N src/org/eclipse/cdt/dsf/mi/service/command/commands/CLIEnvironmentCD.java
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ src/org/eclipse/cdt/dsf/mi/service/command/commands/CLIEnvironmentCD.java	1 Jan 1970 00:00:00 -0000
>@@ -0,0 +1,27 @@
>+/*******************************************************************************
>+ * Copyright (c) 2010 Ericsson and others.
>+ * All rights reserved. This program and the accompanying materials
>+ * are made available under the terms of the Eclipse Public License v1.0
>+ * which accompanies this distribution, and is available at
>+ * http://www.eclipse.org/legal/epl-v10.html
>+ *
>+ * Contributors:
>+ *     Ericsson - Initial API and implementation'
>+ *******************************************************************************/
>+package org.eclipse.cdt.dsf.mi.service.command.commands;
>+
>+import org.eclipse.cdt.dsf.debug.service.command.ICommandControlService.ICommandControlDMContext;
>+import org.eclipse.cdt.dsf.mi.service.command.output.MIInfo;
>+
>+/**
>+ *      cd PATHDIR
>+ *
>+ *   Set GDB's working directory.
>+ * @since 3.0
>+ * 
>+ */
>+public class CLIEnvironmentCD extends CLICommand<MIInfo> {
>+	public CLIEnvironmentCD(ICommandControlDMContext ctx, String path) {
>+		super(ctx, "cd " + path); //$NON-NLS-1$
>+	}
>+}
>\ No newline at end of file

Flags:

marc.khouzam: iplog-

Actions: View | Diff

Attachments on bug 263689: 124726 | 139339 | 139457 | 155688 | 160124 | 160879 | 161013