Attachment 159758 Details for Bug 302927 – patch 2

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch 2

bug302927.patch (text/plain), 1.76 KB, created by James Blackburn

on 2010-02-22 05:15:17 EST

(hide)

Description:

Filename:

MIME Type:

Creator: James Blackburn

Created: 2010-02-22 05:15:17 EST

Size: 1.76 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.cdt.debug.mi.core
>Index: mi/org/eclipse/cdt/debug/mi/core/RxThread.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt-debug/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/RxThread.java,v
>retrieving revision 1.22
>diff -u -r1.22 RxThread.java
>--- mi/org/eclipse/cdt/debug/mi/core/RxThread.java	18 Feb 2010 16:00:37 -0000	1.22
>+++ mi/org/eclipse/cdt/debug/mi/core/RxThread.java	22 Feb 2010 10:13:18 -0000
>@@ -17,6 +17,7 @@
> import java.io.InputStreamReader;
> import java.io.OutputStream;
> import java.util.ArrayList;
>+import java.util.LinkedList;
> import java.util.List;
> 
> import org.eclipse.cdt.debug.mi.core.command.CLICommand;
>@@ -66,7 +67,7 @@
> public class RxThread extends Thread {
> 
> 	final MISession session;
>-	List<MIStreamRecord> oobList;
>+	LinkedList<MIStreamRecord> oobList;
> 	CLIProcessor cli;
> 	int prompt = 1; // 1 --> Primary prompt "(gdb)"; 2 --> Secondary Prompt ">"
> 	boolean fEnableConsole = true;
>@@ -75,7 +76,7 @@
> 		super("MI RX Thread"); //$NON-NLS-1$
> 		session = s;
> 		cli = new CLIProcessor(session);
>-		oobList = new ArrayList<MIStreamRecord>();
>+		oobList = new LinkedList<MIStreamRecord>();
> 	}
> 
> 	/*
>@@ -259,10 +260,9 @@
> 				for (int i = 0; i < oobs.length; i++) {
> 					processMIOOBRecord(oobs[i], list);
> 				}
>-				// If not waiting for any command results, don't need the result in the oobList
>-// This breaks detecting shared library event handling.  See bug 302927
>-//				if (rxQueue.isEmpty())
>-//					oobList.clear();
>+				// If not waiting for any command results, prune the oobList
>+				if (rxQueue.isEmpty() && oobList.size() > 4)
>+					oobList.removeFirst();
> 			}
> 
> 			MIEvent[] events = list.toArray(new MIEvent[list.size()]);

Flags:

jamesblackburn+eclipse: iplog-

Actions: View | Diff

Attachments on bug 302927: 159162 | 159230 | 159758