Attachment 159754 Details for Bug 301826 – Patch propsal

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch propsal

clipboard.txt (text/plain), 2.62 KB, created by Stefan Röck

on 2010-02-22 04:21:06 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Röck

Created: 2010-02-22 04:21:06 EST

Size: 2.62 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rwt.widgets.upload
>Index: src/org/eclipse/rwt/widgets/Upload.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/sandbox/org.eclipse.rwt.widgets.upload/src/org/eclipse/rwt/widgets/Upload.js,v
>retrieving revision 1.11
>diff -u -r1.11 Upload.js
>--- src/org/eclipse/rwt/widgets/Upload.js	9 Oct 2009 14:29:25 -0000	1.11
>+++ src/org/eclipse/rwt/widgets/Upload.js	22 Feb 2010 09:14:14 -0000
>@@ -75,18 +75,14 @@
>     this.add(topLayout);
> 
>     if (this._showProgress) {
>-        var bottomLayout = new qx.ui.layout.CanvasLayout();
>-        bottomLayout.set({left:0,height:'auto',marginTop:2});
>-        bottomLayout.setOverflow("hidden");
>-        bottomLayout.setAppearance( "progressbar" );
>-
>         // Progress Bar
>-        this._progressBar = new qx.ui.layout.CanvasLayout();
>-        this._progressBar.setParent( bottomLayout );
>-        this._progressBar.set({left:0,height:16});
>-        this._progressBar.setAppearance( "progressbar-indicator" );
>-
>-        this.add(bottomLayout);
>+        this._progressBar = new org.eclipse.swt.widgets.ProgressBar();
>+        this._progressBar.set({left:0,height:20});
>+        this._progressBar.setMinimum(0);
>+        this._progressBar.setMaximum(100);
>+        this._progressBar.setFlag(org.eclipse.swt.widgets.ProgressBar.FLAG_HORIZONTAL);
>+        
>+        this.add(this._progressBar);
>     }
>     
>     if (this._fireProgressEvents) {
>@@ -169,7 +165,7 @@
>             // make sure, that the progressbar (if visible) is filled completely after 
>             // uploading finished
>             if (this._showProgress) {
>-              this._progressBar.setWidth("100%");
>+              this._progressBar.setSelection(100);
>             }
>             this._isStarted = false;
>     
>@@ -244,7 +240,9 @@
>                 if (percentCompleted != null) {
>                     
>                     if (this._showProgress) {
>-                        this._progressBar.setWidth(percentCompleted.firstChild.data + "%");
>+                        var progress = percentCompleted.firstChild.data;
>+                        this.debug("New Progress " + progress);
>+                    	this._progressBar.setSelection(progress);
>                     }
> 
>                     this.createDispatchDataEvent("upload", false);
>@@ -276,7 +274,7 @@
>     
>     _resetUpload : function() {
>       if (this._progressBar) {
>-         this._progressBar.setWidth("0%");
>+         this._progressBar.setSelection(0);
>       }
>       if (this._uploadField) {
>         this._uploadField.setValue("");

Actions: View | Diff

Attachments on bug 301826: 159754