Attachment 159121 Details for Bug 235479 – fix life-lock

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix life-lock

clipboard.txt (text/plain), 996 bytes, created by Steffen Pingel

on 2010-02-15 13:42:03 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Steffen Pingel

Created: 2010-02-15 13:42:03 EST

Size: 996 bytes

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.tasks.core
>Index: src/org/eclipse/mylyn/internal/tasks/core/TaskList.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/TaskList.java,v
>retrieving revision 1.51
>diff -u -r1.51 TaskList.java
>--- src/org/eclipse/mylyn/internal/tasks/core/TaskList.java	6 Feb 2010 03:58:55 -0000	1.51
>+++ src/org/eclipse/mylyn/internal/tasks/core/TaskList.java	15 Feb 2010 18:39:18 -0000
>@@ -680,13 +680,15 @@
> 					if (lock.getDepth() == 1) {
> 						delta = new HashSet<TaskContainerDelta>();
> 					}
>+					// success
> 					return;
> 				}
> 			} catch (InterruptedException e) {
> 				if (ignoreInterrupts) {
>-					Thread.currentThread().interrupt();
>+					// clear interrupted status to retry lock.aquire() 
>+					Thread.interrupted();
> 				} else {
>-					throw new OperationCanceledException();
>+					break;
> 				}
> 			}
> 		}

Actions: View | Diff

Attachments on bug 235479: 103661 | 158369 | 158370 | 159121