Attachment 158845 Details for Bug 301438 – Patch on 3.5 maintenance branch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch on 3.5 maintenance branch

patch35.txt (text/plain), 2.43 KB, created by Satyam Kandula

on 2010-02-11 08:51:36 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Satyam Kandula

Created: 2010-02-11 08:51:36 EST

Size: 2.43 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: model/org/eclipse/jdt/internal/core/hierarchy/HierarchyResolver.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/hierarchy/HierarchyResolver.java,v
>retrieving revision 1.89.2.1
>diff -u -r1.89.2.1 HierarchyResolver.java
>--- model/org/eclipse/jdt/internal/core/hierarchy/HierarchyResolver.java	17 Aug 2009 18:52:33 -0000	1.89.2.1
>+++ model/org/eclipse/jdt/internal/core/hierarchy/HierarchyResolver.java	11 Feb 2010 13:47:56 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2009 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -645,11 +645,6 @@
> 				CompilationUnitDeclaration parsedUnit = null;
> 				if (cu.isOpen()) {
> 					// create parsed unit from source element infos
>-					// As part of fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=254738
>-					// Since we have the handle to the ICompilationUnit, instead of the name pass the ICompilationUnit, which is required if we were 
>-					// to get through Parser.getMethodBodies(), which is invoked later in this method. Note that as part of this fix,
>-					// ASTNode.HasAllMethodBodies flag - which was being set earlier - has been removed. As a design feature, only the Parser 
>-					// is supposed to handle this particular bit.
> 					CompilationResult result = new CompilationResult((ICompilationUnit)cu, i, openablesLength, this.options.maxProblemsPerUnit);
> 					SourceTypeElementInfo[] typeInfos = null;
> 					try {
>@@ -673,6 +668,11 @@
> 							flags,
> 							this.lookupEnvironment.problemReporter,
> 							result);
>+					
>+					// We would have got all the necessary local types by now and hence there is no further need 
>+					// to parse the method bodies. Parser.getMethodBodies, which is called latter in this function, 
>+					// will not parse the method statements if ASTNode.HasAllMethodBodies is set. 
>+					if (containsLocalType) 	parsedUnit.bits |= ASTNode.HasAllMethodBodies;
> 				} else {
> 					// create parsed unit from file
> 					IFile file = (IFile) cu.getResource();

Flags:

satyam.kandula: review?

Actions: View | Diff

Attachments on bug 301438: 157805 | 157869 | 158662 | 158672 | 158831 | 158845 | 158846