Attachment 156298 Details for Bug 258767 – Implementation of Debug Toolbar.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Implementation of Debug Toolbar.

20091124_296018.patch (text/plain), 3.83 KB, created by Pawel Piech

on 2010-01-15 19:03:10 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Pawel Piech

Created: 2010-01-15 19:03:10 EST

Size: 3.83 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.debug.ui
>Index: ui/org/eclipse/debug/internal/ui/views/variables/VariablesView.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/variables/VariablesView.java,v
>retrieving revision 1.175.2.1
>diff -u -r1.175.2.1 VariablesView.java
>--- ui/org/eclipse/debug/internal/ui/views/variables/VariablesView.java	13 Nov 2009 23:37:07 -0000	1.175.2.1
>+++ ui/org/eclipse/debug/internal/ui/views/variables/VariablesView.java	24 Nov 2009 19:49:24 -0000
>@@ -76,7 +76,11 @@
> import org.eclipse.jface.util.IPropertyChangeListener;
> import org.eclipse.jface.util.LocalSelectionTransfer;
> import org.eclipse.jface.util.PropertyChangeEvent;
>+import org.eclipse.jface.viewers.ColumnViewerEditor;
>+import org.eclipse.jface.viewers.ColumnViewerEditorActivationEvent;
>+import org.eclipse.jface.viewers.ColumnViewerEditorActivationStrategy;
> import org.eclipse.jface.viewers.DoubleClickEvent;
>+import org.eclipse.jface.viewers.FocusCellOwnerDrawHighlighter;
> import org.eclipse.jface.viewers.ISelection;
> import org.eclipse.jface.viewers.ISelectionChangedListener;
> import org.eclipse.jface.viewers.ISelectionProvider;
>@@ -85,6 +89,8 @@
> import org.eclipse.jface.viewers.StructuredSelection;
> import org.eclipse.jface.viewers.StructuredViewer;
> import org.eclipse.jface.viewers.TreeViewer;
>+import org.eclipse.jface.viewers.TreeViewerEditor;
>+import org.eclipse.jface.viewers.TreeViewerFocusCellManager;
> import org.eclipse.jface.viewers.Viewer;
> import org.eclipse.swt.SWT;
> import org.eclipse.swt.custom.SashForm;
>@@ -358,6 +364,11 @@
> 	private SelectionProviderWrapper fSelectionProvider;
>     
> 	/**
>+	 * Presentation context for this view.
>+	 */
>+	private IPresentationContext fPresentationContext;
>+	
>+	/**
> 	 * Remove myself as a selection listener
> 	 * and preference change listener.
> 	 *
>@@ -374,6 +385,10 @@
> 			viewer.removeModelChangedListener(this);
> 			viewer.removeViewerUpdateListener(this);
> 		}
>+		if (fPresentationContext != null) {
>+		    fPresentationContext.dispose();
>+		    fPresentationContext = null;
>+		}
> 		if (fDetailPane != null) fDetailPane.dispose();
>         fInputService.dispose();
>         fSelectionProvider.dispose();
>@@ -581,8 +596,8 @@
> 	protected TreeModelViewer createTreeViewer(Composite parent) {
> 		
> 		int style = getViewerStyle();
>-		final TreeModelViewer variablesViewer = new TreeModelViewer(parent, style,
>-				new DebugModelPresentationContext(getPresentationContextId(), getModelPresentation()));
>+		fPresentationContext = new DebugModelPresentationContext(getPresentationContextId(), fModelPresentation); 
>+		final TreeModelViewer variablesViewer = new TreeModelViewer(parent, style, fPresentationContext);
> 		
> 		variablesViewer.getControl().addFocusListener(new FocusAdapter() {
> 			public void focusGained(FocusEvent e) {
>@@ -602,6 +617,20 @@
> 				getViewSite().getActionBars().updateActionBars();
> 			}
> 		});
>+		
>+        
>+        ColumnViewerEditorActivationStrategy activationStrategy = new ColumnViewerEditorActivationStrategy(variablesViewer) {
>+            protected boolean isEditorActivationEvent(ColumnViewerEditorActivationEvent event) {
>+                return super.isEditorActivationEvent(event) || 
>+                    (event.eventType == ColumnViewerEditorActivationEvent.KEY_PRESSED &&
>+                     event.keyCode == SWT.F2);
>+            }
>+        };
>+        
>+        TreeViewerEditor.create(
>+            variablesViewer, new TreeViewerFocusCellManager(variablesViewer, new FocusCellOwnerDrawHighlighter(variablesViewer)), 
>+            activationStrategy, ColumnViewerEditor.DEFAULT | ColumnViewerEditor.KEYBOARD_ACTIVATION);
>+
> 		variablesViewer.getPresentationContext().addPropertyChangeListener(
> 				new IPropertyChangeListener() {
> 					public void propertyChange(PropertyChangeEvent event) {

Actions: View | Diff

Attachments on bug 258767: 156298 | 156299 | 185360 | 189627 | 199366 | 203180 | 203431 | 203868