Attachment 156097 Details for Bug 299633 – path for FileUploadServiceHandler

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] path for FileUploadServiceHandler

FileUploadServiceHandler.patch (text/plain), 1.59 KB, created by falko

on 2010-01-14 09:01:46 EST

(hide)

Description:

Filename:

MIME Type:

Creator: falko

Created: 2010-01-14 09:01:46 EST

Size: 1.59 KB

patch

obsolete

>Index: src/org/eclipse/rwt/widgets/upload/servlet/FileUploadServiceHandler.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/sandbox/org.eclipse.rwt.widgets.upload/src/org/eclipse/rwt/widgets/upload/servlet/FileUploadServiceHandler.java,v
>retrieving revision 1.4
>diff -u -r1.4 FileUploadServiceHandler.java
>--- src/org/eclipse/rwt/widgets/upload/servlet/FileUploadServiceHandler.java	18 May 2009 14:46:08 -0000	1.4
>+++ src/org/eclipse/rwt/widgets/upload/servlet/FileUploadServiceHandler.java	14 Jan 2010 13:45:45 -0000
>@@ -22,7 +22,6 @@
> import org.apache.commons.fileupload.disk.DiskFileItemFactory;
> import org.apache.commons.fileupload.servlet.ServletFileUpload;
> import org.eclipse.rwt.RWT;
>-import org.eclipse.rwt.internal.util.URLHelper;
> import org.eclipse.rwt.service.IServiceHandler;
> 
> 
>@@ -236,12 +235,14 @@
>    * as url parameters. 
>    */
>   public static String getUrl(final String widgetId) {
>-    StringBuffer url = new StringBuffer();
>-    url.append(URLHelper.getURLString(false));
>-
>-    URLHelper.appendFirstParam(url, REQUEST_PARAM, getServiceHandlerId());
>-    URLHelper.appendParam(url, REQUEST_WIDGET_ID, widgetId);
>-
>+    StringBuilder url = new StringBuilder( 256 );
>+    url.append( RWT.getRequest().getContextPath() );
>+    url.append( RWT.getRequest().getServletPath() );
>+    url.append( "?" );
>+    url.append( REQUEST_PARAM ).append( "=" ).append( getServiceHandlerId() );
>+    url.append( "&" );
>+    url.append( REQUEST_WIDGET_ID ).append( "=" ).append( widgetId );
>+    
>     return RWT.getResponse().encodeURL(url.toString());
>   }
> }

Actions: View | Diff

Attachments on bug 299633: 156097 | 197282