Attachment 155868 Details for Bug 299379 – Illustrative patch - not a general fix - not meant to be applied

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Illustrative patch - not a general fix - not meant to be applied

patch model snippet 6.txt (text/plain), 2.11 KB, created by Oleg Besedin

on 2010-01-12 10:12:51 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Oleg Besedin

Created: 2010-01-12 10:12:51 EST

Size: 2.11 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.e4.ui.workbench
>Index: src/org/eclipse/e4/workbench/ui/internal/PartServiceImpl.java
>===================================================================
>RCS file: /cvsroot/eclipse/e4/org.eclipse.e4.ui/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/workbench/ui/internal/PartServiceImpl.java,v
>retrieving revision 1.11
>diff -u -r1.11 PartServiceImpl.java
>--- src/org/eclipse/e4/workbench/ui/internal/PartServiceImpl.java	12 Jan 2010 15:00:37 -0000	1.11
>+++ src/org/eclipse/e4/workbench/ui/internal/PartServiceImpl.java	12 Jan 2010 15:14:27 -0000
>@@ -286,7 +286,7 @@
> 		// 3) make it visible / active / re-layout
> 
> 		// bug with activation - need to deactivate first:
>-		// deactivate(part);
>+		deactivate(part);
> 		activate(part);
> 		return part;
> 	}
>#P org.eclipse.e4.ui.workbench.renderers.swt
>Index: src/org/eclipse/e4/workbench/ui/renderers/swt/LazyStackRenderer.java
>===================================================================
>RCS file: /cvsroot/eclipse/e4/org.eclipse.e4.ui/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/workbench/ui/renderers/swt/LazyStackRenderer.java,v
>retrieving revision 1.11
>diff -u -r1.11 LazyStackRenderer.java
>--- src/org/eclipse/e4/workbench/ui/renderers/swt/LazyStackRenderer.java	7 Dec 2009 19:14:21 -0000	1.11
>+++ src/org/eclipse/e4/workbench/ui/renderers/swt/LazyStackRenderer.java	12 Jan 2010 15:14:27 -0000
>@@ -16,6 +16,7 @@
> import org.eclipse.e4.ui.model.application.MUIElement;
> import org.eclipse.e4.ui.services.events.IEventBroker;
> import org.eclipse.e4.ui.widgets.CTabFolder;
>+import org.eclipse.e4.ui.widgets.ETabFolder;
> import org.eclipse.e4.workbench.ui.IPresentationEngine;
> import org.eclipse.e4.workbench.ui.UIEvents;
> import org.eclipse.swt.SWT;
>@@ -51,6 +52,15 @@
> 					renderer.createGui(selPart);
> 					// activate(selPart);
> 				}
>+				 else {
>+				 if (stack.getWidget() instanceof ETabFolder) {
>+				 if (((ETabFolder) stack.getWidget())
>+				 .getSelectionIndex() == -1)
>+				 ((ETabFolder) stack.getWidget()).setSelection(0);
>+				 }
>+				
>+				 }
>+
> 			}
> 		};
>

Actions: View

Attachments on bug 299379: 155868 | 156265 | 156398