Attachment 155599 Details for Bug 295003 – EPartService v04

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] EPartService v04

bug295003-patch-v4.txt (text/plain), 22.02 KB, created by Remy Suen

on 2010-01-08 09:26:11 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Remy Suen

Created: 2010-01-08 09:26:11 EST

Size: 22.02 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.e4.ui.tests
>Index: src/org/eclipse/e4/ui/tests/application/EPartServiceTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/e4/org.eclipse.e4.ui/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/EPartServiceTest.java,v
>retrieving revision 1.7
>diff -u -r1.7 EPartServiceTest.java
>--- src/org/eclipse/e4/ui/tests/application/EPartServiceTest.java	6 Jan 2010 15:48:12 -0000	1.7
>+++ src/org/eclipse/e4/ui/tests/application/EPartServiceTest.java	8 Jan 2010 14:28:52 -0000
>@@ -21,6 +21,7 @@
> import org.eclipse.e4.ui.model.application.MApplication;
> import org.eclipse.e4.ui.model.application.MApplicationFactory;
> import org.eclipse.e4.ui.model.application.MPart;
>+import org.eclipse.e4.ui.model.application.MPartDescriptor;
> import org.eclipse.e4.ui.model.application.MPartStack;
> import org.eclipse.e4.ui.model.application.MWindow;
> import org.eclipse.e4.ui.services.IServiceConstants;
>@@ -636,6 +637,23 @@
> 		assertEquals(partBackB, partServiceB.getActivePart());
> 	}
> 
>+	public void testShowPart() {
>+		MApplication application = createApplication(1, new String[1][0]);
>+		MWindow window = application.getChildren().get(0);
>+		MPartDescriptor partDescriptor = MApplicationFactory.eINSTANCE
>+				.createPartDescriptor();
>+		partDescriptor.setId("partId");
>+		application.getDescriptors().add(partDescriptor);
>+
>+		engine.createGui(window);
>+
>+		EPartService partService = (EPartService) window.getContext().get(
>+				EPartService.class.getName());
>+		MPart part = partService.showPart("partId");
>+		assertNotNull(part);
>+		assertEquals("partId", part.getId());
>+	}
>+
> 	public void testSwitchWindows() {
> 		// create an application with two windows
> 		MApplication application = MApplicationFactory.eINSTANCE
>Index: src/org/eclipse/e4/ui/tests/workbench/MPartSashContainerTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/e4/org.eclipse.e4.ui/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/MPartSashContainerTest.java,v
>retrieving revision 1.1
>diff -u -r1.1 MPartSashContainerTest.java
>--- src/org/eclipse/e4/ui/tests/workbench/MPartSashContainerTest.java	5 Jan 2010 18:06:28 -0000	1.1
>+++ src/org/eclipse/e4/ui/tests/workbench/MPartSashContainerTest.java	8 Jan 2010 14:28:52 -0000
>@@ -15,6 +15,7 @@
> 
> import org.eclipse.e4.core.services.IDisposable;
> import org.eclipse.e4.core.services.context.IEclipseContext;
>+import org.eclipse.e4.ui.model.application.MApplication;
> import org.eclipse.e4.ui.model.application.MApplicationFactory;
> import org.eclipse.e4.ui.model.application.MPart;
> import org.eclipse.e4.ui.model.application.MPartSashContainer;
>@@ -73,7 +74,13 @@
> 		partSashContainer.getChildren().add(partA);
> 		partSashContainer.getChildren().add(partB);
> 
>-		wb = new E4Workbench(window, appContext);
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Object widget = partSashContainer.getWidget();
>Index: src/org/eclipse/e4/ui/tests/workbench/MPartTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/e4/org.eclipse.e4.ui/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/MPartTest.java,v
>retrieving revision 1.8
>diff -u -r1.8 MPartTest.java
>--- src/org/eclipse/e4/ui/tests/workbench/MPartTest.java	18 Dec 2009 13:16:03 -0000	1.8
>+++ src/org/eclipse/e4/ui/tests/workbench/MPartTest.java	8 Jan 2010 14:28:52 -0000
>@@ -15,6 +15,7 @@
> 
> import org.eclipse.e4.core.services.IDisposable;
> import org.eclipse.e4.core.services.context.IEclipseContext;
>+import org.eclipse.e4.ui.model.application.MApplication;
> import org.eclipse.e4.ui.model.application.MApplicationFactory;
> import org.eclipse.e4.ui.model.application.MPart;
> import org.eclipse.e4.ui.model.application.MPartSashContainer;
>@@ -72,7 +73,14 @@
> 
> 	public void testSetName() {
> 		final MWindow window = createWindowWithOneView("Part Name");
>-		wb = new E4Workbench(window, appContext);
>+
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Widget topWidget = (Widget) window.getWidget();
>@@ -105,7 +113,14 @@
> 
> 	public void testCTabItem_GetImage() {
> 		final MWindow window = createWindowWithOneView("Part Name");
>-		wb = new E4Workbench(window, appContext);
>+
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Widget topWidget = (Widget) window.getWidget();
>@@ -129,7 +144,14 @@
> 
> 	private void testDeclaredTooltip(String partToolTip, String expectedToolTip) {
> 		final MWindow window = createWindowWithOneView("Part Name", partToolTip);
>-		wb = new E4Workbench(window, appContext);
>+
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Widget topWidget = (Widget) window.getWidget();
>@@ -165,7 +187,14 @@
> 
> 	private void testMPart_setTooltip(String partToolTip, String expectedToolTip) {
> 		final MWindow window = createWindowWithOneView("Part Name");
>-		wb = new E4Workbench(window, appContext);
>+
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Widget topWidget = (Widget) window.getWidget();
>@@ -209,7 +238,14 @@
> 
> 	public void testMPart_getContext() {
> 		final MWindow window = createWindowWithOneView("Part Name");
>-		wb = new E4Workbench(window, appContext);
>+
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		MPartSashContainer container = (MPartSashContainer) window
>Index: src/org/eclipse/e4/ui/tests/workbench/MSashTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/e4/org.eclipse.e4.ui/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/MSashTest.java,v
>retrieving revision 1.12
>diff -u -r1.12 MSashTest.java
>--- src/org/eclipse/e4/ui/tests/workbench/MSashTest.java	18 Dec 2009 13:16:03 -0000	1.12
>+++ src/org/eclipse/e4/ui/tests/workbench/MSashTest.java	8 Jan 2010 14:28:52 -0000
>@@ -15,6 +15,7 @@
> 
> import org.eclipse.e4.core.services.IDisposable;
> import org.eclipse.e4.core.services.context.IEclipseContext;
>+import org.eclipse.e4.ui.model.application.MApplication;
> import org.eclipse.e4.ui.model.application.MApplicationFactory;
> import org.eclipse.e4.ui.model.application.MPart;
> import org.eclipse.e4.ui.model.application.MPartSashContainer;
>@@ -87,7 +88,13 @@
> 	public void testSashWeights() {
> 		MWindow window = createSashWithNViews(2);
> 
>-		wb = new E4Workbench(window, appContext);
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Widget topWidget = (Widget) window.getWidget();
>Index: src/org/eclipse/e4/ui/tests/workbench/MSaveablePartTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/e4/org.eclipse.e4.ui/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/MSaveablePartTest.java,v
>retrieving revision 1.5
>diff -u -r1.5 MSaveablePartTest.java
>--- src/org/eclipse/e4/ui/tests/workbench/MSaveablePartTest.java	18 Dec 2009 13:16:03 -0000	1.5
>+++ src/org/eclipse/e4/ui/tests/workbench/MSaveablePartTest.java	8 Jan 2010 14:28:52 -0000
>@@ -15,6 +15,7 @@
> 
> import org.eclipse.e4.core.services.IDisposable;
> import org.eclipse.e4.core.services.context.IEclipseContext;
>+import org.eclipse.e4.ui.model.application.MApplication;
> import org.eclipse.e4.ui.model.application.MApplicationFactory;
> import org.eclipse.e4.ui.model.application.MPart;
> import org.eclipse.e4.ui.model.application.MPartSashContainer;
>@@ -72,7 +73,14 @@
> 
> 	public void testCreateView() {
> 		final MWindow window = createWindowWithOneView("Part Name");
>-		wb = new E4Workbench(window, appContext);
>+
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Widget topWidget = (Widget) window.getWidget();
>Index: src/org/eclipse/e4/ui/tests/workbench/MWindowTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/e4/org.eclipse.e4.ui/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/MWindowTest.java,v
>retrieving revision 1.30
>diff -u -r1.30 MWindowTest.java
>--- src/org/eclipse/e4/ui/tests/workbench/MWindowTest.java	22 Dec 2009 15:14:09 -0000	1.30
>+++ src/org/eclipse/e4/ui/tests/workbench/MWindowTest.java	8 Jan 2010 14:28:52 -0000
>@@ -16,6 +16,7 @@
> import org.eclipse.e4.core.services.IDisposable;
> import org.eclipse.e4.core.services.context.IEclipseContext;
> import org.eclipse.e4.core.services.context.spi.IContextConstants;
>+import org.eclipse.e4.ui.model.application.MApplication;
> import org.eclipse.e4.ui.model.application.MApplicationFactory;
> import org.eclipse.e4.ui.model.application.MMenu;
> import org.eclipse.e4.ui.model.application.MMenuItem;
>@@ -83,7 +84,14 @@
> 	public void testCreateWindow() {
> 		final MWindow window = MApplicationFactory.eINSTANCE.createWindow();
> 		window.setLabel("MyWindow");
>-		wb = new E4Workbench(window, appContext);
>+
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Widget topWidget = (Widget) window.getWidget();
>@@ -96,7 +104,14 @@
> 	public void testWindowVisibility() {
> 		final MWindow window = MApplicationFactory.eINSTANCE.createWindow();
> 		window.setLabel("MyWindow");
>-		wb = new E4Workbench(window, appContext);
>+
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Widget topWidget = (Widget) window.getWidget();
>@@ -117,7 +132,14 @@
> 		final MWindow window = MApplicationFactory.eINSTANCE.createWindow();
> 		window.setLabel("MyWindow");
> 		window.setVisible(false);
>-		wb = new E4Workbench(window, appContext);
>+
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Widget topWidget = (Widget) window.getWidget();
>@@ -130,7 +152,14 @@
> 
> 	public void testCreateView() {
> 		final MWindow window = createWindowWithOneView();
>-		wb = new E4Workbench(window, appContext);
>+
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Widget topWidget = (Widget) window.getWidget();
>@@ -160,7 +189,14 @@
> 
> 	public void testContextChildren() {
> 		final MWindow window = createWindowWithOneView();
>-		wb = new E4Workbench(window, appContext);
>+
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Widget topWidget = (Widget) window.getWidget();
>@@ -206,7 +242,14 @@
> 
> 	public void testCreateMenu() {
> 		final MWindow window = createWindowWithOneViewAndMenu();
>-		wb = new E4Workbench(window, appContext);
>+
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Widget topWidget = (Widget) window.getWidget();
>@@ -241,7 +284,13 @@
> 		final MWindow window = MApplicationFactory.eINSTANCE.createWindow();
> 		window.setLabel("windowName");
> 
>-		wb = new E4Workbench(window, appContext);
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Object widget = window.getWidget();
>@@ -262,7 +311,13 @@
> 		final MWindow window = MApplicationFactory.eINSTANCE.createWindow();
> 		window.setX(200);
> 
>-		wb = new E4Workbench(window, appContext);
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Object widget = window.getWidget();
>@@ -282,7 +337,13 @@
> 		final MWindow window = MApplicationFactory.eINSTANCE.createWindow();
> 		window.setY(200);
> 
>-		wb = new E4Workbench(window, appContext);
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Object widget = window.getWidget();
>@@ -302,7 +363,13 @@
> 		final MWindow window = MApplicationFactory.eINSTANCE.createWindow();
> 		window.setWidth(200);
> 
>-		wb = new E4Workbench(window, appContext);
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Object widget = window.getWidget();
>@@ -322,7 +389,13 @@
> 		final MWindow window = MApplicationFactory.eINSTANCE.createWindow();
> 		window.setHeight(200);
> 
>-		wb = new E4Workbench(window, appContext);
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		Object widget = window.getWidget();
>Index: src/org/eclipse/e4/ui/tests/workbench/PartRenderingEngineTests.java
>===================================================================
>RCS file: /cvsroot/eclipse/e4/org.eclipse.e4.ui/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/PartRenderingEngineTests.java,v
>retrieving revision 1.1
>diff -u -r1.1 PartRenderingEngineTests.java
>--- src/org/eclipse/e4/ui/tests/workbench/PartRenderingEngineTests.java	29 Dec 2009 17:46:36 -0000	1.1
>+++ src/org/eclipse/e4/ui/tests/workbench/PartRenderingEngineTests.java	8 Jan 2010 14:28:52 -0000
>@@ -15,6 +15,7 @@
> 
> import org.eclipse.e4.core.services.IDisposable;
> import org.eclipse.e4.core.services.context.IEclipseContext;
>+import org.eclipse.e4.ui.model.application.MApplication;
> import org.eclipse.e4.ui.model.application.MApplicationFactory;
> import org.eclipse.e4.ui.model.application.MPart;
> import org.eclipse.e4.ui.model.application.MPartSashContainer;
>@@ -50,7 +51,13 @@
> 
> 	public void testCreateView() {
> 		final MWindow window = createWindowWithOneView("Part Name");
>-		wb = new E4Workbench(window, appContext);
>+		MApplication application = MApplicationFactory.eINSTANCE
>+				.createApplication();
>+		application.getChildren().add(window);
>+		application.setContext(appContext);
>+		appContext.set(MApplication.class.getName(), application);
>+
>+		wb = new E4Workbench(application, appContext);
> 		wb.createAndRunUI(window);
> 
> 		MPartSashContainer container = (MPartSashContainer) window
>#P org.eclipse.e4.ui.workbench
>Index: src/org/eclipse/e4/workbench/modeling/EPartService.java
>===================================================================
>RCS file: /cvsroot/eclipse/e4/org.eclipse.e4.ui/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/workbench/modeling/EPartService.java,v
>retrieving revision 1.3
>diff -u -r1.3 EPartService.java
>--- src/org/eclipse/e4/workbench/modeling/EPartService.java	6 Jan 2010 15:48:11 -0000	1.3
>+++ src/org/eclipse/e4/workbench/modeling/EPartService.java	8 Jan 2010 14:28:54 -0000
>@@ -30,8 +30,6 @@
> 
> 	public boolean isPartVisible(MPart part);
> 
>-	// public MPart showPart(String id);
>-	//
>-	// public MPart showPart(MPart part);
>+	public MPart showPart(String id);
> 
> }
>Index: src/org/eclipse/e4/workbench/ui/internal/PartServiceImpl.java
>===================================================================
>RCS file: /cvsroot/eclipse/e4/org.eclipse.e4.ui/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/workbench/ui/internal/PartServiceImpl.java,v
>retrieving revision 1.7
>diff -u -r1.7 PartServiceImpl.java
>--- src/org/eclipse/e4/workbench/ui/internal/PartServiceImpl.java	6 Jan 2010 15:48:11 -0000	1.7
>+++ src/org/eclipse/e4/workbench/ui/internal/PartServiceImpl.java	8 Jan 2010 14:28:54 -0000
>@@ -17,15 +17,21 @@
> import org.eclipse.e4.core.services.annotations.Optional;
> import org.eclipse.e4.core.services.context.IEclipseContext;
> import org.eclipse.e4.core.services.context.spi.IContextConstants;
>+import org.eclipse.e4.ui.model.application.MApplication;
>+import org.eclipse.e4.ui.model.application.MApplicationFactory;
> import org.eclipse.e4.ui.model.application.MContext;
> import org.eclipse.e4.ui.model.application.MElementContainer;
> import org.eclipse.e4.ui.model.application.MPart;
>+import org.eclipse.e4.ui.model.application.MPartDescriptor;
>+import org.eclipse.e4.ui.model.application.MPartStack;
> import org.eclipse.e4.ui.model.application.MUIElement;
> import org.eclipse.e4.ui.model.application.MWindow;
> import org.eclipse.e4.ui.services.IServiceConstants;
> import org.eclipse.e4.ui.services.events.IEventBroker;
> import org.eclipse.e4.workbench.modeling.EPartService;
> import org.eclipse.e4.workbench.ui.UIEvents;
>+import org.eclipse.emf.ecore.EObject;
>+import org.eclipse.emf.ecore.util.EcoreUtil;
> import org.osgi.service.event.Event;
> import org.osgi.service.event.EventHandler;
> 
>@@ -47,6 +53,9 @@
> 				windowHandler);
> 	}
> 
>+	@Inject
>+	private MApplication application;
>+
> 	/**
> 	 * This is the specific implementation. TODO: generalize it
> 	 */
>@@ -228,4 +237,44 @@
> 		}
> 
> 	}
>+
>+	public MPart showPart(String id) {
>+		MPartDescriptor descriptorMatch = null;
>+		for (MPartDescriptor descriptor : application.getDescriptors()) {
>+			if (descriptor.getId().equals(id)) {
>+				descriptorMatch = descriptor;
>+				break;
>+			}
>+		}
>+
>+		if (descriptorMatch == null) {
>+			return null;
>+		}
>+		// 2) add a child under the parent
>+		// TBD only make a new one if multiple copies are allowed
>+
>+		// TBD here we just copy descriptor for convenience; better would be to have an utility
>+		// to make a part based on the descriptor.
>+		// Create the part based on the descriptor
>+		// MPart part = MApplicationFactory.eINSTANCE.createPart();
>+		// part.setURI(descriptor.getURI());
>+		// part.setLabel(descriptor.getLabel());
>+		MPart part = (MPart) EcoreUtil.copy((EObject) descriptorMatch);
>+
>+		// Wrap it in a stack - TBD - always?
>+		MPartStack stack = MApplicationFactory.eINSTANCE.createPartStack();
>+		stack.getChildren().add(part);
>+
>+		rootContainer.getChildren().add(stack);
>+		// 3) make it visible / active / re-layout
>+		// XXX part service somehow tied to a container window. After that fixed code will be:
>+		// partService.activate((MPart) copy);
>+		// but for now:
>+		// IEclipseContext parentContext = ((MContext)parent).getContext();
>+		// EPartService parentPartService = (EPartService)
>+		// parentContext.get(EPartService.class.getName());
>+		// parentPartService.activate(part);
>+		activate(part);
>+		return part;
>+	}
> }

Actions: View | Diff

Attachments on bug 295003: 153159 | 153273 | 153815 | 155410 | 155599 | 155880 | 156933 | 157181 | 157513 | 157542