Attachment 154639 Details for Bug 297930 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

Bug-297930.patch (text/plain), 1.36 KB, created by Ivan Furnadjiev

on 2009-12-17 03:48:14 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2009-12-17 03:48:14 EST

Size: 1.36 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt
>Index: src/org/eclipse/swt/widgets/Shell.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt/src/org/eclipse/swt/widgets/Shell.java,v
>retrieving revision 1.55
>diff -u -r1.55 Shell.java
>--- src/org/eclipse/swt/widgets/Shell.java	14 Dec 2009 16:51:15 -0000	1.55
>+++ src/org/eclipse/swt/widgets/Shell.java	16 Dec 2009 13:48:32 -0000
>@@ -163,8 +163,8 @@
>     createWidget();
>     setInitialSize();
>   }
>-  
>-  
>+
>+
>   /**
>    * Constructs a new instance of this class. This is equivalent
>    * to calling <code>Shell((Display) null)</code>.
>@@ -173,7 +173,7 @@
>    *    <li>ERROR_THREAD_INVALID_ACCESS - if not called from the thread that created the parent</li>
>    *    <li>ERROR_INVALID_SUBCLASS - if this class is not an allowed subclass</li>
>    * </ul>
>-   * 
>+   *
>    * @since 1.3
>    */
>   public Shell() {
>@@ -666,11 +666,10 @@
>    */
>   public void open() {
>     checkWidget();
>+    // Order of setActiveShell/bringToTop/setVisible is crucial
>+    display.setActiveShell( this );
>     bringToTop();
>-    // Order of setVisible/setActive is crucial: see isVisible-check in
>-    // Shell#setActive()
>     setVisible( true );
>-    display.setActiveShell( this );
>     if( !restoreFocus() && !traverseGroup( true ) ) {
>       setFocus();
>     }

Actions: View | Diff

Attachments on bug 297930: 154639