Attachment 152299 Details for Bug 294846 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

Bug-294846.patch (text/plain), 1.84 KB, created by Ivan Furnadjiev

on 2009-11-16 09:16:37 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2009-11-16 09:16:37 EST

Size: 1.84 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Shell.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Shell.js,v
>retrieving revision 1.12
>diff -u -r1.12 Shell.js
>--- js/org/eclipse/swt/widgets/Shell.js	13 Jul 2009 18:44:22 -0000	1.12
>+++ js/org/eclipse/swt/widgets/Shell.js	16 Nov 2009 14:15:08 -0000
>@@ -30,6 +30,10 @@
>     var req = org.eclipse.swt.Request.getInstance();
>     req.addEventListener( "send", this._onSend, this );
>     this.getCaptionBar().setWidth( "100%" );
>+    // [if] Listen for DOM event instead of qooxdoo event - see bug 294846.
>+    this.removeEventListener( "mousedown", this._onwindowmousedown );
>+    this.__onwindowmousedown
>+      = qx.lang.Function.bind( this._onwindowmousedown, this );
>   },
> 
>   statics : {
>@@ -133,6 +137,11 @@
>     this.removeEventListener( "keydown", this._onKeydown );
>     var req = org.eclipse.swt.Request.getInstance();
>     req.removeEventListener( "send", this._onSend, this );
>+    if( !qx.core.Object.inGlobalDispose() ) {
>+      qx.html.EventRegistration.removeEventListener( this.getElement(),
>+                                                     "mousedown",
>+                                                     this.__onwindowmousedown );
>+    }
>     this._activateListenerWidgets = null;
>   },
> 
>@@ -141,6 +150,13 @@
>   },
> 
>   members : {
>+    _applyElement : function( value, old ) {
>+      this.base( arguments, value, old );
>+      qx.html.EventRegistration.addEventListener( this.getElement(),
>+                                                  "mousedown",
>+                                                  this.__onwindowmousedown );
>+    },
>+    
>     setDefaultButton : function( value ) {
>       this._defaultButton = value;
>     },

Actions: View | Diff

Attachments on bug 294846: 152299