Attachment 151703 Details for Bug 294310 – fixes an invalid deletion in the index

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fixes an invalid deletion in the index

294310.txt (text/plain), 1.63 KB, created by Markus Schorn

on 2009-11-09 10:44:55 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Markus Schorn

Created: 2009-11-09 10:44:55 EST

Size: 1.63 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.cdt.core
>Index: parser/org/eclipse/cdt/internal/core/pdom/dom/cpp/PDOMCPPTemplateTemplateParameter.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/all/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/dom/cpp/PDOMCPPTemplateTemplateParameter.java,v
>retrieving revision 1.4.2.1
>diff -u -r1.4.2.1 PDOMCPPTemplateTemplateParameter.java
>--- parser/org/eclipse/cdt/internal/core/pdom/dom/cpp/PDOMCPPTemplateTemplateParameter.java	2 Jul 2009 09:03:03 -0000	1.4.2.1
>+++ parser/org/eclipse/cdt/internal/core/pdom/dom/cpp/PDOMCPPTemplateTemplateParameter.java	9 Nov 2009 15:47:40 -0000
>@@ -55,12 +55,8 @@
> 	private static final int MEMBERLIST = PDOMCPPBinding.RECORD_SIZE + 4;
> 	private static final int PARAMETERID= PDOMCPPBinding.RECORD_SIZE + 8;
> 	private static final int PARAMETERS= PDOMCPPBinding.RECORD_SIZE + 12;
>-
>-	/**
>-	 * The size in bytes of a PDOMCPPTemplateTypeParameter record in the database.
>-	 */
> 	@SuppressWarnings("hiding")
>-	protected static final int RECORD_SIZE = PDOMCPPBinding.RECORD_SIZE + 14;
>+	protected static final int RECORD_SIZE = PDOMCPPBinding.RECORD_SIZE + 16;
> 	
> 	private ICPPScope fUnknownScope;
> 	private int fCachedParamID= -1;
>@@ -239,10 +235,6 @@
> 			((PDOMNode) type).delete(linkage);
> 		}
> 		Database db= getDB();
>-		long valueRec= db.getRecPtr(record + DEFAULT_TYPE);
>-		if (valueRec != 0)
>-			db.getString(valueRec).delete();
>-
> 		long oldRec= db.getRecPtr(record + PARAMETERS);
> 		IPDOMCPPTemplateParameter[] oldParams= getTemplateParameters();
> 		if (oldRec != 0)

Flags:

mschorn.eclipse: iplog-

Actions: View | Diff

Attachments on bug 294310: 151703