Attachment 15149 Details for Bug 72507 – concurrent modification exception

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] concurrent modification exception

jdt-debug-core.patch (text/plain), 1.79 KB, created by Darin Wright

on 2004-10-13 17:50:51 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Darin Wright

Created: 2004-10-13 17:50:51 EDT

Size: 1.79 KB

patch

obsolete

>Index: model/org/eclipse/jdt/internal/debug/core/model/JDIThread.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.debug/model/org/eclipse/jdt/internal/debug/core/model/JDIThread.java,v
>retrieving revision 1.146
>diff -u -r1.146 JDIThread.java
>--- model/org/eclipse/jdt/internal/debug/core/model/JDIThread.java	29 Jun 2004 18:40:22 -0000	1.146
>+++ model/org/eclipse/jdt/internal/debug/core/model/JDIThread.java	13 Oct 2004 21:38:57 -0000
>@@ -2498,23 +2498,25 @@
> 		 */
> 		public IStatus run(IProgressMonitor monitor) {
> 			fJDIThread.fRunningAsyncJob= this;
>-			Vector runnables;
>+			Object[] runnables;
> 			synchronized (fRunnables) {
>-				runnables= fRunnables;
>+				runnables= fRunnables.toArray();
> 				fRunnables= new Vector(5);
> 			}
> 			
> 			MultiStatus failed = null;
>-			monitor.beginTask(this.getName(), runnables.size()); //$NON-NLS-1$
>-			for (Iterator iter= runnables.iterator(); iter.hasNext() && !fJDIThread.isTerminated() && !monitor.isCanceled();) {
>+			monitor.beginTask(this.getName(), runnables.length); //$NON-NLS-1$
>+			int i = 0;
>+			while (i < runnables.length && !fJDIThread.isTerminated() && !monitor.isCanceled()) {
> 				try {
>-					((Runnable) iter.next()).run();
>+					((Runnable) runnables[i]).run();
> 				} catch (Exception e) {
> 					if (failed == null) {
> 						failed = new MultiStatus(JDIDebugPlugin.getUniqueIdentifier(), JDIDebugPlugin.INTERNAL_ERROR, JDIDebugModelMessages.getString("JDIThread.0"), null); //$NON-NLS-1$
> 					}
> 					failed.add(new Status(IStatus.ERROR, JDIDebugPlugin.getUniqueIdentifier(), JDIDebugPlugin.INTERNAL_ERROR, JDIDebugModelMessages.getString("JDIThread.0"), e)); //$NON-NLS-1$
> 				}
>+				i++;
> 				monitor.worked(1);
> 			}
> 			fJDIThread.fRunningAsyncJob= null;

Actions: View | Diff

Attachments on bug 72507: 15148 | 15149 | 15153