Attachment 151118 Details for Bug 293867 – RWT patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] RWT patch

Bug-293867.patch (text/plain), 11.42 KB, created by Ivan Furnadjiev

on 2009-11-02 15:46:00 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2009-11-02 15:46:00 EST

Size: 11.42 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/DateTimeDate.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/DateTimeDate.js,v
>retrieving revision 1.25
>diff -u -r1.25 DateTimeDate.js
>--- js/org/eclipse/swt/widgets/DateTimeDate.js	7 Sep 2009 16:01:42 -0000	1.25
>+++ js/org/eclipse/swt/widgets/DateTimeDate.js	2 Nov 2009 20:44:33 -0000
>@@ -128,7 +128,7 @@
>     this._spinner.setMax( 12 );
>     this._spinner.setValue( this._monthInt );
>     this._spinner.addEventListener( "change",  this._onSpinnerChange, this );
>-    this._spinner._textfield.setTabIndex( -1 );
>+    this._spinner._textfield.setTabIndex( null );
>     // Hack to prevent the spinner text field to request the focus
>     this._spinner._textfield.setFocused = function() {};
>     // Solution for Bug 284021
>@@ -155,7 +155,7 @@
>       this.addEventListener( "mouseout", this._onMouseOut, this );
>       this._dropDownButton = new qx.ui.form.Button();
>       this._dropDownButton.setAppearance( "datetime-drop-down-button" );
>-      this._dropDownButton.setTabIndex( -1 );
>+      this._dropDownButton.setTabIndex( null );
>       this._dropDownButton.setAllowStretchY( true );
>       this.add( this._dropDownButton );
>       // Get names of weekdays and months
>@@ -164,7 +164,7 @@
>       this._calendar = new org.eclipse.swt.widgets.Calendar();
>       this._calendar.setAppearance( "datetime-drop-down-calendar" );
>       this._calendar.setDate( new Date( 70, 0, 1 ) );
>-      this._calendar.setTabIndex( -1 );
>+      this._calendar.setTabIndex( null );
>       this._calendar.setVisibility( false );
>       // TODO: [if] Calendar buttons tooltips have wrong z-index
>       // Remove tooltips for now.
>Index: js/org/eclipse/swt/widgets/List.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/List.js,v
>retrieving revision 1.16
>diff -u -r1.16 List.js
>--- js/org/eclipse/swt/widgets/List.js	23 Oct 2009 16:50:15 -0000	1.16
>+++ js/org/eclipse/swt/widgets/List.js	2 Nov 2009 20:44:34 -0000
>@@ -76,7 +76,7 @@
>           // prevent items from being drawn outside the list
>           item.setOverflow( qx.constant.Style.OVERFLOW_HIDDEN );
>           item.setContextMenu( this.getContextMenu() );
>-          item.setTabIndex( -1 );
>+          item.setTabIndex( null );
>           item.setLabel( "(empty)" );
>           item.getLabelObject().setMode( qx.constant.Style.LABEL_MODE_HTML );
>           item.setLabel( items[ i ] );
>Index: js/org/eclipse/swt/widgets/Calendar.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Calendar.js,v
>retrieving revision 1.16
>diff -u -r1.16 Calendar.js
>--- js/org/eclipse/swt/widgets/Calendar.js	7 Oct 2009 16:59:39 -0000	1.16
>+++ js/org/eclipse/swt/widgets/Calendar.js	2 Nov 2009 20:44:32 -0000
>@@ -71,28 +71,28 @@
>       show    : 'icon',
>       toolTip : this._lastYearBtToolTip,
>       spacing : 0,
>-      tabIndex: -1
>+      tabIndex: null
>     });
>     lastYearBt.setUserData( "calendar-button", true );
> 
>     lastMonthBt.set({
>       show    : 'icon',
>       toolTip : this._lastMonthBtToolTip,
>-      tabIndex: -1
>+      tabIndex: null
>     });
>     lastMonthBt.setUserData( "calendar-button", true );
> 
>     nextMonthBt.set({
>       show    : 'icon',
>       toolTip : this._nextMonthBtToolTip,
>-      tabIndex: -1
>+      tabIndex: null
>     });
>     nextMonthBt.setUserData( "calendar-button", true );
> 
>     nextYearBt.set({
>       show    : 'icon',
>       toolTip : this._nextYearBtToolTip,
>-      tabIndex: -1
>+      tabIndex: null
>     });
>     nextYearBt.setUserData( "calendar-button", true );
> 
>Index: js/org/eclipse/swt/widgets/DateTimeCalendar.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/DateTimeCalendar.js,v
>retrieving revision 1.13
>diff -u -r1.13 DateTimeCalendar.js
>--- js/org/eclipse/swt/widgets/DateTimeCalendar.js	7 Oct 2009 16:59:39 -0000	1.13
>+++ js/org/eclipse/swt/widgets/DateTimeCalendar.js	2 Nov 2009 20:44:33 -0000
>@@ -29,7 +29,7 @@
>     this._calendar = new org.eclipse.swt.widgets.Calendar();
>     this._calendar.addEventListener( "changeDate", this._onChangeDate, this );
>     this._calendar.setDate( new Date( 74, 5, 6 ) );
>-    this._calendar.setTabIndex( -1 );
>+    this._calendar.setTabIndex( null );
>     this.add( this._calendar );
>     
>     this.addEventListener( "contextmenu", this._onContextMenu, this );
>Index: js/org/eclipse/swt/widgets/DateTimeTime.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/DateTimeTime.js,v
>retrieving revision 1.20
>diff -u -r1.20 DateTimeTime.js
>--- js/org/eclipse/swt/widgets/DateTimeTime.js	1 Sep 2009 13:11:16 -0000	1.20
>+++ js/org/eclipse/swt/widgets/DateTimeTime.js	2 Nov 2009 20:44:33 -0000
>@@ -83,7 +83,7 @@
>     this._spinner.setMax( 23 );
>     this._spinner.setValue( 0 );
>     this._spinner.addEventListener( "change",  this._onSpinnerChange, this );
>-    this._spinner._textfield.setTabIndex( -1 );
>+    this._spinner._textfield.setTabIndex( null );
>     // Hack to prevent the spinner text field to request the focus
>     this._spinner._textfield.setFocused = function() {};
>     // Solution for Bug 284021
>Index: js/org/eclipse/swt/widgets/Combo.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Combo.js,v
>retrieving revision 1.34
>diff -u -r1.34 Combo.js
>--- js/org/eclipse/swt/widgets/Combo.js	29 Sep 2009 13:59:57 -0000	1.34
>+++ js/org/eclipse/swt/widgets/Combo.js	2 Nov 2009 20:44:33 -0000
>@@ -36,17 +36,17 @@
>     this._listItemHeight = "auto";
>     // Text field
>     this._field = new qx.ui.form.TextField();
>-    this._field.setTabIndex( -1 );
>+    this._field.setTabIndex( null );
>     this._field.setAllowStretchY( true );
>     this.add( this._field );
>     // Drop down button
>     this._button = new qx.ui.form.Button();
>-    this._button.setTabIndex( -1 );
>+    this._button.setTabIndex( null );
>     this._button.setAllowStretchY( true );
>     this.add( this._button );
>     // List
>     this._list = new qx.ui.form.List();
>-    this._list.setTabIndex( -1 );
>+    this._list.setTabIndex( null );
>     this._list.setDisplay( false );
>     this._list.setWidth( "auto" );
>     // List Manager
>Index: js/org/eclipse/swt/widgets/Spinner.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Spinner.js,v
>retrieving revision 1.12
>diff -u -r1.12 Spinner.js
>--- js/org/eclipse/swt/widgets/Spinner.js	28 Oct 2009 08:34:48 -0000	1.12
>+++ js/org/eclipse/swt/widgets/Spinner.js	2 Nov 2009 20:44:34 -0000
>@@ -25,7 +25,7 @@
>     this._textfield.addEventListener( "keyinput", this._onChangeValue, this );
>     this._textfield.addEventListener( "blur", this._onChangeValue, this );
>     this._textfield.addEventListener( "keydown", this._onKeyDown, this );
>-    this._textfield.setTabIndex( -1 );
>+    this._textfield.setTabIndex( null );
>     this.addEventListener( "changeEnabled", this._onChangeEnabled, this );
>   },
> 
>Index: js/org/eclipse/swt/widgets/Link.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Link.js,v
>retrieving revision 1.5
>diff -u -r1.5 Link.js
>--- js/org/eclipse/swt/widgets/Link.js	9 Oct 2009 14:50:09 -0000	1.5
>+++ js/org/eclipse/swt/widgets/Link.js	2 Nov 2009 20:44:34 -0000
>@@ -74,7 +74,7 @@
>     },
>     
>   	_onAppear : function( evt ) {
>-      this._link.setTabIndex( -1 );
>+      this._link.setTabIndex( null );
>       this._link.setHideFocus( true );
>       this._applyHyperlinksStyleProperties();
>       this._addEventListeners();
>@@ -139,7 +139,7 @@
>     applyText : function() {
>       this._link.setHtml( this._text );
>       if ( this._linksCount == 0 ) {
>-        this.setTabIndex( -1 );
>+        this.setTabIndex( null );
>       } else {
>         this.setTabIndex( 1 );
>       }
>Index: js/org/eclipse/swt/widgets/Slider.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Slider.js,v
>retrieving revision 1.9
>diff -u -r1.9 Slider.js
>--- js/org/eclipse/swt/widgets/Slider.js	28 Oct 2009 13:53:59 -0000	1.9
>+++ js/org/eclipse/swt/widgets/Slider.js	2 Nov 2009 20:44:34 -0000
>@@ -78,7 +78,7 @@
>     this._thumbOffset = 0;
>     // Min button
>     this._minButton = new qx.ui.form.Button();
>-    this._minButton.setTabIndex( -1 );
>+    this._minButton.setTabIndex( null );
>     if( this._horizontal ) {
>       this._minButton.addState( org.eclipse.swt.widgets.Slider.STATE_HORIZONTAL );
>     } else {
>@@ -100,7 +100,7 @@
>     this.add( this._minButton );
>     // Max button
>     this._maxButton = new qx.ui.form.Button();
>-    this._maxButton.setTabIndex( -1 );
>+    this._maxButton.setTabIndex( null );
>     if( this._horizontal ) {
>       this._maxButton.addState( org.eclipse.swt.widgets.Slider.STATE_HORIZONTAL );
>     } else {
>Index: js/org/eclipse/rwt/widgets/Button.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/rwt/widgets/Button.js,v
>retrieving revision 1.7
>diff -u -r1.7 Button.js
>--- js/org/eclipse/rwt/widgets/Button.js	28 Oct 2009 13:53:58 -0000	1.7
>+++ js/org/eclipse/rwt/widgets/Button.js	2 Nov 2009 20:44:32 -0000
>@@ -34,7 +34,7 @@
> 
>     tabIndex : {
>       refine : true,
>-      init : -1
>+      init : null
>     }
>         
>   },
>Index: js/org/eclipse/swt/TabUtil.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/TabUtil.js,v
>retrieving revision 1.4
>diff -u -r1.4 TabUtil.js
>--- js/org/eclipse/swt/TabUtil.js	13 Apr 2009 16:28:22 -0000	1.4
>+++ js/org/eclipse/swt/TabUtil.js	2 Nov 2009 20:44:32 -0000
>@@ -14,7 +14,7 @@
>   statics : {
>     createTabItem : function( id, parentId, index ) {
>       var tabButton = new qx.ui.pageview.tabview.Button();
>-      tabButton.setTabIndex( -1 );
>+      tabButton.setTabIndex( null );
>       tabButton.setLabel( "(empty)" );
>       tabButton.getLabelObject().setMode( "html" ); 
>       tabButton.setLabel( "" );
>Index: js/org/eclipse/swt/custom/CTabItem.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/custom/CTabItem.js,v
>retrieving revision 1.9
>diff -u -r1.9 CTabItem.js
>--- js/org/eclipse/swt/custom/CTabItem.js	23 Oct 2009 11:49:17 -0000	1.9
>+++ js/org/eclipse/swt/custom/CTabItem.js	2 Nov 2009 20:44:32 -0000
>@@ -23,7 +23,7 @@
>     this.setVerticalChildrenAlign( qx.constant.Layout.ALIGN_MIDDLE );
>     this.setHorizontalChildrenAlign( qx.constant.Layout.ALIGN_LEFT );
>     this.setOverflow( qx.constant.Style.OVERFLOW_HIDDEN );
>-    this.setTabIndex( -1 );
>+    this.setTabIndex( null );
>     // Set the label part to 'html mode'
>     this.setLabel( "(empty)" );
>     this.getLabelObject().setMode( qx.constant.Style.LABEL_MODE_HTML );

Actions: View | Diff

Attachments on bug 293867: 151117 | 151118