Attachment 149735 Details for Bug 287056 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

Bug-287056.patch (text/plain), 3.38 KB, created by Ivan Furnadjiev

on 2009-10-16 06:52:53 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2009-10-16 06:52:53 EDT

Size: 3.38 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Table.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Table.js,v
>retrieving revision 1.71
>diff -u -r1.71 Table.js
>--- js/org/eclipse/swt/widgets/Table.js	7 Oct 2009 16:23:50 -0000	1.71
>+++ js/org/eclipse/swt/widgets/Table.js	16 Oct 2009 10:16:36 -0000
>@@ -1219,6 +1219,11 @@
>           // Append rows if rowCount was increased
>           if( this._rows.length < newRowCount ) {
>             while( this._rows.length < newRowCount ) {
>+              var newRow = new org.eclipse.swt.widgets.TableRow();
>+              this._hookRowEventListener( newRow );
>+              newRow.setLinesVisible( this._linesVisible );
>+              this._clientArea.add( newRow );
>+              this._rows.push( newRow );
>               if( this._checkBoxes != null ) {
>                 var checkBox = new qx.ui.basic.Image();
>                 checkBox.addEventListener( "click", this._onCheckBoxClick, this );
>@@ -1232,11 +1237,6 @@
>                 this._clientArea.add( checkBox );
>                 this._checkBoxes.push( checkBox );
>               }
>-              var newRow = new org.eclipse.swt.widgets.TableRow();
>-              this._hookRowEventListener( newRow );
>-              newRow.setLinesVisible( this._linesVisible );
>-              this._clientArea.add( newRow );
>-              this._rows.push( newRow );
>             }
>           }
>           // Re-calculate the position and size for each row
>@@ -1299,8 +1299,8 @@
>           checkBox.setHeight( checkImageHeight );
>         }
>         var row = this._rows[ i ];
>-        row.setLeft( left + checkBoxWidth );
>-        row.setWidth( width );
>+        row.setLeft( left );
>+        row.setWidth( width + checkBoxWidth );
>         row.setHeight( this._itemHeight );
>       }
>     },
>Index: src/org/eclipse/swt/internal/widgets/tablekit/TableLCAUtil.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/src/org/eclipse/swt/internal/widgets/tablekit/TableLCAUtil.java,v
>retrieving revision 1.13
>diff -u -r1.13 TableLCAUtil.java
>--- src/org/eclipse/swt/internal/widgets/tablekit/TableLCAUtil.java	4 Jun 2009 11:48:56 -0000	1.13
>+++ src/org/eclipse/swt/internal/widgets/tablekit/TableLCAUtil.java	16 Oct 2009 10:16:36 -0000
>@@ -139,16 +139,17 @@
>         // If in column mode, cut image width if image exceeds right cell border
>         int imageWidth = tableAdapter.getItemImageWidth( i );
>         if( table.getColumnCount() > 0 ) {
>-          int maxImageWidth = bounds.width - ( ( imageBounds.x - checkWidth ) - bounds.x );
>+          int maxImageWidth
>+            = bounds.width - ( ( imageBounds.x - checkWidth ) - bounds.x );
>           if( imageWidth > maxImageWidth ) {
>             imageWidth = maxImageWidth;
>           }
>         }
>-        result[ i ].left = bounds.x - checkWidth;
>+        result[ i ].left = bounds.x;
>         result[ i ].width = bounds.width;
>-        result[ i ].imageLeft = imageBounds.x - checkWidth;
>+        result[ i ].imageLeft = imageBounds.x;
>         result[ i ].imageWidth = imageWidth;
>-        result[ i ].textLeft = textBounds.x - checkWidth;
>+        result[ i ].textLeft = textBounds.x;
>         result[ i ].textWidth = textBounds.width;
>       }
>     }

Actions: View | Diff

Attachments on bug 287056: 144952 | 146878 | 149735