Attachment 148138 Details for Bug 290555 – When modifying the filter, store and preserve the selection

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] When modifying the filter, store and preserve the selection

290555.patch (text/plain), 1.30 KB, created by Felix Velasco

on 2009-09-25 12:16:03 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Felix Velasco

Created: 2009-09-25 12:16:03 EDT

Size: 1.30 KB

patch

obsolete

>Index: org.eclipse.emf/plugins/org.eclipse.emf.common.ui/src/org/eclipse/emf/common/ui/celleditor/ExtendedComboBoxCellEditor.java
>===================================================================
>RCS file: /cvsroot/modeling/org.eclipse.emf/org.eclipse.emf/plugins/org.eclipse.emf.common.ui/src/org/eclipse/emf/common/ui/celleditor/ExtendedComboBoxCellEditor.java,v
>retrieving revision 1.8
>diff -u -4 -r1.8 ExtendedComboBoxCellEditor.java
>--- org.eclipse.emf/plugins/org.eclipse.emf.common.ui/src/org/eclipse/emf/common/ui/celleditor/ExtendedComboBoxCellEditor.java	22 Dec 2008 14:26:02 -0000	1.8
>+++ org.eclipse.emf/plugins/org.eclipse.emf.common.ui/src/org/eclipse/emf/common/ui/celleditor/ExtendedComboBoxCellEditor.java	25 Sep 2009 16:15:58 -0000
>@@ -211,11 +211,17 @@
>   {
>     CCombo combo = (CCombo)getControl();
>     if (combo != null && (!combo.isDisposed()))
>     {
>+      Object previousValue = getValue();
>       String[] items = createItems(list = new ArrayList<Object>(originalList), labelProvider, filter, sorted);
>       combo.setItems(items);
>-      if (items.length > 0)
>+      // If the previous value is valid, keep it selected
>+      if (list.contains(previousValue))
>+      {
>+        setValue(previousValue);
>+      }
>+      else if (items.length > 0)
>       {
>         combo.select(0);
>       }
>     }

Actions: View | Diff

Attachments on bug 290555: 148138 | 161110