Attachment 147987 Details for Bug 282837 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

Bug-282837.patch (text/plain), 1.90 KB, created by Jordan Yakovchev

on 2009-09-24 06:36:48 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jordan Yakovchev

Created: 2009-09-24 06:36:48 EDT

Size: 1.90 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/rwt/AsyncKeyEventUtil.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/rwt/AsyncKeyEventUtil.js,v
>retrieving revision 1.6
>diff -u -r1.6 AsyncKeyEventUtil.js
>--- js/org/eclipse/rwt/AsyncKeyEventUtil.js	4 Jun 2009 11:48:55 -0000	1.6
>+++ js/org/eclipse/rwt/AsyncKeyEventUtil.js	24 Sep 2009 10:38:22 -0000
>@@ -105,7 +105,7 @@
>           isTraverseKey = this._isTraverseKey( keyCode );
>         }
>         if( hasKeyListener || ( hasTraverseListener && isTraverseKey ) ) {
>-          if( !this._isUntrustedKey( control, keyCode ) ) {
>+          if( !this._isUntrustedKey( control, keyCode, domEvent ) ) {
>             if( this._keyEventRequestRunning || this._bufferedEvents.length > 0 )
>             {
>               this._bufferedEvents.push( this._getEventInfo( domEvent ) );
>@@ -158,14 +158,19 @@
>       return result;
>     },
> 
>-    _isUntrustedKey : function( control, keyCode ) {
>+    _isUntrustedKey : function( control, keyCode, domEvent  ) {
>       var result = false;
>       if( qx.core.Variant.isSet( "qx.client", "gecko" ) ) {
>-        if( control instanceof qx.ui.form.TextField ) {
>-          for( var i = 0; !result && i < this._untrustedKeyCodes.length; i++ ) {
>-          	if( this._untrustedKeyCodes[ i ] === keyCode ) {
>-          	  result = true;
>-          	}
>+        // Check for CTRL key fixes bug 282837
>+        if( domEvent.ctrlKey ) {
>+          result = true;
>+        } else {
>+          if( control instanceof qx.ui.form.TextField ) {
>+            for( var i = 0; !result && i < this._untrustedKeyCodes.length; i++ ) {
>+              if( this._untrustedKeyCodes[ i ] === keyCode ) {
>+                result = true;
>+              }
>+            }
>           }
>         }
>       }

Actions: View | Diff

Attachments on bug 282837: 147987