Attachment 147300 Details for Bug 289398 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

Bug289398-patch.txt (text/plain), 1.40 KB, created by Asen Draganov

on 2009-09-16 08:00:39 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Asen Draganov

Created: 2009-09-16 08:00:39 EDT

Size: 1.40 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Combo.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Combo.js,v
>retrieving revision 1.32
>diff -u -r1.32 Combo.js
>--- js/org/eclipse/swt/widgets/Combo.js	16 Sep 2009 09:37:47 -0000	1.32
>+++ js/org/eclipse/swt/widgets/Combo.js	16 Sep 2009 11:59:30 -0000
>@@ -33,6 +33,7 @@
>     this._borderWidth = 0;
>     this._selectionStart = 0;
>     this._selectionLength = 0;
>+    this._serverSelected = false;
>     this._listItemHeight = "auto";
>     // Text field
>     this._field = new qx.ui.form.TextField();
>@@ -353,7 +354,11 @@
>         var fieldValue = value.getLabel().toString();
>         this._field.setValue( this._formatText( fieldValue ) );
>         if( this._field.isCreated() ) {
>-          this._field.selectAll();
>+          if( !this._serverSelected ){
>+            this._field.selectAll();
>+          } else {
>+            this._serverSelected = false;
>+          }
>           if( !org_eclipse_rap_rwt_EventUtil_suspend ) {
>             this._handleSelectionChange();
>           }
>@@ -746,6 +751,7 @@
>       if( index >= 0 && index <= items.length - 1 ) {
>         item = items[ index ];
>       }
>+      this._serverSelected = true;
>       this._setSelected( item );
>     },
>

Actions: View | Diff

Attachments on bug 289398: 147143 | 147145 | 147300 | 147411