Attachment 147039 Details for Bug 289155 – other way for a patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] other way for a patch

patch_289155.txt (text/plain), 2.16 KB, created by Frank Becker

on 2009-09-12 03:58:58 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frank Becker

Created: 2009-09-12 03:58:58 EDT

Size: 2.16 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.bugzilla.core
>Index: src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaClient.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.core/src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaClient.java,v
>retrieving revision 1.194
>diff -u -r1.194 BugzillaClient.java
>--- src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaClient.java	12 Sep 2009 04:21:07 -0000	1.194
>+++ src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaClient.java	12 Sep 2009 07:54:14 -0000
>@@ -435,7 +435,13 @@
> 			authenticate(new SubProgressMonitor(monitor, 1));
> 			String queryUrl = query.getUrl();
> 			int start = queryUrl.indexOf('?');
>-
>+			BugzillaVersion bugzillaVersion;
>+			if (repositoryConfiguration != null) {
>+				bugzillaVersion = repositoryConfiguration.getInstallVersion();
>+			} else {
>+				bugzillaVersion = BugzillaVersion.MIN_VERSION;
>+			}
>+			boolean newNameForLongDesc = !(bugzillaVersion.compareMajorMinorOnly(BugzillaVersion.BUGZILLA_3_4) < 0);
> 			List<NameValuePair> pairs = new ArrayList<NameValuePair>();
> 			if (start != -1) {
> 				queryUrl = queryUrl.substring(start + 1);
>@@ -448,13 +454,14 @@
> 						} else if (nameValue.length == 2 && nameValue[0] != null && nameValue[1] != null) {
> 
> 							//Hack around bugzilla's change of attribute name for comment search field bug#289155
>-							if (nameValue[0].startsWith("long_desc")) {
>-								pairs.add(new NameValuePair(nameValue[0].replace("long_desc", "longdesc"),
>+							// This is for Bugzilla Versions >= 3.4
>+							if (newNameForLongDesc && nameValue[0].startsWith("long_desc")) { //$NON-NLS-1$
>+								pairs.add(new NameValuePair(nameValue[0].replace("long_desc", "longdesc"), //$NON-NLS-1$//$NON-NLS-2$
> 										URLDecoder.decode(nameValue[1].trim(), getCharacterEncoding())));
>+							} else {
>+								pairs.add(new NameValuePair(nameValue[0].trim(), URLDecoder.decode(nameValue[1].trim(),
>+										getCharacterEncoding())));
> 							}
>-
>-							pairs.add(new NameValuePair(nameValue[0].trim(), URLDecoder.decode(nameValue[1].trim(),
>-									getCharacterEncoding())));
> 						}
> 					}
> 				}

Actions: View | Diff

Attachments on bug 289155: 147012 | 147025 | 147028 | 147039 | 147040