Attachment 146600 Details for Bug 66889 – Suggested changes

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Suggested changes

patch66889 (text/plain), 3.52 KB, created by Semion Chichelnitsky

on 2009-09-07 08:52:54 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Semion Chichelnitsky

Created: 2009-09-07 08:52:54 EDT

Size: 3.52 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/presentations/PaneFolder.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/presentations/PaneFolder.java,v
>retrieving revision 1.45
>diff -u -r1.45 PaneFolder.java
>--- Eclipse UI/org/eclipse/ui/internal/presentations/PaneFolder.java	9 May 2008 14:13:15 -0000	1.45
>+++ Eclipse UI/org/eclipse/ui/internal/presentations/PaneFolder.java	7 Sep 2009 12:49:03 -0000
>@@ -13,7 +13,6 @@
> import java.util.ArrayList;
> import java.util.Iterator;
> import java.util.List;
>-
> import org.eclipse.jface.util.Geometry;
> import org.eclipse.swt.SWT;
> import org.eclipse.swt.custom.CTabFolder;
>@@ -329,7 +328,15 @@
>         topCenterCache.flush();
>         viewForm.changed(new Control[] {viewFormTopCenterProxy.getControl()});
>     }
>-    
>+
>+	/*
>+	 * @since 3.6
>+	 */
>+	public void flushTopLeftSize() {
>+		topLeftCache.flush();
>+		viewForm.changed(new Control[] { viewFormTopLeftProxy.getControl() });
>+	}
>+
>     /**
>      * Sets the top-center control (usually a toolbar), or null if none. Note
>      * that the control can have any parent.
>Index: Eclipse UI/org/eclipse/ui/internal/presentations/defaultpresentation/DefaultTabFolder.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/presentations/defaultpresentation/DefaultTabFolder.java,v
>retrieving revision 1.26
>diff -u -r1.26 DefaultTabFolder.java
>--- Eclipse UI/org/eclipse/ui/internal/presentations/defaultpresentation/DefaultTabFolder.java	25 May 2009 20:52:16 -0000	1.26
>+++ Eclipse UI/org/eclipse/ui/internal/presentations/defaultpresentation/DefaultTabFolder.java	7 Sep 2009 12:49:04 -0000
>@@ -298,25 +298,31 @@
>         }
>     }
> 
>-    /* (non-Javadoc)
>-     * @see org.eclipse.ui.internal.presentations.util.AbstractTabFolder#setSelectedInfo(org.eclipse.ui.internal.presentations.util.PartInfo)
>-     */
>-    public void setSelectedInfo(PartInfo info) {
>-        String newTitle = DefaultTabItem.escapeAmpersands(info.contentDescription);
>-        
>-        if (!Util.equals(titleLabel.getText(), newTitle)) {
>-            titleLabel.setText(newTitle);
>-            titleLabel.setToolTipText(newTitle);
>-        }
>-    	
>-        if (!info.contentDescription.equals(Util.ZERO_LENGTH_STRING)) {
>-            paneFolder.setTopLeft(titleLabel);
>-            titleLabel.setVisible(true);
>-        } else {
>-            paneFolder.setTopLeft(null);
>-            titleLabel.setVisible(false);
>-        }
>-    }
>+	/*
>+	 * (non-Javadoc)
>+	 * 
>+	 * @see
>+	 * org.eclipse.ui.internal.presentations.util.AbstractTabFolder#setSelectedInfo
>+	 * (org.eclipse.ui.internal.presentations.util.PartInfo)
>+	 */
>+	public void setSelectedInfo(PartInfo info) {
>+		String newTitle = DefaultTabItem
>+				.escapeAmpersands(info.contentDescription);
>+
>+		if (!Util.equals(titleLabel.getText(), newTitle)) {
>+			titleLabel.setText(newTitle);
>+			titleLabel.setToolTipText(newTitle);
>+		}
>+
>+		if (!info.contentDescription.equals(Util.ZERO_LENGTH_STRING)) {
>+			paneFolder.flushTopLeftSize();
>+			paneFolder.setTopLeft(titleLabel);
>+			titleLabel.setVisible(true);
>+		} else {
>+			paneFolder.setTopLeft(null);
>+			titleLabel.setVisible(false);
>+		}
>+	}
> 
>     /* (non-Javadoc)
>      * @see org.eclipse.ui.internal.presentations.util.AbstractTabFolder#getPaneMenuLocation()

Flags:

ob1.eclipse: iplog+

Actions: View | Diff

Attachments on bug 66889: 146600