Attachment 146389 Details for Bug 237775 – Bug Fix Patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Bug Fix Patch

defect237775.patch (text/plain), 2.23 KB, created by Aidyl Kareh

on 2009-09-03 09:40:03 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aidyl Kareh

Created: 2009-09-03 09:40:03 EDT

Size: 2.23 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jst.jsp.ui
>Index: src/org/eclipse/jst/jsp/ui/internal/contentassist/AutoImportProposal.java
>===================================================================
>RCS file: /cvsroot/webtools/sourceediting/plugins/org.eclipse.jst.jsp.ui/src/org/eclipse/jst/jsp/ui/internal/contentassist/AutoImportProposal.java,v
>retrieving revision 1.6
>diff -u -r1.6 AutoImportProposal.java
>--- src/org/eclipse/jst/jsp/ui/internal/contentassist/AutoImportProposal.java	6 Nov 2007 11:35:10 -0000	1.6
>+++ src/org/eclipse/jst/jsp/ui/internal/contentassist/AutoImportProposal.java	2 Sep 2009 18:17:12 -0000
>@@ -190,7 +190,7 @@
> 				closing = "\"%>"; //$NON-NLS-1$
> 			}
> 		}
>-		return delim + opening + getImportDeclaration() + closing;
>+		return opening + getImportDeclaration() + closing + delim;
> 	}
> 
> 	public String getImportDeclaration() {
>Index: src/org/eclipse/jst/jsp/ui/internal/contentassist/JSPProposalCollector.java
>===================================================================
>RCS file: /cvsroot/webtools/sourceediting/plugins/org.eclipse.jst.jsp.ui/src/org/eclipse/jst/jsp/ui/internal/contentassist/JSPProposalCollector.java,v
>retrieving revision 1.16
>diff -u -r1.16 JSPProposalCollector.java
>--- src/org/eclipse/jst/jsp/ui/internal/contentassist/JSPProposalCollector.java	1 Sep 2009 19:58:32 -0000	1.16
>+++ src/org/eclipse/jst/jsp/ui/internal/contentassist/JSPProposalCollector.java	2 Sep 2009 18:17:12 -0000
>@@ -90,7 +90,7 @@
> 			if(proposal.getKind() == CompletionProposal.TYPE_REF) {
> 				String signature = String.valueOf(proposal.getDeclarationSignature());
> 				String completion = String.valueOf(proposal.getCompletion());
>-				if(completion.indexOf(signature) != -1) {
>+				if(completion.indexOf(signature + ".") != -1) {
> 					jspProposal = createAutoImportProposal(proposal);			
> 				}
> 			}
>@@ -114,7 +114,7 @@
> 		// it's fully qualified so we should
> 		// add an import statement
> 		// create an autoimport proposal
>-		String newCompletion = completion.replaceAll(signature + ".", ""); //$NON-NLS-1$ //$NON-NLS-2$
>+		String newCompletion = completion.replaceAll(signature + "\\.", ""); //$NON-NLS-1$ //$NON-NLS-2$
> 		
> 		// java offset
> 		int offset = proposal.getReplaceStart();

Flags:

nsand.dev: iplog+
nsand.dev: review+

Actions: View | Diff

Attachments on bug 237775: 146389