Attachment 146268 Details for Bug 279334 – Here's a version with better layout

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Here's a version with better layout

clipboard.txt (text/plain), 2.45 KB, created by Pawel Niewiadomski

on 2009-09-02 06:22:02 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Pawel Niewiadomski

Created: 2009-09-02 06:22:02 EDT

Size: 2.45 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.tasks.ui
>Index: src/org/eclipse/mylyn/internal/tasks/ui/editors/CheckboxMultiSelectAttributeEditor.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/CheckboxMultiSelectAttributeEditor.java,v
>retrieving revision 1.1
>diff -u -r1.1 CheckboxMultiSelectAttributeEditor.java
>--- src/org/eclipse/mylyn/internal/tasks/ui/editors/CheckboxMultiSelectAttributeEditor.java	27 Aug 2009 22:09:48 -0000	1.1
>+++ src/org/eclipse/mylyn/internal/tasks/ui/editors/CheckboxMultiSelectAttributeEditor.java	2 Sep 2009 10:23:30 -0000
>@@ -11,6 +11,7 @@
> package org.eclipse.mylyn.internal.tasks.ui.editors;
> 
> import java.util.Collections;
>+import java.util.HashSet;
> import java.util.List;
> import java.util.Map;
> 
>@@ -43,6 +44,8 @@
> 
> 	private Text valueText;
> 
>+	private Composite parent;
>+
> 	public CheckboxMultiSelectAttributeEditor(TaskDataModel manager, TaskAttribute taskAttribute) {
> 		super(manager, taskAttribute);
> 		setLayoutHint(new LayoutHint(RowSpan.SINGLE, ColumnSpan.MULTIPLE));
>@@ -50,12 +53,14 @@
> 
> 	@Override
> 	public void createControl(Composite parent, FormToolkit toolkit) {
>+		this.parent = parent;
>+
> 		Composite composite = toolkit.createComposite(parent);
> 		GridLayout layout = new GridLayout(2, false);
> 		layout.marginWidth = 1;
> 		composite.setLayout(layout);
> 
>-		valueText = toolkit.createText(composite, "", SWT.FLAT); //$NON-NLS-1$
>+		valueText = toolkit.createText(composite, "", SWT.FLAT | SWT.WRAP); //$NON-NLS-1$
> 		valueText.setFont(EditorUtil.TEXT_FONT);
> 
> 		GridData gd = new GridData(GridData.FILL_HORIZONTAL);
>@@ -84,9 +89,11 @@
> 
> 				List<String> newValues = selectionDialog.getSelectedValues();
> 				if (responseCode == Window.OK && values != null) {
>-					setValues(newValues);
>-					attributeChanged();
>-					updateText();
>+					if (!new HashSet<String>(getValues()).equals(new HashSet<String>(newValues))) {
>+						setValues(newValues);
>+						attributeChanged();
>+						updateText();
>+					}
> 				} else {
> 					return;
> 				}
>@@ -111,6 +118,11 @@
> 				}
> 			}
> 			valueText.setText(valueString.toString());
>+			if (valueText != null && parent != null && parent.getParent() != null
>+					&& parent.getParent().getParent() != null) {
>+				valueText.setSize(valueText.computeSize(valueText.getSize().x, SWT.DEFAULT));
>+				parent.getParent().getParent().layout(true, true);
>+			}
> 		}
> 	}
>

Actions: View | Diff

Attachments on bug 279334: 138459 | 145867 | 145869 | 146268 | 149063