Attachment 146144 Details for Bug 288175 – updated minimal fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] updated minimal fix

clipboard.txt (text/plain), 3.07 KB, created by Steffen Pingel

on 2009-09-01 00:45:37 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Steffen Pingel

Created: 2009-09-01 00:45:37 EDT

Size: 3.07 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.bugzilla.core
>Index: src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaRepositoryConnector.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.core/src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaRepositoryConnector.java,v
>retrieving revision 1.166
>diff -u -r1.166 BugzillaRepositoryConnector.java
>--- src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaRepositoryConnector.java	20 Aug 2009 20:35:44 -0000	1.166
>+++ src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaRepositoryConnector.java	1 Sep 2009 04:45:14 -0000
>@@ -34,6 +34,7 @@
> import org.eclipse.core.runtime.SubProgressMonitor;
> import org.eclipse.mylyn.commons.core.StatusHandler;
> import org.eclipse.mylyn.commons.net.Policy;
>+import org.eclipse.mylyn.internal.tasks.core.AbstractTask;
> import org.eclipse.mylyn.internal.tasks.core.RepositoryQuery;
> import org.eclipse.mylyn.tasks.core.AbstractRepositoryConnector;
> import org.eclipse.mylyn.tasks.core.IRepositoryQuery;
>@@ -211,7 +212,8 @@
> 			String urlQueryBase = repository.getRepositoryUrl() + CHANGED_BUGS_CGI_QUERY
> 					+ URLEncoder.encode(dateString, repository.getCharacterEncoding()) + CHANGED_BUGS_CGI_ENDDATE;
> 
>-			String urlQueryString = urlQueryBase + BUG_ID;
>+			StringBuilder urlQueryString = new StringBuilder(Math.min(30 + 9 * session.getTasks().size(), 7009));
>+			urlQueryString.append(urlQueryBase + BUG_ID);
> 
> 			Set<ITask> changedTasks = new HashSet<ITask>();
> 			Iterator<ITask> itr = session.getTasks().iterator();
>@@ -221,20 +223,19 @@
> 				ITask task = itr.next();
> 				checking.add(task);
> 				queryCounter++;
>-				String newurlQueryString = URLEncoder.encode(task.getTaskId() + ",", repository.getCharacterEncoding()); //$NON-NLS-1$
>-				urlQueryString += newurlQueryString;
>-				if (queryCounter >= 1000) {
>-					queryForChanged(repository, changedTasks, urlQueryString, session, new SubProgressMonitor(monitor,
>-							queryCounter));
>+				urlQueryString.append(URLEncoder.encode(task.getTaskId() + ",", repository.getCharacterEncoding())); //$NON-NLS-1$
>+				if (urlQueryString.length() >= 7000) {
>+					queryForChanged(repository, changedTasks, urlQueryString.toString(), session,
>+							new SubProgressMonitor(monitor, queryCounter));
> 
> 					queryCounter = 0;
>-					urlQueryString = urlQueryBase + BUG_ID;
>-					newurlQueryString = ""; //$NON-NLS-1$
>+					urlQueryString.setLength(0);
>+					urlQueryString.append(urlQueryBase + BUG_ID);
> 				}
> 
> 				if (!itr.hasNext() && queryCounter != 0) {
>-					queryForChanged(repository, changedTasks, urlQueryString, session, new SubProgressMonitor(monitor,
>-							queryCounter));
>+					queryForChanged(repository, changedTasks, urlQueryString.toString(), session,
>+							new SubProgressMonitor(monitor, queryCounter));
> 				}
> 			}
> 
>@@ -275,7 +276,7 @@
> 				changedTasks.add(changedTask);
> 			}
> 		}
>-		if (collector.getQueryTimestamp() != null) {
>+		if (syncSession.getData() == null && collector.getQueryTimestamp() != null) {
> 			syncSession.setData(collector.getQueryTimestamp());
> 		}
>

Actions: View | Diff

Attachments on bug 288175: 146124 | 146125 | 146140 | 146141 | 146144 | 146145