Attachment 145754 Details for Bug 233757 – show versions in reverse order like JIRA does

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] show versions in reverse order like JIRA does

Show versions in reverse order like JIRA does.txt (text/plain), 1.69 KB, created by Jacek Jaroczynski

on 2009-08-27 02:14:49 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jacek Jaroczynski

Created: 2009-08-27 02:14:49 EDT

Size: 1.69 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.jira.core
>Index: src/org/eclipse/mylyn/internal/jira/core/service/JiraClient.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.jira.core/src/org/eclipse/mylyn/internal/jira/core/service/JiraClient.java,v
>retrieving revision 1.41
>diff -u -r1.41 JiraClient.java
>--- src/org/eclipse/mylyn/internal/jira/core/service/JiraClient.java	24 Jul 2009 12:04:22 -0000	1.41
>+++ src/org/eclipse/mylyn/internal/jira/core/service/JiraClient.java	26 Aug 2009 14:22:12 -0000
>@@ -14,6 +14,10 @@
> 
> import java.io.File;
> import java.io.OutputStream;
>+import java.util.Arrays;
>+import java.util.Collections;
>+import java.util.Comparator;
>+import java.util.List;
> 
> import org.apache.commons.httpclient.methods.multipart.PartSource;
> import org.eclipse.core.runtime.Assert;
>@@ -389,8 +393,25 @@
> 		return (credentials != null) ? credentials.getUserName() : ""; //$NON-NLS-1$
> 	}
> 
>+	/**
>+	 * Returns sorted list of versions in descended order (the same as JIRA presents)
>+	 * 
>+	 * @param key
>+	 * @param monitor
>+	 * @return
>+	 * @throws JiraException
>+	 */
> 	public Version[] getVersions(String key, IProgressMonitor monitor) throws JiraException {
>-		return soapClient.getVersions(key, monitor);
>+
>+		List<Version> versions = Arrays.asList(soapClient.getVersions(key, monitor));
>+
>+		Collections.sort(versions, new Comparator<Version>() {
>+			public int compare(Version o1, Version o2) {
>+				return o1.getSequence() > o2.getSequence() ? -1 : (o1.getSequence() == o2.getSequence() ? 0 : 1);
>+			}
>+		});
>+
>+		return versions.toArray(new Version[0]);
> 	}
> 
> 	@Override

Actions: View | Diff

Attachments on bug 233757: 145754 | 145858 | 145920 | 145921