Attachment 145650 Details for Bug 287672 – Fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix

MenuOpt.txt (text/plain), 1.66 KB, created by Tim Buschtoens

on 2009-08-26 05:43:40 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Buschtoens

Created: 2009-08-26 05:43:40 EDT

Size: 1.66 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/rwt/widgets/Menu.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/rwt/widgets/Menu.js,v
>retrieving revision 1.1
>diff -u -r1.1 Menu.js
>--- js/org/eclipse/rwt/widgets/Menu.js	25 Aug 2009 12:55:40 -0000	1.1
>+++ js/org/eclipse/rwt/widgets/Menu.js	26 Aug 2009 09:45:37 -0000
>@@ -106,8 +106,10 @@
>     _layoutPost : function( changes ) {
>       this.base( arguments );
>       if( changes.menuLayout ) {
>-        this._menuLayoutScheduled = false;        
>-        this._afterAppear(); // recomputes the location
>+        this._menuLayoutScheduled = false;
>+        if( this.isSeeable() ) {        
>+          this._afterAppear(); // recomputes the location
>+        }
>       }
>     },
>        
>Index: js/org/eclipse/rwt/widgets/MenuItem.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/rwt/widgets/MenuItem.js,v
>retrieving revision 1.1
>diff -u -r1.1 MenuItem.js
>--- js/org/eclipse/rwt/widgets/MenuItem.js	25 Aug 2009 12:55:40 -0000	1.1
>+++ js/org/eclipse/rwt/widgets/MenuItem.js	26 Aug 2009 09:45:37 -0000
>@@ -123,7 +123,8 @@
>       var width = value ? value[ 1 ] : 0;
>       var height = value ? value[ 2 ] : 0;
>       if( url == null ) {
>-        this.setCellContent( 0, "" );
>+        var content = this._isSelectable ? "" : null;          
>+        this.setCellContent( 0, content );
>       } else {
>         this.setCellContent( 0, url );
>       }

Actions: View | Diff

Attachments on bug 287672: 145650