Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 145121 Details for
Bug 286902
[List] Make border for focused item themable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read
this important communication.
[patch]
Proposed patch
List.outline.patch (text/plain), 7.32 KB, created by
Ivan Furnadjiev
on 2009-08-20 08:55:02 EDT
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Ivan Furnadjiev
Created:
2009-08-20 08:55:02 EDT
Size:
7.32 KB
patch
obsolete
>### Eclipse Workspace Patch 1.0 >#P org.eclipse.rap.rwt.q07 >Index: js/org/eclipse/swt/widgets/List.js >=================================================================== >RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/List.js,v >retrieving revision 1.12 >diff -u -r1.12 List.js >--- js/org/eclipse/swt/widgets/List.js 10 Aug 2009 19:51:09 -0000 1.12 >+++ js/org/eclipse/swt/widgets/List.js 20 Aug 2009 12:39:10 -0000 >@@ -67,7 +67,7 @@ > } else { > // TODO [rh] optimize this: context menu should be handled by the List > // itself for all its ListItems >- var item = new qx.ui.form.ListItem(); >+ var item = new org.eclipse.swt.widgets.ListItem(); > // prevent items from being drawn outside the list > item.setOverflow( qx.constant.Style.OVERFLOW_HIDDEN ); > item.setContextMenu( this.getContextMenu() ); >Index: src/org/eclipse/swt/internal/widgets/displaykit/QooxdooResourcesUtil.java >=================================================================== >RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/src/org/eclipse/swt/internal/widgets/displaykit/QooxdooResourcesUtil.java,v >retrieving revision 1.20 >diff -u -r1.20 QooxdooResourcesUtil.java >--- src/org/eclipse/swt/internal/widgets/displaykit/QooxdooResourcesUtil.java 3 Aug 2009 20:15:40 -0000 1.20 >+++ src/org/eclipse/swt/internal/widgets/displaykit/QooxdooResourcesUtil.java 20 Aug 2009 12:39:10 -0000 >@@ -77,6 +77,8 @@ > = "org/eclipse/swt/widgets/CoolItem.js"; > private static final String LIST_JS > = "org/eclipse/swt/widgets/List.js"; >+ private static final String LIST_ITEM_JS >+ = "org/eclipse/swt/widgets/ListItem.js"; > private static final String SHELL_JS > = "org/eclipse/swt/widgets/Shell.js"; > private static final String TREE_JS >@@ -202,6 +204,7 @@ > register( CTAB_FOLDER_JS, compress ); > register( COOL_ITEM_JS, compress ); > register( LIST_JS, compress ); >+ register( LIST_ITEM_JS, compress ); > register( SHELL_JS, compress ); > register( TREE_JS, compress ); > register( TREE_ITEM_JS, compress ); >@@ -237,7 +240,7 @@ > register( HTMLUTIL_JS, compress ); > register( MULTICELLWIDGET, compress ); > register( BUTTON, compress ); >- >+ > // register contributions > registerContributions(); > } finally { >Index: js/org/eclipse/swt/theme/AppearancesBase.js >=================================================================== >RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/theme/AppearancesBase.js,v >retrieving revision 1.125 >diff -u -r1.125 AppearancesBase.js >--- js/org/eclipse/swt/theme/AppearancesBase.js 12 Aug 2009 08:25:04 -0000 1.125 >+++ js/org/eclipse/swt/theme/AppearancesBase.js 20 Aug 2009 12:39:10 -0000 >@@ -661,6 +661,11 @@ > result.textColor = tv.getCssColor( "List-Item", "color" ); > } > result.backgroundColor = tv.getCssColor( "List-Item", "background-color" ); >+ var outline = tv.getCssBorder( "List-Item", "outline" ); >+ result.outline = outline.getWidthTop() + "px " + outline.getStyleTop(); >+ if( outline.getColorTop() != null ) { >+ result.outline += " " + outline.getColorTop(); >+ } > return result; > } > }, >Index: js/org/eclipse/swt/widgets/ListItem.js >=================================================================== >RCS file: js/org/eclipse/swt/widgets/ListItem.js >diff -N js/org/eclipse/swt/widgets/ListItem.js >--- /dev/null 1 Jan 1970 00:00:00 -0000 >+++ js/org/eclipse/swt/widgets/ListItem.js 1 Jan 1970 00:00:00 -0000 >@@ -0,0 +1,46 @@ >+/******************************************************************************* >+ * Copyright (c) 2009 EclipseSource and others. All rights reserved. >+ * This program and the accompanying materials are made available under the >+ * terms of the Eclipse Public License v1.0 which accompanies this distribution, >+ * and is available at http://www.eclipse.org/legal/epl-v10.html >+ * >+ * Contributors: >+ * EclipseSource - initial API and implementation >+ ******************************************************************************/ >+ >+/** >+ * This class provides the client-side counterpart for >+ * org.eclipse.swt.widgets.ListItem. >+ */ >+qx.Class.define( "org.eclipse.swt.widgets.ListItem", { >+ extend : qx.ui.form.ListItem, >+ >+ properties : { >+ >+ outline : { >+ check : "String", >+ themeable : true, >+ nullable : false, >+ apply : "_applyOutline", >+ init : "1px dotted" >+ } >+ >+ }, >+ >+ members : { >+ >+ _applyOutline : function( value ) { >+ this.handleStateChange(); >+ }, >+ >+ handleStateChange : function() { >+ if( this.hasState( "lead" ) ) { >+ this.setStyleProperty( "outline", this.getOutline() ); >+ } else { >+ this.setStyleProperty("outline", "0px none"); >+ } >+ } >+ >+ } >+ >+} ); >\ No newline at end of file >#P org.eclipse.rap.rwt >Index: src/org/eclipse/rwt/internal/theme/css/PropertyResolver.java >=================================================================== >RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt/src/org/eclipse/rwt/internal/theme/css/PropertyResolver.java,v >retrieving revision 1.10 >diff -u -r1.10 PropertyResolver.java >--- src/org/eclipse/rwt/internal/theme/css/PropertyResolver.java 6 Jul 2009 10:30:08 -0000 1.10 >+++ src/org/eclipse/rwt/internal/theme/css/PropertyResolver.java 20 Aug 2009 12:39:17 -0000 >@@ -157,7 +157,8 @@ > result = ThemeDefinitionReader.TYPE_COLOR; > } else if( "font".equals( property ) ) { > result = ThemeDefinitionReader.TYPE_FONT; >- } else if( "border".equals( property ) ) { >+ } else if( "border".equals( property ) >+ || "outline".equals( property ) ) { > result = ThemeDefinitionReader.TYPE_BORDER; > } else if( "spacing".equals( property ) > || "width".equals( property ) >Index: src/org/eclipse/swt/internal/widgets/listkit/List.theme.xml >=================================================================== >RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt/src/org/eclipse/swt/internal/widgets/listkit/List.theme.xml,v >retrieving revision 1.18 >diff -u -r1.18 List.theme.xml >--- src/org/eclipse/swt/internal/widgets/listkit/List.theme.xml 4 Jun 2009 11:48:51 -0000 1.18 >+++ src/org/eclipse/swt/internal/widgets/listkit/List.theme.xml 20 Aug 2009 12:39:17 -0000 >@@ -48,6 +48,10 @@ > <property name="background-color" > type="color" > description="Background color for list items." /> >+ >+ <property name="outline" >+ type="border" >+ description="Outline around the focused list item." /> > > <state name="selected" > description="Applies to selected items." /> >Index: src/org/eclipse/swt/internal/widgets/listkit/List.default.css >=================================================================== >RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt/src/org/eclipse/swt/internal/widgets/listkit/List.default.css,v >retrieving revision 1.6 >diff -u -r1.6 List.default.css >--- src/org/eclipse/swt/internal/widgets/listkit/List.default.css 13 May 2009 19:34:04 -0000 1.6 >+++ src/org/eclipse/swt/internal/widgets/listkit/List.default.css 20 Aug 2009 12:39:17 -0000 >@@ -13,6 +13,7 @@ > List-Item { > background-color: transparent; > color: black; >+ outline: 1px dotted; > } > > List-Item:selected {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 286902
: 145121