Attachment 144937 Details for Bug 163769 – Patch v01

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch v01

OverviewRuler 01.txt (text/plain), 1.37 KB, created by Prakash Rangaraj

on 2009-08-19 06:56:48 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Prakash Rangaraj

Created: 2009-08-19 06:56:48 EDT

Size: 1.37 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jface.text
>Index: src/org/eclipse/jface/text/source/OverviewRuler.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.text/src/org/eclipse/jface/text/source/OverviewRuler.java,v
>retrieving revision 1.69
>diff -u -r1.69 OverviewRuler.java
>--- src/org/eclipse/jface/text/source/OverviewRuler.java	10 Oct 2008 14:22:59 -0000	1.69
>+++ src/org/eclipse/jface/text/source/OverviewRuler.java	19 Aug 2009 10:24:39 -0000
>@@ -850,8 +850,18 @@
> 		int pixel1= Math.min(rulerLength, y_coordinate + 1);
> 		rulerLength= Math.max(rulerLength, 1);
> 
>-		lines[0]= (pixel0 * maxLines) / rulerLength;
>-		lines[1]= (pixel1 * maxLines) / rulerLength;
>+		// if the ruler is very big, rounding off is heavy
>+		if(rulerLength > maxLines){
>+			lines[0]= (int)(pixel0 * (maxLines / (double)rulerLength));
>+			lines[1]= (int)(pixel1 * (maxLines / (double)rulerLength));
>+		}else{
>+			lines[0]= pixel0 * (maxLines / rulerLength);
>+			lines[1]= pixel1 * (maxLines / rulerLength);
>+		}
>+		
>+		// hit test should be only for the annotation height - not for the entire line length
>+		if(y_coordinate > (((lines[0]* rulerLength)/maxLines) + fAnnotationHeight))
>+			return new int[] {-1, -1};
> 
> 		if (fTextViewer instanceof ITextViewerExtension5) {
> 			ITextViewerExtension5 extension= (ITextViewerExtension5) fTextViewer;

Actions: View | Diff

Attachments on bug 163769: 72050 | 143870 | 144937 | 146934 | 150218 | 150219 | 150488 | 186620 | 186622 | 186755