Attachment 143966 Details for Bug 280811 – fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix

clipboard.txt (text/plain), 2.40 KB, created by Steffen Pingel

on 2009-08-10 17:02:26 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Steffen Pingel

Created: 2009-08-10 17:02:26 EDT

Size: 2.40 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.tasks.ui
>Index: src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorSummaryPart.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorSummaryPart.java,v
>retrieving revision 1.38.2.1
>diff -u -r1.38.2.1 TaskEditorSummaryPart.java
>--- src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorSummaryPart.java	10 Aug 2009 20:44:05 -0000	1.38.2.1
>+++ src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorSummaryPart.java	10 Aug 2009 21:04:50 -0000
>@@ -13,6 +13,7 @@
> package org.eclipse.mylyn.internal.tasks.ui.editors;
> 
> import org.eclipse.jface.layout.GridDataFactory;
>+import org.eclipse.jface.layout.GridLayoutFactory;
> import org.eclipse.mylyn.internal.provisional.commons.ui.CommonImages;
> import org.eclipse.mylyn.internal.tasks.ui.util.TasksUiInternal;
> import org.eclipse.mylyn.tasks.core.ITaskMapping;
>@@ -121,15 +122,21 @@
> 	private void addSummaryText(Composite composite, final FormToolkit toolkit) {
> 		summaryEditor = createAttributeEditor(getTaskData().getRoot().getMappedAttribute(TaskAttribute.SUMMARY));
> 		if (summaryEditor != null) {
>-			// create composite to hold rounded border
> 			if (summaryEditor instanceof RichTextAttributeEditor) {
>+				// create composite to hold rounded border
> 				Composite roundedBorder = EditorUtil.createBorder(composite, toolkit, !summaryEditor.isReadOnly());
> 				summaryEditor.createControl(roundedBorder, toolkit);
> 				EditorUtil.setHeaderFontSizeAndStyle(summaryEditor.getControl());
> 			} else {
>-				summaryEditor.createControl(composite, toolkit);
>+				final Composite border = toolkit.createComposite(composite);
> 				GridDataFactory.fillDefaults().align(SWT.FILL, SWT.BEGINNING).hint(EditorUtil.MAXIMUM_WIDTH,
>-						SWT.DEFAULT).grab(true, false).applyTo(summaryEditor.getControl());
>+						SWT.DEFAULT).grab(true, false).applyTo(border);
>+				// leave some padding for the border of the attribute editor
>+				border.setLayout(GridLayoutFactory.fillDefaults().margins(1, 4).create());
>+				summaryEditor.createControl(border, toolkit);
>+				GridDataFactory.fillDefaults().align(SWT.FILL, SWT.CENTER).grab(true, false).applyTo(
>+						summaryEditor.getControl());
>+				toolkit.paintBordersFor(border);
> 			}
> 			getTaskEditorPage().getAttributeEditorToolkit().adapt(summaryEditor);
> 		}

Actions: View | Diff

Attachments on bug 280811: 139575 | 143966 | 143967