Attachment 143086 Details for Bug 285229 – patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch

285229.txt (text/plain), 1.44 KB, created by Andrew Niefer

on 2009-07-30 16:37:25 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Niefer

Created: 2009-07-30 16:37:25 EDT

Size: 1.44 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.pde.core
>Index: src/org/eclipse/pde/internal/core/exports/FeatureExportOperation.java
>===================================================================
>RCS file: /cvsroot/eclipse/pde/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/exports/FeatureExportOperation.java,v
>retrieving revision 1.33
>diff -u -r1.33 FeatureExportOperation.java
>--- src/org/eclipse/pde/internal/core/exports/FeatureExportOperation.java	29 Apr 2009 17:34:11 -0000	1.33
>+++ src/org/eclipse/pde/internal/core/exports/FeatureExportOperation.java	30 Jul 2009 20:29:57 -0000
>@@ -39,7 +39,7 @@
> import org.eclipse.pde.internal.core.feature.FeatureChild;
> import org.eclipse.pde.internal.core.ifeature.*;
> import org.eclipse.pde.internal.core.util.CoreUtility;
>-import org.osgi.framework.InvalidSyntaxException;
>+import org.osgi.framework.Filter;
> import org.w3c.dom.*;
> 
> public class FeatureExportOperation extends Job {
>@@ -1045,12 +1045,8 @@
> 	}
> 
> 	protected boolean shouldAddPlugin(BundleDescription bundle, Dictionary environment) {
>-		String filterSpec = bundle.getPlatformFilter();
>-		try {
>-			return (filterSpec == null || PDECore.getDefault().getBundleContext().createFilter(filterSpec).match(environment));
>-		} catch (InvalidSyntaxException e) {
>-		}
>-		return false;
>+		Filter filter = BundleHelper.getDefault().getFilter(bundle);
>+		return (filter == null || filter.match(environment));
> 	}
> 
> 	/**

Actions: View | Diff

Attachments on bug 285229: 143086