Attachment 142139 Details for Bug 284131 – proposed patch - draft

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] proposed patch - draft

bug284131-patch1.txt (text/plain), 1.60 KB, created by Stephan Herrmann

on 2009-07-21 10:28:33 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Stephan Herrmann

Created: 2009-07-21 10:28:33 EDT

Size: 1.60 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/lookup/BinaryTypeBinding.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/BinaryTypeBinding.java,v
>retrieving revision 1.119
>diff -u -r1.119 BinaryTypeBinding.java
>--- compiler/org/eclipse/jdt/internal/compiler/lookup/BinaryTypeBinding.java	16 Jun 2009 17:52:18 -0000	1.119
>+++ compiler/org/eclipse/jdt/internal/compiler/lookup/BinaryTypeBinding.java	21 Jul 2009 14:19:59 -0000
>@@ -301,6 +301,13 @@
> 			TypeVariableBinding[] typeVars = Binding.NO_TYPE_VARIABLES;
> 			char[] methodDescriptor = binaryType.getEnclosingMethod();
> 			if (methodDescriptor != null) {
>+				// prepare for findMethod below:
>+				if (needFieldsAndMethods) {
>+					createFields(binaryType.getFields(), sourceLevel, missingTypeNames);
>+				}
>+				createMethods(binaryType.getMethods(), sourceLevel, missingTypeNames);
>+				needFieldsAndMethods = false; // mark as done
>+				
> 				MethodBinding enclosingMethod = findMethod(methodDescriptor, missingTypeNames);
> 				typeVars = enclosingMethod.typeVariables;
> 			}
>@@ -682,8 +689,8 @@
> 	int startIndex = 0;
> 	if (numOfParams > 0) {
> 		parameters = new TypeBinding[numOfParams];
>-		index = 1;
>-		int end = 0;   // first character is always '(' so skip it
>+		index = selector.length+1;  // next character is always '(' so skip it
>+		int end = index-1;
> 		for (int i = 0; i < numOfParams; i++) {
> 			while ((nextChar = methodDescriptor[++end]) == '['){/*empty*/}
> 			if (nextChar == 'L')

Actions: View | Diff

Attachments on bug 284131: 142137 | 142139 | 142146