Attachment 142008 Details for Bug 282425 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

Bug-282425.patch (text/plain), 1.22 KB, created by Jordan Yakovchev

on 2009-07-20 09:17:42 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jordan Yakovchev

Created: 2009-07-20 09:17:42 EDT

Size: 1.22 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Table.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Table.js,v
>retrieving revision 1.58
>diff -u -r1.58 Table.js
>--- js/org/eclipse/swt/widgets/Table.js	9 Jul 2009 07:13:58 -0000	1.58
>+++ js/org/eclipse/swt/widgets/Table.js	20 Jul 2009 13:17:23 -0000
>@@ -791,6 +791,16 @@
>             } else if( topIndex > this._itemCount ) {
>               topIndex = this._itemCount;
>             }
>+            // Fix for bug #282425:
>+            // If gotoIndex points one of the items of the last page, when PageDown
>+            // is used, the top index is set so the last page to be visible
>+            var lastPageTopIndex = this._itemCount - this._getFullyVisibleRowCount();
>+            if(    gotoIndex > lastPageTopIndex
>+                && gotoIndex < this._itemCount
>+                && keyIdentifier === "PageDown" )
>+            {
>+              topIndex = lastPageTopIndex;
>+            }
>             this._internalSetTopIndex( topIndex, true );
>           }
>           this.setFocusIndex( gotoIndex );

Actions: View | Diff

Attachments on bug 282425: 142008