Attachment 140986 Details for Bug 282540 – Another proposed fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Another proposed fix

clipboard.txt (text/plain), 2.64 KB, created by Ralf Sternberg

on 2009-07-07 14:02:31 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Sternberg

Created: 2009-07-07 14:02:31 EDT

Size: 2.64 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Combo.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Combo.js,v
>retrieving revision 1.22
>diff -u -r1.22 Combo.js
>--- js/org/eclipse/swt/widgets/Combo.js	9 Jun 2009 11:19:16 -0000	1.22
>+++ js/org/eclipse/swt/widgets/Combo.js	7 Jul 2009 17:50:44 -0000
>@@ -65,7 +65,7 @@
>     this.addEventListener( "changeFont", this._onChangeFont, this );
>     this.addEventListener( "changeTextColor", this._onChangeTextColor, this );
>     this.addEventListener( "changeBackgroundColor",
>-                           this._onChangeBackgoundColor, 
>+                           this._onChangeBackgroundColor, 
>                            this );
>     this.addEventListener( "changeVisibility", this._onChangeVisibility, this );
>     // Mouse events
>@@ -95,7 +95,7 @@
>     this.removeEventListener( "changeFont", this._onChangeFont, this );
>     this.removeEventListener( "changeTextColor", this._onChangeTextColor, this );
>     this.removeEventListener( "changeBackgroundColor",
>-                              this._onChangeBackgoundColor, 
>+                              this._onChangeBackgroundColor, 
>                               this );
>     this.removeEventListener( "changeVisibility", this._onChangeVisibility, this );
>     this.removeEventListener( "mousedown", this._onMouseDown, this );
>@@ -126,6 +126,23 @@
>   },
> 
>   members : {
>+
>+    addState : function( state ) {
>+      this.base( arguments, state );
>+      if( state.substr( 0, 8 ) == "variant_" ) {
>+        this._field.addState( state );
>+        this._list.addState( state );
>+      }
>+    },
>+
>+    removeState : function( state ) {
>+      this.base( arguments, state );
>+      if( state.substr( 0, 8 ) == "variant_" ) {
>+        this._field.removeState( state );
>+        this._list.removeState( state );
>+      }
>+    },
>+
>     _onChangeSize : function( evt ) {
>       this._list.setWidth( this.getWidth() );
>       this._setListLocation();
>@@ -180,10 +197,14 @@
>       this._list.setTextColor( value );
>     },
> 
>-    _onChangeBackgoundColor : function( evt ) {
>-      var value = evt.getValue();
>-      this._field.setBackgroundColor( value );
>-      this._list.setBackgroundColor( value );
>+    _onChangeBackgroundColor : function( evt ) {
>+      var color = evt.getValue();
>+      this._field.setBackgroundColor( color );
>+      if( color != null ) {
>+        this._list.setBackgroundColor( color );
>+      } else {
>+        this._list.resetBackgroundColor();
>+      }
>     },
>     
>     _onChangeVisibility : function( evt ) {

Actions: View | Diff

Attachments on bug 282540: 140878 | 140962 | 140986