Attachment 140962 Details for Bug 282540 – Proposed fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed fix

clipboard.txt (text/plain), 1.01 KB, created by Rüdiger Herrmann

on 2009-07-07 09:57:35 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rüdiger Herrmann

Created: 2009-07-07 09:57:35 EDT

Size: 1.01 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Combo.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Combo.js,v
>retrieving revision 1.22
>diff -u -r1.22 Combo.js
>--- js/org/eclipse/swt/widgets/Combo.js	9 Jun 2009 11:19:16 -0000	1.22
>+++ js/org/eclipse/swt/widgets/Combo.js	7 Jul 2009 13:57:34 -0000
>@@ -181,9 +181,13 @@
>     },
> 
>     _onChangeBackgoundColor : function( evt ) {
>-      var value = evt.getValue();
>-      this._field.setBackgroundColor( value );
>-      this._list.setBackgroundColor( value );
>+      var color = evt.getValue();
>+      this._field.setBackgroundColor( color );
>+      if( color == null ) {
>+        var tv = new org.eclipse.swt.theme.ThemeValues( {} );
>+        color = tv.getCssColor( "Combo", "background-color" );  
>+      } 
>+      this._list.setBackgroundColor( color );
>     },
>     
>     _onChangeVisibility : function( evt ) {

Actions: View | Diff

Attachments on bug 282540: 140878 | 140962 | 140986