Attachment 140585 Details for Bug 281770 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

spinner-bug281770-patch.txt (text/plain), 5.72 KB, created by Asen Draganov

on 2009-07-01 07:23:05 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Asen Draganov

Created: 2009-07-01 07:23:05 EDT

Size: 5.72 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt
>Index: src/org/eclipse/swt/internal/widgets/spinnerkit/Spinner.theme.xml
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt/src/org/eclipse/swt/internal/widgets/spinnerkit/Spinner.theme.xml,v
>retrieving revision 1.6
>diff -u -r1.6 Spinner.theme.xml
>--- src/org/eclipse/swt/internal/widgets/spinnerkit/Spinner.theme.xml	9 Apr 2009 13:03:50 -0000	1.6
>+++ src/org/eclipse/swt/internal/widgets/spinnerkit/Spinner.theme.xml	1 Jul 2009 11:12:01 -0000
>@@ -1,6 +1,6 @@
> <?xml version="1.0" encoding="iso-8859-1" ?>
> 
> 
> <theme>
>@@ -49,6 +50,21 @@
>           The size of the image should be 12 x 5 pixels.
>         </description>
>       </property>
>+      
>+      <property name="background-color" type="color">
>+        <description>
>+          The background color of the Spinner up button.
>+        </description>
>+      </property> 
>+
>+      <property name="border" type="border">
>+        <description>
>+          The border of the Spinner up button.
>+        </description>
>+      </property>
>+          
>+      <state name="pressed"
>+          description="Applies while a button is pressed." />
> 
>     </element>
> 
>@@ -61,6 +77,21 @@
>           The size of the image should be 12 x 5 pixels.
>         </description>
>       </property>
>+      
>+      <property name="background-color" type="color">
>+        <description>
>+          The background color of the Spinner down button.
>+        </description>
>+      </property> 
>+
>+      <property name="border" type="border">
>+        <description>
>+          The border of the Spinner down button.
>+        </description>
>+      </property>
>+          
>+      <state name="pressed"
>+          description="Applies while a button is pressed." />
> 
>     </element>
> 
>Index: src/org/eclipse/swt/internal/widgets/spinnerkit/Spinner.default.css
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt/src/org/eclipse/swt/internal/widgets/spinnerkit/Spinner.default.css,v
>retrieving revision 1.4
>diff -u -r1.4 Spinner.default.css
>--- src/org/eclipse/swt/internal/widgets/spinnerkit/Spinner.default.css	13 May 2009 19:34:04 -0000	1.4
>+++ src/org/eclipse/swt/internal/widgets/spinnerkit/Spinner.default.css	1 Jul 2009 11:12:01 -0000
>@@ -13,8 +13,20 @@
> 
> Spinner-UpButton {
>   background-image: url( resource/widget/rap/spinner/up_button.gif );
>+  background-color: rgb( 248, 248, 255 );
>+  border: 2px outset;
>+}
>+
>+Spinner-UpButton:pressed {
>+  border: 2px inset;
> }
> 
> Spinner-DownButton {
>   background-image: url( resource/widget/rap/spinner/down_button.gif );
>-}
>\ No newline at end of file
>+  background-color: rgb( 248, 248, 255 );
>+  border: 2px outset;
>+}
>+
>+Spinner-DownButton:pressed {
>+  border: 2px inset;
>+}
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/theme/AppearancesBase.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/theme/AppearancesBase.js,v
>retrieving revision 1.103
>diff -u -r1.103 AppearancesBase.js
>--- js/org/eclipse/swt/theme/AppearancesBase.js	30 Jun 2009 22:21:37 -0000	1.103
>+++ js/org/eclipse/swt/theme/AppearancesBase.js	1 Jul 2009 11:12:04 -0000
>@@ -1154,41 +1154,29 @@
>     }
>   },
> 
>-  "spinner-button" : {
>-    style : function( states ) {
>-      var tv = new org.eclipse.swt.theme.ThemeValues( states );
>-      var result = {
>-        width : 16,
>-        backgroundColor : tv.getCssColor( "*", "background-color" )
>-      };
>-      if( states.rwt_FLAT ) {
>-        result.border = "undefined";
>-      } else if( states.pressed || states.checked || states.abandoned ) {
>-        result.border = "inset";
>-      } else {
>-        result.border = "outset";
>-      }
>-      return result;
>-    }
>-  },
>-
>   "spinner-button-up" : {
>-    include : "spinner-button",
>     style : function( states ) {
>+      var result = {};
>       var tv = new org.eclipse.swt.theme.ThemeValues( states );
>-      return {
>-        source : tv.getCssImage( "Spinner-UpButton", "background-image" )
>-      };
>+      result.width = 16;
>+      result.source = tv.getCssImage( "Spinner-UpButton", "background-image" );
>+      result.border = tv.getCssBorder( "Spinner-UpButton", "border" );
>+      result.backgroundColor = tv.getCssColor( "Spinner-UpButton", 
>+                                               "background-color" );
>+      return result;
>     }
>   },
> 
>   "spinner-button-down" : {
>-    include : "spinner-button",
>     style : function( states ) {
>+      var result = {};
>       var tv = new org.eclipse.swt.theme.ThemeValues( states );
>-      return {
>-        source : tv.getCssImage( "Spinner-DownButton", "background-image" )
>-      };
>+      result.width = 16;
>+      result.source = tv.getCssImage( "Spinner-DownButton", "background-image" );
>+      result.border = tv.getCssBorder( "Spinner-DownButton", "border" );
>+      result.backgroundColor = tv.getCssColor( "Spinner-DownButton", 
>+                                               "background-color" );
>+      return result;
>     }
>   },
>

Actions: View | Diff

Attachments on bug 281770: 140585